Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Changeset View
Changeset View
Standalone View
Standalone View
test/Isl/CodeGen/run-time-condition-with-scev-parameters.ll
; RUN: opt %loadPolly -polly-codegen-isl -S -polly-delinearize < %s | FileCheck %s | ; RUN: opt %loadPolly -polly-codegen-isl -S -polly-delinearize < %s | FileCheck %s | ||||
; RUN: opt %loadPolly -polly-codegen-isl -S -polly-delinearize -polly-codegen-scev < %s | FileCheck %s | ; RUN: opt %loadPolly -polly-codegen-isl -S -polly-delinearize -polly-codegen-scev < %s | FileCheck %s | ||||
; CHECK: %1 = zext i32 %n to i64 | ; CHECK: zext i32 %n to i64 | ||||
; CHECK: %2 = icmp sge i64 %1, 1 | ; CHECK: %[[T0:[._a-zA-Z0-9]]] = zext i32 %n to i64 | ||||
; CHECK: %3 = select i1 %2, i64 1, i64 0 | ; CHECK: %[[T1:[._a-zA-Z0-9]]] = icmp sge i64 %[[T0]], 1 | ||||
; CHECK: %4 = icmp ne i64 0, %3 | ; CHECK: %[[T2:[._a-zA-Z0-9]]] = select i1 %[[T1]], i64 1, i64 0 | ||||
; CHECK: %[[T3:[._a-zA-Z0-9]]] = icmp ne i64 %[[T2]], 0 | |||||
grosser: I just checked what has changed in the actual test case output and it seems the actual change… | |||||
jdoerfertAuthorUnsubmitted Not Done ReplyInline ActionsEven if it doesn't change the statement numbers, someone at somepoint will and he/she/it has to fix test cases like this with no good reason to hardcode these numbers. We do not care if it is called %1 or %0 here, why test for it?!? jdoerfert: Even if it doesn't change the statement numbers, someone at somepoint will and he/she/it has to… | |||||
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" | target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" | ||||
target triple = "x86_64-unknown-linux-gnu" | target triple = "x86_64-unknown-linux-gnu" | ||||
define void @init_array(i32 %n, double* %data) { | define void @init_array(i32 %n, double* %data) { | ||||
entry: | entry: | ||||
%0 = zext i32 %n to i64 | %0 = zext i32 %n to i64 | ||||
br label %for.body4 | br label %for.body4 | ||||
Show All 13 Lines |
I just checked what has changed in the actual test case output and it seems the actual change is:
-; CHECK: %4 = icmp ne i64 0, %3
+; CHECK: %4 = icmp ne i64 %3, 0
Introducing the regexp seems not necessary here and also hides the actual change needed. In fact, I run this test case trying to understand why your refactoring caused the statement numbers to change.