Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Changeset View
Changeset View
Standalone View
Standalone View
include/polly/CodeGen/IRBuilder.h
Show First 20 Lines • Show All 90 Lines • ▼ Show 20 Lines | private: | ||||
class LoopAnnotator *Annotator; | class LoopAnnotator *Annotator; | ||||
}; | }; | ||||
// TODO: We should not name instructions in NDEBUG builds. | // TODO: We should not name instructions in NDEBUG builds. | ||||
// | // | ||||
// We currently always name instructions, as the polly test suite currently | // We currently always name instructions, as the polly test suite currently | ||||
// matches for certain names. | // matches for certain names. | ||||
// | // | ||||
// typedef PollyBuilderInserter<false> IRInserter; | // typedef PollyBuilderInserter<false> IRInserter; | ||||
dpeixott: It looks like these comments are just commented out code. Could probably delete them as long as… | |||||
// typedef llvm::IRBuilder<false, llvm::ConstantFolder, IRInserter> | // typedef llvm::IRBuilder<false, llvm::ConstantFolder, IRInserter> | ||||
// PollyIRBuilder; | // PollyIRBuilder; | ||||
typedef PollyBuilderInserter<true> IRInserter; | typedef PollyBuilderInserter<true> IRInserter; | ||||
typedef llvm::IRBuilder<true, llvm::ConstantFolder, IRInserter> PollyIRBuilder; | typedef llvm::IRBuilder<true, llvm::ConstantFolder, IRInserter> PollyIRBuilder; | ||||
/// @brief Return an IR builder pointed before the @p BB terminator. | |||||
static inline PollyIRBuilder createPollyIRBuilder(llvm::BasicBlock *BB, | |||||
LoopAnnotator &LA) { | |||||
PollyIRBuilder Builder(BB->getContext(), llvm::ConstantFolder(), | |||||
polly::IRInserter(LA)); | |||||
Builder.SetInsertPoint(BB->getTerminator()); | |||||
return Builder; | |||||
} | |||||
grosserUnsubmitted Not Done ReplyInline ActionsThis looks good. grosser: This looks good. | |||||
} | } | ||||
#endif | #endif |
It looks like these comments are just commented out code. Could probably delete them as long as you are cleaning up.