Subject: Re: [cfe-commits] [Differential] D5: Updated -help message in clang-check.
klimek has commented on the revision "Updated -help message in clang-check.".
INLINE COMMENTS
clang-check/ClangCheck.cpp:25 I think especially with the upcoming patch to allow other build system integration, I'd rather not call this cmake-output-dir. I think build-path is better, and having an explanation that mentions CMake as an example.
REVISION DETAIL
http://llvm-reviews.chandlerc.com/D5
REPLY HANDLER ACTIONS
Reply to comment, or !reject, !abandon, !reclaim, !resign, !rethink, !unsubscribe, !accept.
Subject: Re: [cfe-commits] [Differential] D5: Updated -help message in clang-check.
klimek has commented on the revision "Updated -help message in clang-check.".
INLINE COMMENTS
clang-check/ClangCheck.cpp:25 I think especially with the upcoming patch to allow other build system integration, I'd rather not call this cmake-output-dir. I think build-path is better, and having an explanation that mentions CMake as an example.
REVISION DETAIL
http://llvm-reviews.chandlerc.com/D5
REPLY HANDLER ACTIONS
Reply to comment, or !reject, !abandon, !reclaim, !resign, !rethink, !unsubscribe, !accept.
Subject: Re: [cfe-commits] [Differential] D5: Updated -help message in clang-check.
klimek has commented on the revision "Updated -help message in clang-check.".
INLINE COMMENTS
clang-check/ClangCheck.cpp:25 I think especially with the upcoming patch to allow other build system integration, I'd rather not call this cmake-output-dir. I think build-path is better, and having an explanation that mentions CMake as an example.
REVISION DETAIL
http://llvm-reviews.chandlerc.com/D5
REPLY HANDLER ACTIONS
Reply to comment, or !reject, !abandon, !reclaim, !resign, !rethink, !unsubscribe, !accept.
Subject: Re: [cfe-commits] [Differential] D5: Updated -help message in clang-check.
klimek has commented on the revision "Updated -help message in clang-check.".
INLINE COMMENTS
clang-check/ClangCheck.cpp:25 I think especially with the upcoming patch to allow other build system integration, I'd rather not call this cmake-output-dir. I think build-path is better, and having an explanation that mentions CMake as an example.
REVISION DETAIL
http://llvm-reviews.chandlerc.com/D5
REPLY HANDLER ACTIONS
Reply to comment, or !reject, !abandon, !reclaim, !resign, !rethink, !unsubscribe, !accept.