Page MenuHomePhabricator

D61186.diff
No OneTemporary

File Metadata

Created
Tue, Jul 23, 1:55 AM

D61186.diff

Index: lld/trunk/ELF/LinkerScript.cpp
===================================================================
--- lld/trunk/ELF/LinkerScript.cpp
+++ lld/trunk/ELF/LinkerScript.cpp
@@ -482,6 +482,7 @@
if (Sec->Name == "/DISCARD/") {
discard(V);
Sec->SectionCommands.clear();
+ Sec->SectionIndex = 0; // Not an orphan.
continue;
}
Index: lld/trunk/test/ELF/linkerscript/discard-phdr.s
===================================================================
--- lld/trunk/test/ELF/linkerscript/discard-phdr.s
+++ lld/trunk/test/ELF/linkerscript/discard-phdr.s
@@ -0,0 +1,36 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+# RUN: echo "PHDRS { \
+# RUN: exec PT_LOAD FLAGS(0x4 | 0x1); \
+# RUN: } \
+# RUN: SECTIONS { \
+# RUN: .text : { *(.text) } :exec \
+# RUN: .foo : { *(.foo) } \
+# RUN: .bar : { *(.bar) } \
+# RUN: /DISCARD/ : { *(.discard) } :NONE \
+# RUN: }" > %t.script
+# RUN: ld.lld -o %t --script %t.script %t.o
+# RUN: llvm-readelf -S -l %t | FileCheck %s
+
+## Check that /DISCARD/ does not interfere with the assignment of segments to
+## sections.
+
+# CHECK: Section Headers
+# CHECK: .text
+# CHECK-NEXT: .foo
+# CHECK-NEXT: .bar
+
+# CHECK: Segment Sections
+# CHECK-NEXT: .text .foo .bar
+
+.section .text,"ax"
+ ret
+
+.section .foo,"a"
+ .byte 0
+
+.section .bar,"ax"
+ ret
+
+.section .discard
+ .byte 0

Event Timeline