This is an archive of the discontinued LLVM Phabricator instance.

[lldb/test] Respect --apple-sdk path when querying SDK info
ClosedPublic

Authored by vsk on Apr 1 2021, 10:06 AM.

Details

Summary

Respect --apple-sdk <path> if it's specified. If the SDK simply mounted from
some disk image, and not actually installed, this is the only way to use it.

Diff Detail

Event Timeline

vsk requested review of this revision.Apr 1 2021, 10:06 AM
vsk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 10:06 AM
JDevlieghere accepted this revision.Apr 1 2021, 10:10 AM

LGTM

lldb/packages/Python/lldbsuite/test/lldbutil.py
69

This will also exclude the empty string.

This revision is now accepted and ready to land.Apr 1 2021, 10:10 AM
vsk added inline comments.Apr 1 2021, 10:11 AM
lldb/packages/Python/lldbsuite/test/lldbutil.py
69

Thanks, I'll fix this before committing.

This revision was landed with ongoing or failed builds.Apr 1 2021, 10:15 AM
This revision was automatically updated to reflect the committed changes.