Index: llvm/lib/Analysis/ScalarEvolution.cpp =================================================================== --- llvm/lib/Analysis/ScalarEvolution.cpp +++ llvm/lib/Analysis/ScalarEvolution.cpp @@ -5687,8 +5687,18 @@ // until the caller issue can be fixed. PR49566 tracks the bug. return CR; - // TODO: Handle ashr and lshr cases to increase minimum value reported - if (BO->getOpcode() != Instruction::Shl || BO->getOperand(0) != P) + // TODO: Extend to other opcodes such as mul, and div + switch (BO->getOpcode()) { + default: + return CR; + case Instruction::AShr: + case Instruction::LShr: + case Instruction::Shl: + break; + }; + + if (BO->getOperand(0) != P) + // TODO: Handle the power function forms some day. return CR; unsigned TC = getSmallConstantMaxTripCount(L); @@ -5708,12 +5718,50 @@ if (Overflow) return CR; - // Iff no bits are shifted out, value increases on every shift. - auto KnownEnd = KnownBits::shl(KnownStart, - KnownBits::makeConstant(TotalShift)); - if (TotalShift.ult(KnownStart.countMinLeadingZeros())) - CR = CR.intersectWith(ConstantRange(KnownStart.getMinValue(), - KnownEnd.getMaxValue() + 1)); + switch (BO->getOpcode()) { + default: + llvm_unreachable("filtered out above"); + case Instruction::AShr: { + // For each ashr, three cases: + // shift = 0 => unchanged value + // saturation => 0 or -1 + // other => a value closer to zero (but sign unknown) + // Thus, the end value is closer to zero than the start. + auto KnownEnd = KnownBits::ashr(KnownStart, + KnownBits::makeConstant(TotalShift)); + // For a negative range, we prefer the inverted range which has fewer + // elements. Either would be a valid result for a negative start. + auto R = KnownStart.isNegative() ? + ConstantRange::getNonEmpty(KnownStart.getMinValue(), + KnownEnd.getMaxValue() + 1) : + ConstantRange::getNonEmpty(KnownEnd.getMinValue(), + KnownStart.getMaxValue() + 1); + CR = CR.intersectWith(R); + break; + } + case Instruction::LShr: { + // For each lshr, three cases: + // shift = 0 => unchanged value + // saturation => 0 + // other => a smaller positive number + // Thus, the low end of the unsigned range is the last value produced. + auto KnownEnd = KnownBits::lshr(KnownStart, + KnownBits::makeConstant(TotalShift)); + auto R = ConstantRange::getNonEmpty(KnownEnd.getMinValue(), + KnownStart.getMaxValue() + 1); + CR = CR.intersectWith(R); + break; + } + case Instruction::Shl: { + // Iff no bits are shifted out, value increases on every shift. + auto KnownEnd = KnownBits::shl(KnownStart, + KnownBits::makeConstant(TotalShift)); + if (TotalShift.ult(KnownStart.countMinLeadingZeros())) + CR = CR.intersectWith(ConstantRange(KnownStart.getMinValue(), + KnownEnd.getMaxValue() + 1)); + break; + } + }; return CR; } Index: llvm/test/Analysis/ScalarEvolution/shift-recurrences.ll =================================================================== --- llvm/test/Analysis/ScalarEvolution/shift-recurrences.ll +++ llvm/test/Analysis/ScalarEvolution/shift-recurrences.ll @@ -449,7 +449,7 @@ ; CHECK-NEXT: %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ] ; CHECK-NEXT: --> {0,+,1}<%loop> U: [0,5) S: [0,5) Exits: 4 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.ashr = phi i64 [ 1023, %entry ], [ %iv.ashr.next, %loop ] -; CHECK-NEXT: --> %iv.ashr U: [0,1024) S: [0,1024) Exits: 63 LoopDispositions: { %loop: Variant } +; CHECK-NEXT: --> %iv.ashr U: [63,1024) S: [63,1024) Exits: 63 LoopDispositions: { %loop: Variant } ; CHECK-NEXT: %iv.next = add i64 %iv, 1 ; CHECK-NEXT: --> {1,+,1}<%loop> U: [1,6) S: [1,6) Exits: 5 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.ashr.next = ashr i64 %iv.ashr, 1 @@ -480,7 +480,7 @@ ; CHECK-NEXT: %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ] ; CHECK-NEXT: --> {0,+,1}<%loop> U: [0,5) S: [0,5) Exits: 4 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.ashr = phi i8 [ -128, %entry ], [ %iv.ashr.next, %loop ] -; CHECK-NEXT: --> %iv.ashr U: [-128,0) S: [-128,0) Exits: -8 LoopDispositions: { %loop: Variant } +; CHECK-NEXT: --> %iv.ashr U: [-128,-7) S: [-128,-7) Exits: -8 LoopDispositions: { %loop: Variant } ; CHECK-NEXT: %iv.next = add i64 %iv, 1 ; CHECK-NEXT: --> {1,+,1}<%loop> U: [1,6) S: [1,6) Exits: 5 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.ashr.next = ashr i8 %iv.ashr, 1 @@ -546,11 +546,11 @@ ; CHECK-NEXT: %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ] ; CHECK-NEXT: --> {0,+,1}<%loop> U: [0,5) S: [0,5) Exits: 4 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.lshr = phi i64 [ 1023, %entry ], [ %iv.lshr.next, %loop ] -; CHECK-NEXT: --> %iv.lshr U: [0,1024) S: [0,1024) Exits: 63 LoopDispositions: { %loop: Variant } +; CHECK-NEXT: --> %iv.lshr U: [63,1024) S: [63,1024) Exits: 63 LoopDispositions: { %loop: Variant } ; CHECK-NEXT: %iv.next = add i64 %iv, 1 ; CHECK-NEXT: --> {1,+,1}<%loop> U: [1,6) S: [1,6) Exits: 5 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.lshr.next = lshr i64 %iv.lshr, 1 -; CHECK-NEXT: --> (%iv.lshr /u 2) U: [0,512) S: [0,512) Exits: 31 LoopDispositions: { %loop: Variant } +; CHECK-NEXT: --> (%iv.lshr /u 2) U: [31,512) S: [31,512) Exits: 31 LoopDispositions: { %loop: Variant } ; CHECK-NEXT: Determining loop execution counts for: @test_lshr_tc_positive ; CHECK-NEXT: Loop %loop: backedge-taken count is 4 ; CHECK-NEXT: Loop %loop: max backedge-taken count is 4 @@ -577,11 +577,11 @@ ; CHECK-NEXT: %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ] ; CHECK-NEXT: --> {0,+,1}<%loop> U: [0,5) S: [0,5) Exits: 4 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.lshr = phi i8 [ -1, %entry ], [ %iv.lshr.next, %loop ] -; CHECK-NEXT: --> %iv.lshr U: [-1,-128) S: [-1,-128) Exits: 15 LoopDispositions: { %loop: Variant } +; CHECK-NEXT: --> %iv.lshr U: [15,0) S: [-1,-128) Exits: 15 LoopDispositions: { %loop: Variant } ; CHECK-NEXT: %iv.next = add i64 %iv, 1 ; CHECK-NEXT: --> {1,+,1}<%loop> U: [1,6) S: [1,6) Exits: 5 LoopDispositions: { %loop: Computable } ; CHECK-NEXT: %iv.lshr.next = lshr i8 %iv.lshr, 1 -; CHECK-NEXT: --> (%iv.lshr /u 2) U: [0,-128) S: [0,-128) Exits: 7 LoopDispositions: { %loop: Variant } +; CHECK-NEXT: --> (%iv.lshr /u 2) U: [7,-128) S: [7,-128) Exits: 7 LoopDispositions: { %loop: Variant } ; CHECK-NEXT: Determining loop execution counts for: @test_lshr_tc_negative ; CHECK-NEXT: Loop %loop: backedge-taken count is 4 ; CHECK-NEXT: Loop %loop: max backedge-taken count is 4