This is an archive of the discontinued LLVM Phabricator instance.

Differential D99618

Docs: Update dead links to SVN in Contributing.rst
ClosedPublic

Authored by cr3ative on Mar 30 2021, 1:34 PM.

Details

Reviewers
ldionne
jfb
Summary

Just tidying up some dead links for new ones on the github version! Sorry for submitting this to github first time around. I am a dunce. I hope this is correct.

Diff Detail

Unit TestsFailed

TimeTest
2,060 msx64 debian > libarcher.races::lock-unrelated.c

Event Timeline

cr3ative requested review of this revision.Mar 30 2021, 1:34 PM
cr3ative created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2021, 1:34 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
cr3ative added reviewers: ldionne, jfb.Mar 30 2021, 1:37 PM
ldionne accepted this revision.Mar 30 2021, 1:57 PM

LGTM. Do you need someone to commit this for you?

This revision is now accepted and ready to land.Mar 30 2021, 1:57 PM
cr3ative added a comment.Mar 30 2021, 1:58 PM

Yes please! Many thanks.

ldionne added a comment.Mar 30 2021, 2:00 PM

Can you provide Author Name <email@domain> for commit attribution?

Harbormaster completed remote builds in B96395: Diff 334262.Mar 30 2021, 2:06 PM
cr3ative added a comment.Mar 30 2021, 2:33 PM

Sure:

Paul Curry <github@cr3ation.co.uk>

lunasorcery added subscribers: jroelofs, lunasorcery.Mar 30 2021, 2:43 PM

Looks like this has been separately addressed by @jroelofs, linking to the updated urls on the Phabricator rather than off-site to GitHub.

https://reviews.llvm.org/rG58cbb222ebba687d1f710de56649f1e201f646dc

cr3ative added a comment.Mar 30 2021, 2:45 PM

Hooray! I think!

ldionne closed this revision.Mar 30 2021, 2:46 PM

Yup, indeed. Let's close this then.

jroelofs added a comment.Mar 30 2021, 2:48 PM

There's one more case of the general problem if you want to take a stab at it: llvm/docs/TestSuiteGuide.md (see the instructions for installing LIT)

Revision Contents

PathSize
llvm/
docs/
4 lines

Diff 334262

llvm/docs/Contributing.rst

Context not available.
.. _irc.oftc.net: irc://irc.oftc.net/llvm .. _irc.oftc.net: irc://irc.oftc.net/llvm
.. _beginner keyword: https://bugs.llvm.org/buglist.cgi?bug_status=NEW&bug_status=REOPENED&keywords=beginner%2C%20&keywords_type=allwords&list_id=130748&query_format=advanced&resolution=--- .. _beginner keyword: https://bugs.llvm.org/buglist.cgi?bug_status=NEW&bug_status=REOPENED&keywords=beginner%2C%20&keywords_type=allwords&list_id=130748&query_format=advanced&resolution=---
.. _bug tracker: https://bugs.llvm.org .. _bug tracker: https://bugs.llvm.org
.. _clang-format-diff.py: https://reviews.llvm.org/source/clang/browse/cfe/trunk/tools/clang-format/clang-format-diff.py .. _clang-format-diff.py: https://github.com/llvm/llvm-project/blob/main/clang/tools/clang-format/clang-format-diff.py
.. _git-clang-format: https://reviews.llvm.org/source/clang/browse/cfe/trunk/tools/clang-format/git-clang-format .. _git-clang-format: https://github.com/llvm/llvm-project/blob/main/clang/tools/clang-format/git-clang-format
.. _LLVM's Phabricator: https://reviews.llvm.org/ .. _LLVM's Phabricator: https://reviews.llvm.org/
.. _LLVM's Open Projects page: https://llvm.org/OpenProjects.html#what .. _LLVM's Open Projects page: https://llvm.org/OpenProjects.html#what
.. _LLVM Developer's mailing list: http://lists.llvm.org/mailman/listinfo/llvm-dev .. _LLVM Developer's mailing list: http://lists.llvm.org/mailman/listinfo/llvm-dev
Context not available.