diff --git a/llvm/lib/Target/X86/X86FrameLowering.h b/llvm/lib/Target/X86/X86FrameLowering.h --- a/llvm/lib/Target/X86/X86FrameLowering.h +++ b/llvm/lib/Target/X86/X86FrameLowering.h @@ -192,6 +192,10 @@ bool has128ByteRedZone(const MachineFunction& MF) const; private: + bool isWin64Prologue(const MachineFunction &MF) const; + + bool needsDwarfCFI(const MachineFunction &MF) const; + uint64_t calculateMaxStackAlign(const MachineFunction &MF) const; /// Emit target stack probe as a call to a helper function diff --git a/llvm/lib/Target/X86/X86FrameLowering.cpp b/llvm/lib/Target/X86/X86FrameLowering.cpp --- a/llvm/lib/Target/X86/X86FrameLowering.cpp +++ b/llvm/lib/Target/X86/X86FrameLowering.cpp @@ -553,6 +553,8 @@ MachineBasicBlock::iterator MBBI, const DebugLoc &DL, uint64_t Offset, uint64_t AlignOffset) const { + const bool NeedsDwarfCFI = needsDwarfCFI(MF); + const bool HasFP = hasFP(MF); const X86Subtarget &STI = MF.getSubtarget(); const X86TargetLowering &TLI = *STI.getTargetLowering(); const unsigned Opc = getSUBriOpcode(Uses64BitFramePtr, Offset); @@ -570,6 +572,11 @@ .addReg(StackPtr) .addImm(StackProbeSize - AlignOffset) .setMIFlag(MachineInstr::FrameSetup); + if (!HasFP && NeedsDwarfCFI) { + BuildCFI(MBB, MBBI, DL, + MCCFIInstruction::createAdjustCfaOffset( + nullptr, StackProbeSize - AlignOffset)); + } MI->getOperand(3).setIsDead(); // The EFLAGS implicit def is dead. addRegOffset(BuildMI(MBB, MBBI, DL, TII.get(MovMIOpc)) @@ -591,7 +598,11 @@ .setMIFlag(MachineInstr::FrameSetup); MI->getOperand(3).setIsDead(); // The EFLAGS implicit def is dead. - + if (!HasFP && NeedsDwarfCFI) { + BuildCFI( + MBB, MBBI, DL, + MCCFIInstruction::createAdjustCfaOffset(nullptr, StackProbeSize)); + } addRegOffset(BuildMI(MBB, MBBI, DL, TII.get(MovMIOpc)) .setMIFlag(MachineInstr::FrameSetup), StackPtr, false, 0) @@ -607,6 +618,8 @@ .addReg(StackPtr) .addImm(ChunkSize) .setMIFlag(MachineInstr::FrameSetup); + // No need to adjust Dwarf CFA offset here, the last position of the stack has + // been defined MI->getOperand(3).setIsDead(); // The EFLAGS implicit def is dead. } @@ -1200,6 +1213,13 @@ return Is64Bit && !IsWin64CC && !Fn.hasFnAttribute(Attribute::NoRedZone); } +bool X86FrameLowering::isWin64Prologue(const MachineFunction &MF) const { + return MF.getTarget().getMCAsmInfo()->usesWindowsCFI(); +} + +bool X86FrameLowering::needsDwarfCFI(const MachineFunction &MF) const { + return !isWin64Prologue(MF) && MF.needsFrameMoves(); +} /// emitPrologue - Push callee-saved registers onto the stack, which /// automatically adjust the stack pointer. Adjust the stack pointer to allocate @@ -1305,13 +1325,13 @@ MF.hasEHFunclets() && Personality == EHPersonality::CoreCLR; bool IsClrFunclet = IsFunclet && FnHasClrFunclet; bool HasFP = hasFP(MF); - bool IsWin64Prologue = MF.getTarget().getMCAsmInfo()->usesWindowsCFI(); + bool IsWin64Prologue = isWin64Prologue(MF); bool NeedsWin64CFI = IsWin64Prologue && Fn.needsUnwindTableEntry(); // FIXME: Emit FPO data for EH funclets. bool NeedsWinFPO = !IsFunclet && STI.isTargetWin32() && MMI.getModule()->getCodeViewFlag(); bool NeedsWinCFI = NeedsWin64CFI || NeedsWinFPO; - bool NeedsDwarfCFI = !IsWin64Prologue && MF.needsFrameMoves(); + bool NeedsDwarfCFI = needsDwarfCFI(MF); Register FramePtr = TRI->getFrameRegister(MF); const Register MachineFramePtr = STI.isTarget64BitILP32() diff --git a/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll b/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll --- a/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll +++ b/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes-mutliple-objects.ll @@ -8,6 +8,7 @@ ; CHECK-LABEL: foo: ; CHECK: # %bb.0: ; CHECK-NEXT: subq $4096, %rsp # imm = 0x1000 +; CHECK-NEXT: .cfi_adjust_cfa_offset 4096 ; CHECK-NEXT: movq $0, (%rsp) ; CHECK-NEXT: subq $1784, %rsp # imm = 0x6F8 ; CHECK-NEXT: .cfi_def_cfa_offset 5888 diff --git a/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll b/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll --- a/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll +++ b/llvm/test/CodeGen/X86/stack-clash-medium-natural-probes.ll @@ -8,6 +8,7 @@ ; CHECK-LABEL: foo: ; CHECK: # %bb.0: ; CHECK-NEXT: subq $4096, %rsp # imm = 0x1000 +; CHECK-NEXT: .cfi_adjust_cfa_offset 4096 ; CHECK-NEXT: movq $0, (%rsp) ; CHECK-NEXT: subq $3784, %rsp # imm = 0xEC8 ; CHECK-NEXT: .cfi_def_cfa_offset 7888 diff --git a/llvm/test/CodeGen/X86/stack-clash-medium.ll b/llvm/test/CodeGen/X86/stack-clash-medium.ll --- a/llvm/test/CodeGen/X86/stack-clash-medium.ll +++ b/llvm/test/CodeGen/X86/stack-clash-medium.ll @@ -6,6 +6,7 @@ ; CHECK-X86-64-LABEL: foo: ; CHECK-X86-64: # %bb.0: ; CHECK-X86-64-NEXT: subq $4096, %rsp # imm = 0x1000 +; CHECK-X86-64-NEXT: .cfi_adjust_cfa_offset 4096 ; CHECK-X86-64-NEXT: movq $0, (%rsp) ; CHECK-X86-64-NEXT: subq $3784, %rsp # imm = 0xEC8 ; CHECK-X86-64-NEXT: .cfi_def_cfa_offset 7888 @@ -18,6 +19,7 @@ ; CHECK-X86-32-LABEL: foo: ; CHECK-X86-32: # %bb.0: ; CHECK-X86-32-NEXT: subl $4096, %esp # imm = 0x1000 +; CHECK-X86-32-NEXT: .cfi_adjust_cfa_offset 4096 ; CHECK-X86-32-NEXT: movl $0, (%esp) ; CHECK-X86-32-NEXT: subl $3916, %esp # imm = 0xF4C ; CHECK-X86-32-NEXT: .cfi_def_cfa_offset 8016 diff --git a/llvm/test/CodeGen/X86/stack-clash-unknown-call.ll b/llvm/test/CodeGen/X86/stack-clash-unknown-call.ll --- a/llvm/test/CodeGen/X86/stack-clash-unknown-call.ll +++ b/llvm/test/CodeGen/X86/stack-clash-unknown-call.ll @@ -10,6 +10,7 @@ ; CHECK-LABEL: foo: ; CHECK: # %bb.0: ; CHECK-NEXT: subq $4096, %rsp # imm = 0x1000 +; CHECK-NEXT: .cfi_adjust_cfa_offset 4096 ; CHECK-NEXT: movq $0, (%rsp) ; CHECK-NEXT: subq $3912, %rsp # imm = 0xF48 ; CHECK-NEXT: .cfi_def_cfa_offset 8016