Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[TestBase.runCmd] Better error message when runCmd fails.
ClosedPublic
Actions

Authored by sivachandra on May 22 2015, 3:03 PM.

Details

Reviewers

Commits

rG3154aa23f31f: [TestBase.runCmd] Better error message when runCmd fails.
rLLDB238363: [TestBase.runCmd] Better error message when runCmd fails.
rL238363: [TestBase.runCmd] Better error message when runCmd fails.

Summary

Before:

AssertionError: False is not True : Process is launched successfully

After:

AssertionError: False is not True : Command 'run a.out' failed.
>>> error: invalid target, create a target using the 'target create' command
>>> Process could not be launched successfully

Diff Detail

Event Timeline

sivachandra updated this revision to Diff 26354.May 22 2015, 3:03 PM

sivachandra retitled this revision from to [TestBase.runCmd] Better error message when runCmd fails..

sivachandra updated this object.

sivachandra edited the test plan for this revision. (Show Details)

vharron accepted this revision.May 22 2015, 3:49 PM

vharron added a reviewer: vharron.

vharron edited edge metadata.

This revision is now accepted and ready to land.May 22 2015, 3:49 PM

vharron removed a reviewer: vharron.May 22 2015, 3:49 PM

This revision now requires review to proceed.May 22 2015, 3:49 PM

I removed my approval, waiting for feedback from others.

sivachandra added a reviewer: clayborg.May 22 2015, 3:58 PM

sivachandra added a subscriber: Unknown Object (MLST).

Ping?

Looks good.

This revision is now accepted and ready to land.May 26 2015, 3:40 PM

sivachandra closed this revision.May 27 2015, 3:31 PM

I don't mind if you revert it.

My personal opinion, my change made the failure message more useful atleast for someone who was reading buildbot logs. Before I landed this, I did ask on lldb-dev if such a change was OK: http://lists.cs.uiuc.edu/pipermail/lldb-dev/2015-May/007545.html

I also agree that all such 'kinds' of failure messages should be changed in a similar fashion. My personal opinion again, there are far too many to attempt to change all at one go. My change was a small step and at a place which was hurting me the most.

Large Diff

This large diff affects 174 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

test/

api/

check_public_api_headers/

TestPublicAPIHeaders.py

2 lines

benchmarks/

continue/

TestBenchmarkContinue.py

2 lines

expression_command/

call-function/

TestCallStdStringFunction.py

2 lines

TestCallStopAndContinue.py

2 lines

formatters/

TestFormatters.py

2 lines

persist_objc_pointeetype/

TestPersistObjCPointeeType.py

2 lines

persistent_ptr_update/

TestPersistentPtrUpdate.py

2 lines

persistent_types/

TestPersistentTypes.py

2 lines

persistent_variables/

TestPersistentVariables.py

2 lines

po_verbosity/

TestPoVerbosity.py

2 lines

radar_8638051/

Test8638051.py

2 lines

radar_9531204/

TestPrintfAfterUp.py

2 lines

radar_9673664/

TestExprHelpExamples.py

2 lines

test/

TestExprs.py

4 lines

TestExprs2.py

2 lines

two-files/

TestObjCTypeQueryFromOtherCompileUnit.py

2 lines

functionalities/

archives/

TestBSDArchives.py

2 lines

breakpoint/

breakpoint_command/

TestBreakpointCommand.py

6 lines

TestRegexpBreakCommand.py

2 lines

breakpoint_conditions/

TestBreakpointConditions.py

4 lines

breakpoint_ignore_count/

TestBreakpointIgnoreCount.py

4 lines

breakpoint_locations/

TestBreakpointLocations.py

4 lines

breakpoint_options/

TestBreakpointOptions.py

2 lines

dummy_target_breakpoints/

TestBreakpointsWithNoTargets.py

2 lines

inlined_breakpoints/

TestInlinedBreakpoints.py

2 lines

conditional_break/

TestConditionalBreak.py

2 lines

data-formatter/

data-formatter-advanced/

TestDataFormatterAdv.py

2 lines

data-formatter-categories/

TestDataFormatterCategories.py

2 lines

data-formatter-cpp/

TestDataFormatterCpp.py

2 lines

data-formatter-disabling/

TestDataFormatterDisabling.py

2 lines

data-formatter-enum-format/

TestDataFormatterEnumFormat.py

2 lines

data-formatter-named-summaries/

TestDataFormatterNamedSummaries.py

2 lines

data-formatter-objc/

TestDataFormatterObjC.py

12 lines

data-formatter-python-synth/

TestDataFormatterPythonSynth.py

4 lines

data-formatter-script/

TestDataFormatterScript.py

2 lines

data-formatter-skip-summary/

TestDataFormatterSkipSummary.py

2 lines

data-formatter-smart-array/

TestDataFormatterSmartArray.py

2 lines

data-formatter-stl/

libcxx/

initializerlist/

TestInitializerList.py

2 lines

iterator/

TestDataFormatterLibccIterator.py

2 lines

list/

TestDataFormatterLibcxxList.py

2 lines

map/

TestDataFormatterLibccMap.py

2 lines

multimap/

TestDataFormatterLibccMultiMap.py

2 lines

multiset/

TestDataFormatterLibcxxMultiSet.py

2 lines

set/

TestDataFormatterLibcxxSet.py

2 lines

string/

TestDataFormatterLibcxxString.py

2 lines

unordered/

TestDataFormatterUnordered.py

2 lines

vbool/

TestDataFormatterLibcxxVBool.py

2 lines

vector/

TestDataFormatterLibcxxVector.py

2 lines

libstdcpp/

iterator/

TestDataFormatterStdIterator.py

2 lines

list/

TestDataFormatterStdList.py

4 lines

map/

TestDataFormatterStdMap.py

2 lines

string/

TestDataFormatterStdString.py

2 lines

vbool/

TestDataFormatterStdVBool.py

2 lines

vector/

TestDataFormatterStdVector.py

2 lines

data-formatter-synth/

TestDataFormatterSynth.py

2 lines

data-formatter-synthval/

TestDataFormatterSynthVal.py

2 lines

format-propagation/

TestFormatPropagation.py

2 lines

frameformat_smallstruct/

TestFrameFormatSmallStruct.py

2 lines

ptr_ref_typedef/

TestPtrRef2Typedef.py

2 lines

rdar-10449092/

Test-rdar-10449092.py

2 lines

rdar-10642615/

Test-rdar-10642615.py

2 lines

rdar-10887661/

TestRdar10887661.py

2 lines

rdar-11086338/

TestRdar11086338.py

2 lines

rdar-11628688/

TestFormattersBoolRefPtr.py

2 lines

rdar-11773899/

TestFormattersBoolRefPtr.py

2 lines

rdar-11988289/

TestRdar 11988289.py

2 lines

rdar-12437442/

TestRdar12437442.py

2 lines

rdar-12529957/

TestRdar12529957.py

2 lines

rdar-13338477/

Test-rdar-13338477.py

2 lines

rdar-3534688/

TestFormattersOneIsSingular.py

2 lines

rdar-9973865/

Test-rdar-9973865.py

2 lines

rdar-9973992/

Test-rdar-9973992.py

2 lines

rdar-9974002/

Test-rdar-9974002.py

2 lines

refpointer-recursion/

TestDataFormatterRefPtrRecursion.py

2 lines

user-format-vs-summary/

TestUserFormatVsSummary.py

2 lines

varscript_formatting/

TestDataFormatterVarScriptFormatting.py

2 lines

vector-types/

TestVectorTypesFormatting.py

2 lines

dead-strip/

TestDeadStrip.py

2 lines

inferior-assert/

TestInferiorAssert.py

8 lines

inferior-changed/

TestInferiorChanged.py

6 lines

inferior-crashing/

TestInferiorCrashing.py

12 lines

recursive-inferior/

TestRecursiveInferior.py

12 lines

load_unload/

TestLoadUnload.py

6 lines

longjmp/

TestLongjmp.py

14 lines

memory/

read/

TestMemoryRead.py

2 lines

non-overlapping-index-variable-i/

TestIndexVariable.py

2 lines

recursion/

TestValueObjectRecursion.py

2 lines

TestRegisters.py

4 lines

set-data/

TestSetData.py

2 lines

target_command/

TestTargetCommand.py

6 lines

thread/

TestNumThreads.py

2 lines

break_after_join/

TestBreakAfterJoin.py

2 lines

concurrent_events/

TestConcurrentEvents.py

2 lines

create_during_step/

TestCreateDuringStep.py

2 lines

exit_during_break/

TestExitDuringBreak.py

2 lines

exit_during_step/

TestExitDuringStep.py

2 lines

jump/

TestThreadJump.py

2 lines

multi_break/

TestMultipleBreakpoints.py

2 lines

state/

TestThreadStates.py

10 lines

step_out/

TestThreadStepOut.py

2 lines

thread_exit/

TestThreadExit.py

2 lines

type_completion/

TestTypeCompletion.py

2 lines

value_md5_crash/

TestValueMD5Crash.py

2 lines

watchpoint/

hello_watchlocation/

TestWatchLocation.py

2 lines

hello_watchpoint/

TestMyFirstWatchpoint.py

2 lines

multiple_threads/

TestWatchpointMultipleThreads.py

4 lines

variable_out_of_scope/

TestWatchedVarHitWhenInScope.py

2 lines

watchpoint_commands/

TestWatchpointCommands.py

16 lines

command/

TestWatchpointCommandLLDB.py

4 lines

TestWatchpointCommandPython.py

2 lines

condition/

TestWatchpointConditionCmd.py

2 lines

watchpoint_set_command/

TestWatchLocationWithWatchSet.py

2 lines

TestWatchpointSetErrorCases.py

2 lines

lang/

array_types/

TestArrayTypes.py

2 lines

bitfields/

TestBitfields.py

2 lines

blocks/

TestBlocks.py

4 lines

const_variables/

TestConstVariables.py

2 lines

enum_types/

TestEnumTypes.py

2 lines

forward/

TestForwardDeclaration.py

2 lines

function_types/

TestFunctionTypes.py

2 lines

modules/

TestCModules.py

2 lines

register_variables/

TestRegisterVariables.py

2 lines

set_values/

TestSetValues.py

2 lines

stepping/

TestThreadStepping.py

2 lines

strings/

TestCStrings.py

2 lines

tls_globals/

TestTlsGlobals.py

4 lines

cpp/

bool/

TestCPPBool.py

2 lines

call-function/

TestCallCPPFunction.py

2 lines

class_static/

TestStaticVariables.py

2 lines

class_types/

TestClassTypes.py

4 lines

TestClassTypesDisassembly.py

2 lines

enum_types/

TestCPP11EnumTypes.py

2 lines

namespace/

TestNamespace.py

4 lines

overloaded-functions/

TestOverloadedFunctions.py

2 lines

rvalue-references/

TestRvalueReferences.py

2 lines

static_members/

TestCPPStaticMembers.py

2 lines

static_methods/

TestCPPStaticMethods.py

2 lines

stl/

TestSTL.py

2 lines

TestStdCXXDisassembly.py

2 lines

this/

TestCPPThis.py

2 lines

unique-types/

TestUniqueTypes.py

2 lines

unsigned_types/

TestUnsignedTypes.py

2 lines

objc/

foundation/

TestConstStrings.py

2 lines

TestFoundationDisassembly.py

2 lines

TestObjCMethods.py

6 lines

TestObjCMethods2.py

12 lines

TestRuntimeTypes.py

2 lines

hidden-ivars/

TestHiddenIvars.py

2 lines

modules-auto-import/

TestModulesAutoImport.py

2 lines

modules-incomplete/

TestIncompleteModules.py

2 lines

modules-inline-functions/

TestModulesInlineFunctions.py

2 lines

modules/

TestObjCModules.py

2 lines

objc++/

TestObjCXX.py

2 lines

objc-dyn-sbtype/

TestObjCDynamicSBType.py

2 lines

objc-new-syntax/

TestObjCNewSyntax.py

2 lines

objc-optimized/

TestObjcOptimized.py

2 lines

radar-9691614/

TestObjCMethodReturningBOOL.py

2 lines

rdar-10967107/

TestRdar10967107.py

2 lines

rdar-11355592/

TestRdar11355592.py

2 lines

rdar-12408181/

TestRdar12408181.py

2 lines

real-definition/

TestRealDefinition.py

8 lines

self/

TestObjCSelf.py

2 lines

linux/

builtin_trap/

TestBuiltinTrap.py

4 lines

lldbtest.py

22 lines

macosx/

universal/

TestUniversal.py

4 lines

python_api/

formatters/

TestFormattersSBAPI.py

4 lines

rdar-12481949/

Test-rdar-12481949.py

2 lines

sbdata/

TestSBData.py

2 lines

sbvalue_persist/

TestSBValuePersist.py

2 lines

value_var_update/

TestValueVarUpdate.py

2 lines

settings/

TestSettings.py

6 lines

source-manager/

TestSourceManager.py

2 lines

types/

AbstractBase.py

4 lines

TestRecursiveTypes.py

6 lines

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[TestBase.runCmd] Better error message when runCmd fails.ClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 26354

test/api/check_public_api_headers/TestPublicAPIHeaders.py

test/benchmarks/continue/TestBenchmarkContinue.py

test/expression_command/call-function/TestCallStdStringFunction.py

test/expression_command/call-function/TestCallStopAndContinue.py

test/expression_command/formatters/TestFormatters.py

test/expression_command/persist_objc_pointeetype/TestPersistObjCPointeeType.py

test/expression_command/persistent_ptr_update/TestPersistentPtrUpdate.py

test/expression_command/persistent_types/TestPersistentTypes.py

test/expression_command/persistent_variables/TestPersistentVariables.py

test/expression_command/po_verbosity/TestPoVerbosity.py

test/expression_command/radar_8638051/Test8638051.py

test/expression_command/radar_9531204/TestPrintfAfterUp.py

test/expression_command/radar_9673664/TestExprHelpExamples.py

test/expression_command/test/TestExprs.py

test/expression_command/test/TestExprs2.py

test/expression_command/two-files/TestObjCTypeQueryFromOtherCompileUnit.py

test/functionalities/archives/TestBSDArchives.py

test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py

test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py

test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py

test/functionalities/breakpoint/breakpoint_ignore_count/TestBreakpointIgnoreCount.py

test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py

test/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py

test/functionalities/breakpoint/dummy_target_breakpoints/TestBreakpointsWithNoTargets.py

test/functionalities/breakpoint/inlined_breakpoints/TestInlinedBreakpoints.py

test/functionalities/conditional_break/TestConditionalBreak.py

test/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py

test/functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py

test/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py

test/functionalities/data-formatter/data-formatter-disabling/TestDataFormatterDisabling.py

test/functionalities/data-formatter/data-formatter-enum-format/TestDataFormatterEnumFormat.py

test/functionalities/data-formatter/data-formatter-named-summaries/TestDataFormatterNamedSummaries.py

test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py

test/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py

test/functionalities/data-formatter/data-formatter-script/TestDataFormatterScript.py

test/functionalities/data-formatter/data-formatter-skip-summary/TestDataFormatterSkipSummary.py

test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/list/TestDataFormatterLibcxxList.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/multimap/TestDataFormatterLibccMultiMap.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/multiset/TestDataFormatterLibcxxMultiSet.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/TestDataFormatterUnordered.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/TestDataFormatterLibcxxVBool.py

test/functionalities/data-formatter/data-formatter-stl/libcxx/vector/TestDataFormatterLibcxxVector.py

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/TestDataFormatterStdIterator.py

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/TestDataFormatterStdList.py

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/TestDataFormatterStdString.py

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vbool/TestDataFormatterStdVBool.py

test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/TestDataFormatterStdVector.py

test/functionalities/data-formatter/data-formatter-synth/TestDataFormatterSynth.py

test/functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py

test/functionalities/data-formatter/format-propagation/TestFormatPropagation.py

test/functionalities/data-formatter/frameformat_smallstruct/TestFrameFormatSmallStruct.py

test/functionalities/data-formatter/ptr_ref_typedef/TestPtrRef2Typedef.py

test/functionalities/data-formatter/rdar-10449092/Test-rdar-10449092.py

test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py

test/functionalities/data-formatter/rdar-10887661/TestRdar10887661.py

test/functionalities/data-formatter/rdar-11086338/TestRdar11086338.py

test/functionalities/data-formatter/rdar-11628688/TestFormattersBoolRefPtr.py

test/functionalities/data-formatter/rdar-11773899/TestFormattersBoolRefPtr.py

test/functionalities/data-formatter/rdar-11988289/TestRdar 11988289.py

test/functionalities/data-formatter/rdar-12437442/TestRdar12437442.py

test/functionalities/data-formatter/rdar-12529957/TestRdar12529957.py

test/functionalities/data-formatter/rdar-13338477/Test-rdar-13338477.py

test/functionalities/data-formatter/rdar-3534688/TestFormattersOneIsSingular.py

test/functionalities/data-formatter/rdar-9973865/Test-rdar-9973865.py

test/functionalities/data-formatter/rdar-9973992/Test-rdar-9973992.py

[TestBase.runCmd] Better error message when runCmd fails.
ClosedPublic
Actions

Revision Contents
Changeset List