This is an archive of the discontinued LLVM Phabricator instance.

Differential D99420

[NFC][OCaml] Resolve a couple more compilation warnings
ClosedPublic

Authored by jberdine on Mar 26 2021, 9:27 AM.

Details

Reviewers
whitequark
vaivaswatha
Commits
rGd50fe9f0d6b9: [NFC][OCaml] Resolve a couple more compilation warnings
Summary

Followup to: 0b1dc49ca38a [NFC][OCaml] Resolve const and unsigned compilation warnings

Diff Detail

Event Timeline

jberdine created this revision.Mar 26 2021, 9:27 AM
Herald added a reviewer: whitequark. · View Herald TranscriptMar 26 2021, 9:27 AM
jberdine requested review of this revision.Mar 26 2021, 9:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 9:27 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jberdine added a reviewer: vaivaswatha.Mar 26 2021, 9:28 AM
vaivaswatha accepted this revision.Mar 26 2021, 9:36 AM
This revision is now accepted and ready to land.Mar 26 2021, 9:36 AM
Harbormaster completed remote builds in B95883: Diff 333567.Mar 26 2021, 9:58 AM
This revision was landed with ongoing or failed builds.Mar 26 2021, 1:58 PM
Closed by commit rGd50fe9f0d6b9: [NFC][OCaml] Resolve a couple more compilation warnings (authored by jberdine). · Explain Why
This revision was automatically updated to reflect the committed changes.
jberdine added a commit: rGd50fe9f0d6b9: [NFC][OCaml] Resolve a couple more compilation warnings.

Revision Contents

PathSize
llvm/
bindings/
ocaml/
llvm/
2 lines
target/
4 lines

Diff 333627

llvm/bindings/ocaml/llvm/llvm_ocaml.c

Show First 20 Lines • Show All 879 Lines • ▼ Show 20 Lines
/* llcontext -> llvalue */ /* llcontext -> llvalue */
CAMLprim LLVMValueRef llvm_mdnull(LLVMContextRef C) { CAMLprim LLVMValueRef llvm_mdnull(LLVMContextRef C) {
return NULL; return NULL;
} }
/* llvalue -> string option */ /* llvalue -> string option */
CAMLprim value llvm_get_mdstring(LLVMValueRef V) { CAMLprim value llvm_get_mdstring(LLVMValueRef V) {
size_t Len; unsigned Len;
const char *CStr = LLVMGetMDString(V, &Len); const char *CStr = LLVMGetMDString(V, &Len);
return cstr_to_string_option(CStr, Len); return cstr_to_string_option(CStr, Len);
} }
CAMLprim value llvm_get_mdnode_operands(LLVMValueRef V) { CAMLprim value llvm_get_mdnode_operands(LLVMValueRef V) {
CAMLparam0(); CAMLparam0();
CAMLlocal1(Operands); CAMLlocal1(Operands);
unsigned int n; unsigned int n;
▲ Show 20 Lines • Show All 1,735 Lines • Show Last 20 Lines

llvm/bindings/ocaml/target/target_ocaml.c

Show First 20 Lines • Show All 308 Lines • ▼ Show 20 Lines
} }
/* Llvm.llmodule -> CodeGenFileType.t -> string -> TargetMachine.t -> unit */ /* Llvm.llmodule -> CodeGenFileType.t -> string -> TargetMachine.t -> unit */
CAMLprim value llvm_targetmachine_emit_to_file(LLVMModuleRef Module, CAMLprim value llvm_targetmachine_emit_to_file(LLVMModuleRef Module,
value FileType, value FileName, value Machine) { value FileType, value FileName, value Machine) {
char *ErrorMessage; char *ErrorMessage;
if(LLVMTargetMachineEmitToFile(TargetMachine_val(Machine), Module, if(LLVMTargetMachineEmitToFile(TargetMachine_val(Machine), Module,
String_val(FileName), Int_val(FileType), (char *)String_val(FileName),
&ErrorMessage)) { Int_val(FileType), &ErrorMessage)) {
llvm_raise(*caml_named_value("Llvm_target.Error"), ErrorMessage); llvm_raise(*caml_named_value("Llvm_target.Error"), ErrorMessage);
} }
return Val_unit; return Val_unit;
} }
/* Llvm.llmodule -> CodeGenFileType.t -> TargetMachine.t -> /* Llvm.llmodule -> CodeGenFileType.t -> TargetMachine.t ->
Llvm.llmemorybuffer */ Llvm.llmemorybuffer */
Show All 21 Lines