This is an archive of the discontinued LLVM Phabricator instance.

Differential D98833

[compiler-rt] enable crt support on ppc32
AbandonedPublic

Authored by MaskRay on Mar 17 2021, 5:57 PM.

Details

Reviewers
nemanjai
daltenty
chmeee
joerg
pattop

Diff Detail

Event Timeline

pattop created this revision.Mar 17 2021, 5:57 PM
Herald added subscribers: s.egerton, shchenz, simoncook and 2 others. · View Herald TranscriptMar 17 2021, 5:57 PM
pattop requested review of this revision.Mar 17 2021, 5:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2021, 5:57 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B94366: Diff 331430.Mar 17 2021, 6:47 PM
nickdesaulniers added reviewers: nemanjai, daltenty.May 21 2021, 9:44 AM
nemanjai added a comment.May 26 2021, 4:15 AM

Can you please add a description for this review. Why this is needed, why only for PPC32 and not PPC64, who the intended users are, etc.

nemanjai added reviewers: chmeee, joerg.May 26 2021, 4:15 AM
pattop mentioned this in D98836: [compiler-rt][CMake] Support powerpcspe build.May 26 2021, 3:44 PM
pattop mentioned this in D98831: [compiler-rt][CMake] Support powerpc32 on Linux.May 26 2021, 4:04 PM

Hi nemanjai, not sure about PPC64. I needed this to put together a powerpcspe-linux toolchain.

MaskRay commandeered this revision.Nov 26 2021, 1:32 PM
MaskRay added a reviewer: pattop.
MaskRay added a subscriber: MaskRay.

b7611ad0b16769d3bf172e84fa9296158f8f1910 did the same thing.

Herald added a subscriber: luke957. · View Herald TranscriptNov 26 2021, 1:32 PM
MaskRay abandoned this revision.Nov 26 2021, 1:32 PM

Revision Contents

PathSize
compiler-rt/
cmake/
2 lines

Diff 331430

compiler-rt/cmake/config-ix.cmake

Show First 20 Lines • Show All 293 Lines • ▼ Show 20 Linesif(APPLE)
set(ARM32 armv7 armv7s armv7k) set(ARM32 armv7 armv7s armv7k)
set(X86_64 x86_64 x86_64h) set(X86_64 x86_64 x86_64h)
endif() endif()
set(ALL_SANITIZER_COMMON_SUPPORTED_ARCH ${X86} ${X86_64} ${PPC64} ${RISCV64} set(ALL_SANITIZER_COMMON_SUPPORTED_ARCH ${X86} ${X86_64} ${PPC64} ${RISCV64}
${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9}) ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9})
set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64} set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64}
${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9}) ${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9})
set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV32} ${RISCV64} ${VE}) set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC32} ${RISCV32} ${RISCV64} ${VE})
set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64}) set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64})
if(ANDROID) if(ANDROID)
set(OS_NAME "Android") set(OS_NAME "Android")
else() else()
set(OS_NAME "${CMAKE_SYSTEM_NAME}") set(OS_NAME "${CMAKE_SYSTEM_NAME}")
endif() endif()
▲ Show 20 Lines • Show All 496 Lines • Show Last 20 Lines