Index: libcxx/utils/ci/buildkite-pipeline.yml =================================================================== --- libcxx/utils/ci/buildkite-pipeline.yml +++ libcxx/utils/ci/buildkite-pipeline.yml @@ -318,9 +318,7 @@ limit: 2 - label: "Windows" - # TODO: The CI runner doesn't have bash in the path currently. Once it - # has that, remove the absolute path and just call 'bash' here. - command: "\"\\Program Files\\Git\\usr\\bin\\bash\" libcxx/utils/ci/run-buildbot generic-win" + command: "bash libcxx/utils/ci/run-buildbot generic-win" artifact_paths: - "**/test-results.xml" agents: Index: libcxx/utils/ci/run-buildbot =================================================================== --- libcxx/utils/ci/run-buildbot +++ libcxx/utils/ci/run-buildbot @@ -473,10 +473,6 @@ ;; generic-win) clean - # TODO: The CI runner doesn't have bash in the path currently, and it's - # needed for running tests. Once it's available out of the box, remove this. - export PATH="$PATH:/c/Program Files/Git/usr/bin" - # TODO: Clang-cl in MSVC configurations don't have access to compiler_rt # builtins helpers for int128 division. See # https://reviews.llvm.org/D91139#2429595 for a comment about longterm @@ -485,12 +481,6 @@ # when building tests) to allow enabling filesystem for running tests, # even if it uses a non-permanent ABI. - # TODO: The CI runner currently uses Clang 11, which doesn't implicitly - # link in oldnames.lib (which is needed for some tests) when compiling - # with the plain "clang" driver, as the tests do (as opposed to using - # the "clang-cl" driver for compiling). When the CI runner runs - # Clang 12, the "-loldnames" option can be dropped. - # TODO: Currently, building with the experimental library breaks running # tests (the test linking look for the c++experimental library with the # wrong name, and the statically linked c++experimental can't be linked @@ -509,8 +499,7 @@ -DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=NO \ -DLIBCXX_ENABLE_FILESYSTEM=YES \ -DCMAKE_CXX_FLAGS="-D_LIBCPP_HAS_NO_INT128" \ - -DLIBCXX_TEST_COMPILER_FLAGS="-D_LIBCPP_HAS_NO_INT128" \ - -DLIBCXX_TEST_LINKER_FLAGS="-loldnames" + -DLIBCXX_TEST_COMPILER_FLAGS="-D_LIBCPP_HAS_NO_INT128" echo "+++ Running the libc++ tests" ${NINJA} -vC "${BUILD_DIR}" check-cxx ;;