diff --git a/mlir/include/mlir/IR/TypeUtilities.h b/mlir/include/mlir/IR/TypeUtilities.h --- a/mlir/include/mlir/IR/TypeUtilities.h +++ b/mlir/include/mlir/IR/TypeUtilities.h @@ -59,6 +59,11 @@ /// each pair wise entries have compatible shape. LogicalResult verifyCompatibleShapes(TypeRange types1, TypeRange types2); +/// Returns success if all given types have compatible shapes. That is, they are +/// all scalars (not shaped), or they are all shaped types and any ranked shapes +/// have compatible dimensions. Dimensions are compatible if all non-dynamic +/// dims are equal. The element type does not matter. +LogicalResult verifyCompatibleShapes(TypeRange types); //===----------------------------------------------------------------------===// // Utility Iterators //===----------------------------------------------------------------------===// diff --git a/mlir/lib/IR/Operation.cpp b/mlir/lib/IR/Operation.cpp --- a/mlir/lib/IR/Operation.cpp +++ b/mlir/lib/IR/Operation.cpp @@ -834,11 +834,9 @@ if (failed(verifyAtLeastNOperands(op, 1))) return failure(); - auto type = op->getOperand(0).getType(); - for (auto opType : llvm::drop_begin(op->getOperandTypes(), 1)) { - if (failed(verifyCompatibleShape(opType, type))) - return op->emitOpError() << "requires the same shape for all operands"; - } + if (failed(verifyCompatibleShapes(op->getOperandTypes()))) + return op->emitOpError() << "requires the same shape for all operands"; + return success(); } @@ -847,17 +845,13 @@ failed(verifyAtLeastNResults(op, 1))) return failure(); - auto type = op->getOperand(0).getType(); - for (auto resultType : op->getResultTypes()) { - if (failed(verifyCompatibleShape(resultType, type))) - return op->emitOpError() - << "requires the same shape for all operands and results"; - } - for (auto opType : llvm::drop_begin(op->getOperandTypes(), 1)) { - if (failed(verifyCompatibleShape(opType, type))) - return op->emitOpError() - << "requires the same shape for all operands and results"; - } + SmallVector types(op->getOperandTypes()); + types.append(llvm::to_vector<4>(op->getResultTypes())); + + if (failed(verifyCompatibleShapes(types))) + return op->emitOpError() + << "requires the same shape for all operands and results"; + return success(); } diff --git a/mlir/lib/IR/TypeUtilities.cpp b/mlir/lib/IR/TypeUtilities.cpp --- a/mlir/lib/IR/TypeUtilities.cpp +++ b/mlir/lib/IR/TypeUtilities.cpp @@ -11,10 +11,12 @@ //===----------------------------------------------------------------------===// #include "mlir/IR/TypeUtilities.h" + #include "mlir/IR/Attributes.h" #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/Types.h" #include "mlir/IR/Value.h" +#include "llvm/ADT/STLExtras.h" using namespace mlir; @@ -114,3 +116,41 @@ Type ResultElementTypeIterator::unwrap(Value value) { return value.getType().cast().getElementType(); } +/// Returns success if all given types have compatible shapes. That is, they are +/// all scalars (not shaped), or they are all shaped types and any ranked shapes +/// have compatible dimensions. Dimensions are compatible if all non-dynamic +/// dims are equal. The element type does not matter. +LogicalResult mlir::verifyCompatibleShapes(TypeRange types) { + auto shapedTypes = llvm::to_vector<8>(llvm::map_range( + types, [](auto type) { return type.template dyn_cast(); })); + // Return failure if some, but not all are not shaped. Return early if none + // are shaped also. + if (llvm::none_of(shapedTypes, [](auto t) { return t; })) + return success(); + if (!llvm::all_of(shapedTypes, [](auto t) { return t; })) + return failure(); + + // Remove all unranked shapes + auto shapes = llvm::to_vector<8>(llvm::make_filter_range( + shapedTypes, [](auto shapedType) { return shapedType.hasRank(); })); + if (shapes.empty()) + return success(); + + // All ranks should be equal + auto firstRank = shapes.front().getRank(); + if (llvm::any_of(shapes, + [&](auto shape) { return firstRank != shape.getRank(); })) + return failure(); + + for (unsigned i = 0; i < firstRank; ++i) { + // Retrieve all ranked dimensions + auto staticDims = llvm::to_vector<8>(llvm::map_range( + llvm::make_filter_range( + shapes, [&](auto shape) { return !shape.isDynamicDim(i); }), + [&](auto shape) { return shape.getDimSize(i); })); + if (!staticDims.empty() && !llvm::is_splat(staticDims)) + return failure(); + } + + return success(); +} diff --git a/mlir/test/IR/traits.mlir b/mlir/test/IR/traits.mlir --- a/mlir/test/IR/traits.mlir +++ b/mlir/test/IR/traits.mlir @@ -347,7 +347,7 @@ func private @foo() "test.finish" () : () -> () }) : () -> () -func private @foo() +func private @foo() // -----