Page MenuHomePhabricator

[libcxx] Rework sized delete.
ClosedPublic

Authored by EricWF on May 18 2015, 11:49 AM.

Details

Summary

This patch does 2 main things:

  1. Enable sized delete if the feature test macro __cpp_sized_deallocation is enabled.
  2. Rework and cleanup all of the sized delete tests.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 25992.May 18 2015, 11:49 AM
EricWF retitled this revision from to [libcxx] Rework sized delete..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: Unknown Object (MLST).
EricWF updated this revision to Diff 26003.May 18 2015, 12:48 PM
EricWF edited the test plan for this revision. (Show Details)

I fixed the tests against GCC 5.1 which supports both -fsized-deallocation and sized deallocation in C++14.

mclow.lists edited edge metadata.May 18 2015, 1:07 PM

I think that the language specific files could be named sized_delete_array11 and sized_delete_array14 instead of using the ++ in the file names.

Other than that (and the inline nit), these look good to me.

test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array_calls_unsized_delete_array.pass.cpp
55

Humor my OCD, please.
Make these match all the others:
1 == delete_called and 0 == delete_nothrow_called

EricWF updated this revision to Diff 26004.May 18 2015, 1:13 PM
EricWF edited the test plan for this revision. (Show Details)
EricWF edited edge metadata.

Address mclows comments.

mclow.lists accepted this revision.May 18 2015, 2:55 PM
mclow.lists edited edge metadata.

LGTM.

This revision is now accepted and ready to land.May 18 2015, 2:55 PM
EricWF closed this revision.May 18 2015, 7:07 PM