Page MenuHomePhabricator

Use ADB pull to download modules from android target.
ClosedPublic

Authored by ovyalov on May 17 2015, 6:50 PM.

Details

Summary

Use ADB pull to download modules from a target if remote-android platform is used.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 25939.May 17 2015, 6:50 PM
ovyalov retitled this revision from to Use ADB pull to download modules from android target..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added reviewers: tberghammer, chaoren.
ovyalov added a subscriber: Unknown Object (MLST).
tberghammer accepted this revision.May 18 2015, 12:24 PM
tberghammer edited edge metadata.

Looks good but if possible then please check that it works with Windows -> Android to verify the path separator handling.

source/Plugins/Platform/Android/AdbClient.cpp
345–348

(nit) indentation

359

(nit) static_cast is enough

This revision is now accepted and ready to land.May 18 2015, 12:24 PM

Verified on Windows - works fine.

source/Plugins/Platform/Android/AdbClient.cpp
345–348

Fixed.

359

Done.

ovyalov updated this revision to Diff 26014.May 18 2015, 2:12 PM
ovyalov edited edge metadata.

Reviews fixes.

ovyalov closed this revision.May 18 2015, 4:48 PM

AFFECTED FILES

/lldb/trunk/include/lldb/Target/Platform.h
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.h

USERS

ovyalov (Author)

http://reviews.llvm.org/rL237640