This is an archive of the discontinued LLVM Phabricator instance.

Add Flang builder for latest llvm and libc++.
ClosedPublic

Authored by stevanradakovic on Mar 1 2021, 6:59 AM.

Diff Detail

Event Timeline

stevanradakovic created this revision.Mar 1 2021, 6:59 AM
stevanradakovic requested review of this revision.Mar 1 2021, 6:59 AM
gkistanova accepted this revision.Mar 2 2021, 7:45 PM

Looks good with a couple nit picks.
Please see my comments in line.

buildbot/osuosl/master/config/builders.py
1517

Having a particular version of clang in the builder name looks too restrictive for future changes. You might want to change that to 12 in 6 months or so.

1534

How about using variants or specify a link to a particular clang version, so you could update the clang on the worker without changing the builders.py when you will want to use more recent version in the future?

This revision is now accepted and ready to land.Mar 2 2021, 7:45 PM

Change clang version to 10 since that one is the newest one
available for bionic (which we use for workers).

Update clang and builder version to a generic name.

Update clang and builder version to generic name.

stevanradakovic marked an inline comment as done.Mar 3 2021, 1:11 AM

Thanks for the review @gkistanova !

buildbot/osuosl/master/config/builders.py
1534

How does this look? My plan is on the worker side to have this point to the latest version of clang.

@stevanradakovic , thank you for adding this!

buildbot/osuosl/master/config/builders.py
1516

I think that adding aarch64 here (and perhaps release) would help navigating http://lab.llvm.org:8011/.

1533

IIUC, Release is the default, see here. Personally I prefer being explicit, so this is just as an FYI :)

Update clang and builder version to generic name.

Add additional tags for builder.

stevanradakovic marked 2 inline comments as done.Mar 4 2021, 3:35 AM

@awarzynski you're welcome. Is it ok to merge now?

This revision was automatically updated to reflect the committed changes.