This is an archive of the discontinued LLVM Phabricator instance.

Add Flang builder for latest gcc.
ClosedPublic

Authored by stevanradakovic on Mar 1 2021, 4:12 AM.

Diff Detail

Event Timeline

stevanradakovic created this revision.Mar 1 2021, 4:12 AM
stevanradakovic requested review of this revision.Mar 1 2021, 4:12 AM
gkistanova accepted this revision.Mar 2 2021, 7:48 PM

Looks good with a couple of nit picks.
Please see my comments in line.

buildbot/osuosl/master/config/builders.py
1548

Having a particular version of gcc in the builder name looks too restrictive for future changes. Why not have it as linaro-aarch64-flang-gcc? Looks descriptive enough, unless you plan to have multiple builders for different versions of gcc running simultaneously.

1555

How about using variants or specify a link to a particular gcc version, so you could update the compiler/toolchain on the worker without changing the builders.py when you will want to use more recent version in the future?

This revision is now accepted and ready to land.Mar 2 2021, 7:48 PM

Update generic name for builder and for gcc binary.

Thanks for the review @gkistanova !

Thank you for adding this @stevanradakovic !

buildbot/osuosl/master/config/builders.py
1547

Would it be OK to have more tags here? E.g. aarch64 and release?

Add additional tags for builder.

Add check-flang to latest gcc build.

@awarzynski nice suggestion. Is it ok to merge now?

This revision was automatically updated to reflect the committed changes.