Details
Diff Detail
- Repository
- rZORG LLVM Github Zorg
Event Timeline
Looks good with a couple of nit picks.
Please see my comments in line.
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
1548 | Having a particular version of gcc in the builder name looks too restrictive for future changes. Why not have it as linaro-aarch64-flang-gcc? Looks descriptive enough, unless you plan to have multiple builders for different versions of gcc running simultaneously. | |
1555 | How about using variants or specify a link to a particular gcc version, so you could update the compiler/toolchain on the worker without changing the builders.py when you will want to use more recent version in the future? |
Thank you for adding this @stevanradakovic !
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
1547 | Would it be OK to have more tags here? E.g. aarch64 and release? |
Would it be OK to have more tags here? E.g. aarch64 and release?