diff --git a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp --- a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp @@ -2289,6 +2289,25 @@ unsigned VWidth = cast(SVI.getType())->getNumElements(); unsigned LHSWidth = cast(LHS->getType())->getNumElements(); + + // shuffle (bitcast X), (bitcast Y), Mask --> bitcast (shuffle X, Y, Mask) + // + // if X and Y are of the same (vector) type, and the element size is not + // changed by the bitcasts, we can distribute the bitcasts through the + // shuffle, hopefully reducing the number of instructions. We make sure that + // at least one bitcast only has one use, so we don't *increase* the number of + // instructions here. + Value *X, *Y; + if (match(LHS, m_BitCast(m_Value(X))) && match(RHS, m_BitCast(m_Value(Y))) && + X->getType()->isVectorTy() && X->getType() == Y->getType() && + X->getType()->getScalarSizeInBits() == + SVI.getType()->getScalarSizeInBits() && + (LHS->hasOneUse() || RHS->hasOneUse())) { + Value *V = Builder.CreateShuffleVector(X, Y, SVI.getShuffleMask(), + SVI.getName() + ".uncasted"); + return new BitCastInst(V, SVI.getType()); + } + ArrayRef Mask = SVI.getShuffleMask(); Type *Int32Ty = Type::getInt32Ty(SVI.getContext()); @@ -2298,7 +2317,6 @@ // TODO: This could be extended to allow length-changing shuffles. // The transform might also be obsoleted if we allowed canonicalization // of bitcasted shuffles. - Value *X; if (match(LHS, m_BitCast(m_Value(X))) && match(RHS, m_Undef()) && X->getType()->isVectorTy() && VWidth == LHSWidth) { // Try to create a scaled mask constant. diff --git a/llvm/test/Transforms/InstCombine/shuffle-cast-dist.ll b/llvm/test/Transforms/InstCombine/shuffle-cast-dist.ll --- a/llvm/test/Transforms/InstCombine/shuffle-cast-dist.ll +++ b/llvm/test/Transforms/InstCombine/shuffle-cast-dist.ll @@ -5,11 +5,9 @@ ; CHECK-LABEL: @vtrn1( ; CHECK-NEXT: entry: ; CHECK-NEXT: [[TMP0:%.*]] = insertelement <2 x i32> undef, i32 [[I:%.*]], i64 0 -; CHECK-NEXT: [[TMP1:%.*]] = bitcast <2 x i32> [[TMP0]] to <2 x float> -; CHECK-NEXT: [[TMP2:%.*]] = bitcast <2 x i32> [[TMP0]] to <2 x float> -; CHECK-NEXT: [[TMP3:%.*]] = shufflevector <2 x float> [[TMP1]], <2 x float> [[TMP2]], <2 x i32> -; CHECK-NEXT: [[TMP4:%.*]] = bitcast [8 x i8]* [[RESULT:%.*]] to <2 x float>* -; CHECK-NEXT: store <2 x float> [[TMP3]], <2 x float>* [[TMP4]], align 1 +; CHECK-NEXT: [[TMP1:%.*]] = shufflevector <2 x i32> [[TMP0]], <2 x i32> undef, <2 x i32> zeroinitializer +; CHECK-NEXT: [[TMP2:%.*]] = bitcast [8 x i8]* [[RESULT:%.*]] to <2 x i32>* +; CHECK-NEXT: store <2 x i32> [[TMP1]], <2 x i32>* [[TMP2]], align 1 ; CHECK-NEXT: ret void ; { @@ -26,13 +24,10 @@ define void @vtrn2([8 x i8]* nocapture %result, i32 %i, i32 %j, i32 %k) { ; CHECK-LABEL: @vtrn2( ; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = insertelement <2 x i32> poison, i32 [[J:%.*]], i64 1 -; CHECK-NEXT: [[TMP1:%.*]] = insertelement <2 x i32> poison, i32 [[K:%.*]], i64 1 -; CHECK-NEXT: [[TMP2:%.*]] = bitcast <2 x i32> [[TMP0]] to <2 x float> -; CHECK-NEXT: [[TMP3:%.*]] = bitcast <2 x i32> [[TMP1]] to <2 x float> -; CHECK-NEXT: [[TMP4:%.*]] = shufflevector <2 x float> [[TMP2]], <2 x float> [[TMP3]], <2 x i32> -; CHECK-NEXT: [[TMP5:%.*]] = bitcast [8 x i8]* [[RESULT:%.*]] to <2 x float>* -; CHECK-NEXT: store <2 x float> [[TMP4]], <2 x float>* [[TMP5]], align 1 +; CHECK-NEXT: [[TMP0:%.*]] = insertelement <2 x i32> poison, i32 [[K:%.*]], i64 1 +; CHECK-NEXT: [[TMP1:%.*]] = insertelement <2 x i32> [[TMP0]], i32 [[J:%.*]], i64 0 +; CHECK-NEXT: [[TMP2:%.*]] = bitcast [8 x i8]* [[RESULT:%.*]] to <2 x i32>* +; CHECK-NEXT: store <2 x i32> [[TMP1]], <2 x i32>* [[TMP2]], align 1 ; CHECK-NEXT: ret void ; entry: @@ -49,9 +44,8 @@ define <4 x float> @bc_shuf_lenchange(<2 x i32> %x, <2 x i32> %y) { ; CHECK-LABEL: @bc_shuf_lenchange( -; CHECK-NEXT: [[XB:%.*]] = bitcast <2 x i32> [[X:%.*]] to <2 x float> -; CHECK-NEXT: [[YB:%.*]] = bitcast <2 x i32> [[Y:%.*]] to <2 x float> -; CHECK-NEXT: [[R:%.*]] = shufflevector <2 x float> [[XB]], <2 x float> [[YB]], <4 x i32> +; CHECK-NEXT: [[TMP1:%.*]] = shufflevector <2 x i32> [[X:%.*]], <2 x i32> [[Y:%.*]], <4 x i32> +; CHECK-NEXT: [[R:%.*]] = bitcast <4 x i32> [[TMP1]] to <4 x float> ; CHECK-NEXT: ret <4 x float> [[R]] ; %xb = bitcast <2 x i32> %x to <2 x float>