Page MenuHomePhabricator

[lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code
ClosedPublic

Authored by teemperor on Feb 23 2021, 6:56 AM.

Details

Summary

ValueObject.h contains the ValueObject::ValueObjectManager type which is just a typedef
for the ClusterManager that takes care of the whole ValueObject memory management. However,
there is also ValueObjectManager defined in the same header which is only used in the curses UI
implementation and consists mostly of dead and completely untested code.

This code been around since a while (it was added in 2016 as 8369b28da0750129ababae357bea98940800a0e0),
so I think we shouldn't just revert the whole patch.

Instead this patch just moves the class to its own header that it isn't just hiding in the ValueObject
header and renames it to ValueObjectUpdater that it at least has a unique name (which I hope also slightly
better reflects the purpose of this class). I also deleted all the dead code branches and functions.

Diff Detail

Event Timeline

teemperor created this revision.Feb 23 2021, 6:56 AM
teemperor requested review of this revision.Feb 23 2021, 6:56 AM
mib accepted this revision.Feb 23 2021, 7:12 AM
mib added a subscriber: mib.

LGTM

This revision is now accepted and ready to land.Feb 23 2021, 7:12 AM