[AArch64] [ASAN] Enabling ASAN for AArch64 Architecture

[rengolin]

Hi Kumar,

This seems to be the patch that was flying around to enable ASAN on AArch64. Which board have you tested it? We need it to work at least on a Juno, which is where our buildbot runs.

cheers,
--renato

[sdkie]

In D9701#171021, @rengolin wrote:

Hi Kumar,

This seems to be the patch that was flying around to enable ASAN on AArch64. Which board have you tested it? We need it to work at least on a Juno, which is where our buildbot runs.

cheers,
--renato

I have tested it on HiKey board.

[rengolin]

Right, HiKey is still non-standard, but it's good to know that this is working there, too.

@enefaim

Gabor, can you run this on your Juno, just to make sure we're not missing anything (again)?

Thanks!
-renato

[sdkie]

@enefaim: Did you got time to test ASAN on Juno?

[enefaim]

Hi Kumar, Renato,

Sorry guys, I didn't get any notification about this diff.
I'm going to set the Juno up for testing this change tomorrow.

Best regards,
Gabor Ballabas

[enefaim]

Hi guys,

I tested the patch on our Juno board, and we still have issues.
These tests are stuck in an infinite loop since Friday, when I started the test-runner:

• stage1/projects/compiler-rt/test/asan/AARCH64LinuxConfig/TestCases/Linux/Output/quarantine_size_mb.cc.tmp
• stage1/projects/compiler-rt/test/sanitizer_common/asan-aarch64-Linux/Linux/Output/hard_rss_limit_mb_test.cc.tmp
• stage1/projects/compiler-rt/test/asan/AARCH64LinuxConfig/TestCases/Output/current_allocated_bytes.cc.tmp
• stage1/projects/compiler-rt/lib/asan/tests/default/Asan-aarch64-with-calls-Test --gtest_filter=AddressSanitizer.ManyThreadsTest

Best regards,
Gabor Ballabas

cmake/config-ix.cmake

filter_available_targets(SANITIZER_COMMON_SUPPORTED_ARCH
   x86_64 i386 i686 powerpc64 powerpc64le arm aarch64 mips mips64 mipsel mips64el)
 # LSan and UBSan common files should be available on all architectures supported
 # by other sanitizers (even if they build into dummy object files).
 filter_available_targets(LSAN_COMMON_SUPPORTED_ARCH
   ${SANITIZER_COMMON_SUPPORTED_ARCH})
 filter_available_targets(UBSAN_COMMON_SUPPORTED_ARCH
   ${SANITIZER_COMMON_SUPPORTED_ARCH})
 filter_available_targets(ASAN_SUPPORTED_ARCH
-  x86_64 i386 i686 powerpc64 powerpc64le arm mips mipsel mips64 mips64el)
+  x86_64 i386 i686 powerpc64 powerpc64le arm aarch64 mips mipsel mips64 mips64el)
 filter_available_targets(DFSAN_SUPPORTED_ARCH x86_64 mips64 mips64el)
 filter_available_targets(LSAN_SUPPORTED_ARCH x86_64 mips64 mips64el)
 filter_available_targets(MSAN_SUPPORTED_ARCH x86_64 mips64 mips64el)
 filter_available_targets(PROFILE_SUPPORTED_ARCH x86_64 i386 i686 arm mips mips64
   mipsel mips64el aarch64 powerpc64 powerpc64le)
 filter_available_targets(TSAN_SUPPORTED_ARCH x86_64 mips64 mips64el)
 filter_available_targets(UBSAN_SUPPORTED_ARCH x86_64 i386 i686 arm aarch64 mips
   mipsel mips64 mips64el powerpc64 powerpc64le)

lib/asan/asan_mapping.h

 // Default Windows/i386 mapping:
 // (the exact location of HighShadow/HighMem may vary depending
 //  on WoW64, /LARGEADDRESSAWARE, etc).
 // || `[0x50000000, 0xffffffff]` || HighMem    ||
 // || `[0x3a000000, 0x4fffffff]` || HighShadow ||
 // || `[0x36000000, 0x39ffffff]` || ShadowGap  ||
 // || `[0x30000000, 0x35ffffff]` || LowShadow  ||
 // || `[0x00000000, 0x2fffffff]` || LowMem     ||
+//
+// Default Linux/AArch64 mapping:
+// || `[0x2000000000, 0x7fffffffff]` || HighMem    ||
+// || `[0x1400000000, 0x1fffffffff]` || HighShadow ||
+// || `[0x1200000000, 0x13ffffffff]` || ShadowGap  ||
+// || `[0x1000000000, 0x11ffffffff]` || LowShadow  ||
+// || `[0x0000000000, 0x0fffffffff]` || LowMem     ||
 
 static const u64 kDefaultShadowScale = 3;
 static const u64 kDefaultShadowOffset32 = 1ULL << 29;  // 0x20000000
 static const u64 kIosShadowOffset32 = 1ULL << 30;  // 0x40000000
 static const u64 kDefaultShadowOffset64 = 1ULL << 44;
 static const u64 kDefaultShort64bitShadowOffset = 0x7FFF8000;  // < 2G.
 static const u64 kAArch64_ShadowOffset64 = 1ULL << 36;
 static const u64 kMIPS32_ShadowOffset32 = 0x0aaa0000;

lib/sanitizer_common/sanitizer_platform.h

 // Since we don't want to include libc headers here, we check the
 // target only.
 #if defined(__arm__) || SANITIZER_X32 || defined(__sparc__)
 #define SANITIZER_USES_UID16_SYSCALLS 1
 #else
 #define SANITIZER_USES_UID16_SYSCALLS 0
 #endif
 
-#ifdef __mips__
+#if defined(__mips__) || defined(__aarch64__)
 # define SANITIZER_POINTER_FORMAT_LENGTH FIRST_32_SECOND_64(8, 10)
 #else
 # define SANITIZER_POINTER_FORMAT_LENGTH FIRST_32_SECOND_64(8, 12)
 #endif
 
 // Assume obsolete RPC headers are available by default
 #if !defined(HAVE_RPC_XDR_H) && !defined(HAVE_TIRPC_RPC_XDR_H)
 # define HAVE_RPC_XDR_H (SANITIZER_LINUX && !SANITIZER_ANDROID)
 # define HAVE_TIRPC_RPC_XDR_H 0
 #endif
 
 #endif // SANITIZER_PLATFORM_H