libcxx: use early returns

[ldionne]

This looks correct, but I'm not sure what we gain from making this change?

libcxx/src/filesystem/operations.cpp

1065

I found it easier to understand when we unconditionally returned false at the end of the function TBH. Now, I have to go and figure out what ErrorHandler<bool>::report() returns when I'm just glancing at the function.

[joerg]

libcxx/src/filesystem/operations.cpp

1065

But you already have to know that for the two uses before in this function. Now it is at least consistent.

[ldionne]

LGTM. Please wait for CI to finish and ship it.

CI is successful when this is green:

libcxx/src/filesystem/operations.cpp

1065

Agreed.

libcxx/src/filesystem/operations.cpp

bool __create_directory(const path& p, error_code* ec) {
   return false;
 }
 
 bool __create_directory(path const& p, path const& attributes, error_code* ec) {
   ErrorHandler<bool> err("create_directory", ec, &p, &attributes);
 
   StatT attr_stat;
   error_code mec;
-  auto st = detail::posix_stat(attributes, attr_stat, &mec);
+  file_status st = detail::posix_stat(attributes, attr_stat, &mec);
   if (!status_known(st))
     return err.report(mec);
   if (!is_directory(st))
     return err.report(errc::not_a_directory,
                       "the specified attribute path is invalid");
 
   if (detail::mkdir(p.c_str(), attr_stat.st_mode) == 0)
     return true;
 
-  if (errno == EEXIST) {
-    error_code mec = capture_errno();
-    error_code ignored_ec;
-    const file_status st = status(p, ignored_ec);
-    if (!is_directory(st)) {
-      err.report(mec);
-    }
-  } else {
-    err.report(capture_errno());
-  }
+  if (errno != EEXIST)
+    return err.report(capture_errno());
+
+  mec = capture_errno();
+  st = status(p, ignored_ec);
+  if (!is_directory(st))
+    return err.report(mec);
   return false;
 }
 
 void __create_directory_symlink(path const& from, path const& to,
                                 error_code* ec) {
   ErrorHandler<void> err("create_directory_symlink", ec, &from, &to);
   if (detail::symlink_dir(from.c_str(), to.c_str()) == -1)
     return err.report(capture_errno());