MIPS calls it FCSR, FreeBSD's regnum.h calls it FSR. I don't know which is the right thing to use, but just thought I should point it out if you hadn't noticed.
These diffs should be separated from this commit IMO.
This and DEFINE_GPR_INFO should not be defined like this on FreeBSD (or at all?).
Should these not live in the respective RegisterContext<OS>_mips64.cpp?
Hm.... I'm very tempted to delete the linux mips implementation -- it uses several techniques which are getting in the way of this patch (and also some others in the past), for a lot of those, we now have different/better ways of doing it. On top of that, it's completely unmaintained (last non-nfc change to the file was in 2017, and the author (@nitesh.jain) does not appear to be active anymore.
I'm sorry for not replying earlier.
I have noticed. Others part of LLDB (and LLVM) call it FCSR, so I've figured out it's better to be consistent with that.
Do you mean reformatting? I suppose I can commit the result of clang-format earlier. Figured the changes are trivial enough.
I suppose we could make them conditional too but I'm not sure if this wouldn't just add complexity for no real change.
I really don't know. I've followed suit with the other macros already here.