Page MenuHomePhabricator

[lldb] Add step target to ThreadPlanStepInRange constructor
ClosedPublic

Authored by kastiglione on Feb 11 2021, 1:05 PM.

Details

Summary

QueueThreadPlanForStepInRange accepts a step_into_target, but the constructor for
ThreadPlanStepInRange does not. Instead, a caller would optionally call SetStepInTarget().

This change adds step_into_target as a constructor argument. This simplifies
construction of ThreadPlanSP, by avoiding a subsequent downcast and conditional
assignment. This constructor is already used in downstream repos.

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 11 2021, 1:05 PM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 1:05 PM

Improved wording in summary

kastiglione edited the summary of this revision. (Show Details)Feb 11 2021, 1:24 PM
jingham accepted this revision.Feb 11 2021, 2:24 PM

I must have thought there would be a case where you wouldn't be able to figure out the target right when you made the plan, but since that possibility never arose, this simplification is fine.

This revision is now accepted and ready to land.Feb 11 2021, 2:24 PM
This revision was landed with ongoing or failed builds.Feb 11 2021, 2:57 PM
This revision was automatically updated to reflect the committed changes.