diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp --- a/clang/lib/AST/ASTContext.cpp +++ b/clang/lib/AST/ASTContext.cpp @@ -1445,7 +1445,7 @@ ObjCSuperType = QualType(); // void * type - if (LangOpts.OpenCLVersion >= 200) { + if (LangOpts.OpenCLGenericAddressSpace) { auto Q = VoidTy.getQualifiers(); Q.setAddressSpace(LangAS::opencl_generic); VoidPtrTy = getPointerType(getCanonicalType( diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -15261,11 +15261,13 @@ return false; } -static QualType -RemoveAddressSpaceFromPtr(Sema &SemaRef, const PointerType *PtrTy) { - QualType QTy = PtrTy->getPointeeType(); - QTy = SemaRef.Context.removeAddrSpaceQualType(QTy); - return SemaRef.Context.getPointerType(QTy); +static CanQualType RemoveAddressSpaceFromPtr(Sema &SemaRef, + const PointerType *PtrTy) { + auto &Ctx = SemaRef.Context; + Qualifiers PtrQuals = PtrTy->getPointeeType().getQualifiers(); + PtrQuals.removeAddressSpace(); + return Ctx.getPointerType(Ctx.getCanonicalType(Ctx.getQualifiedType( + PtrTy->getPointeeType().getUnqualifiedType(), PtrQuals))); } static inline bool @@ -15277,11 +15279,14 @@ QualType ResultType = FnDecl->getType()->castAs()->getReturnType(); - // The operator is valid on any address space for OpenCL. if (SemaRef.getLangOpts().OpenCLCPlusPlus) { - if (auto *PtrTy = ResultType->getAs()) { + // The operator is valid on any address space for OpenCL. + // Drop address space from actual and expected result types. + if (const auto *PtrTy = ResultType->getAs()) ResultType = RemoveAddressSpaceFromPtr(SemaRef, PtrTy); - } + + if (auto ExpectedPtrTy = ExpectedResultType->getAs()) + ExpectedResultType = RemoveAddressSpaceFromPtr(SemaRef, ExpectedPtrTy); } // Check that the result type is what we expect. @@ -15311,10 +15316,14 @@ QualType FirstParamType = FnDecl->getParamDecl(0)->getType(); if (SemaRef.getLangOpts().OpenCLCPlusPlus) { // The operator is valid on any address space for OpenCL. - if (auto *PtrTy = - FnDecl->getParamDecl(0)->getType()->getAs()) { + // Drop address space from actual and expected first parameter types. + if (const auto *PtrTy = + FnDecl->getParamDecl(0)->getType()->getAs()) FirstParamType = RemoveAddressSpaceFromPtr(SemaRef, PtrTy); - } + + if (auto ExpectedPtrTy = ExpectedFirstParamType->getAs()) + ExpectedFirstParamType = + RemoveAddressSpaceFromPtr(SemaRef, ExpectedPtrTy); } // Check that the first parameter type is what we expect. diff --git a/clang/test/CodeGenOpenCLCXX/addrspace-new-delete.cl b/clang/test/CodeGenOpenCLCXX/addrspace-new-delete.cl new file mode 100644 --- /dev/null +++ b/clang/test/CodeGenOpenCLCXX/addrspace-new-delete.cl @@ -0,0 +1,16 @@ +// RUN: %clang_cc1 %s -triple spir -cl-std=clc++ -emit-llvm -O0 -o - | FileCheck %s + +typedef __SIZE_TYPE__ size_t; + +class A { +public: + void* operator new(size_t); + void operator delete(void *ptr); +}; + +void test_new_delete(A **a) { +// CHECK: %{{.*}} = call spir_func i8 addrspace(4)* @_ZNU3AS41AnwEj(i32 {{.*}}) + *a = new A; +// CHECK: call spir_func void @_ZNU3AS41AdlEPU3AS4v(i8 addrspace(4)* {{.*}}) + delete *a; +}