diff --git a/flang/include/flang/Optimizer/Dialect/FIRType.h b/flang/include/flang/Optimizer/Dialect/FIRType.h --- a/flang/include/flang/Optimizer/Dialect/FIRType.h +++ b/flang/include/flang/Optimizer/Dialect/FIRType.h @@ -5,6 +5,10 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// +// +// Coding style: https://mlir.llvm.org/getting_started/DeveloperGuide/ +// +//===----------------------------------------------------------------------===// #ifndef OPTIMIZER_DIALECT_FIRTYPE_H #define OPTIMIZER_DIALECT_FIRTYPE_H @@ -67,7 +71,9 @@ /// Is `t` a FIR dialect type that implies a memory (de)reference? bool isa_ref_type(mlir::Type t); -/// Is `t` a type that is always trivially pass-by-reference? +/// Is `t` a type that is always trivially pass-by-reference? Specifically, this +/// is testing if `t` is a ReferenceType or any box type. Compare this to +/// conformsWithPassByRef(), which includes pointers and allocatables. bool isa_passbyref_type(mlir::Type t); /// Is `t` a boxed type?