diff --git a/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.h b/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.h --- a/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.h +++ b/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.h @@ -29,6 +29,9 @@ } void registerMatchers(ast_matchers::MatchFinder *Finder) override; void check(const ast_matchers::MatchFinder::MatchResult &Result) override; + llvm::Optional getCheckTraversalKind() const override { + return TK_IgnoreUnlessSpelledInSource; + } }; } // namespace modernize diff --git a/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp b/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp --- a/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp @@ -23,21 +23,14 @@ auto ConstructExpr = cxxConstructExpr( unless(anyOf(hasDeclaration(cxxConstructorDecl(isExplicit())), - isListInitialization(), hasDescendant(initListExpr()), - isInTemplateInstantiation()))) + isListInitialization(), hasDescendant(initListExpr())))) .bind("ctor"); - auto CtorAsArgument = materializeTemporaryExpr(anyOf( - has(ConstructExpr), has(cxxFunctionalCastExpr(has(ConstructExpr))))); - Finder->addMatcher( - traverse(TK_AsIs, - functionDecl( - isDefinition(), // Declarations don't have return statements. - returns(unless(anyOf(builtinType(), autoType()))), - hasDescendant(returnStmt(hasReturnValue( - has(cxxConstructExpr(has(CtorAsArgument))))))) - .bind("fn")), + returnStmt(hasReturnValue(ConstructExpr), + forFunction(functionDecl(returns(unless(anyOf(builtinType(), + autoType())))) + .bind("fn"))), this); } diff --git a/clang-tools-extra/test/clang-tidy/checkers/modernize-return-braced-init-list.cpp b/clang-tools-extra/test/clang-tidy/checkers/modernize-return-braced-init-list.cpp --- a/clang-tools-extra/test/clang-tidy/checkers/modernize-return-braced-init-list.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/modernize-return-braced-init-list.cpp @@ -1,5 +1,4 @@ -// RUN: %check_clang_tidy -std=c++14 %s modernize-return-braced-init-list %t -// FIXME: Fix the checker to work in C++17 mode. +// RUN: %check_clang_tidy -std=c++14-or-later %s modernize-return-braced-init-list %t namespace std { typedef decltype(sizeof(int)) size_t;