diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td --- a/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td +++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td @@ -63,21 +63,6 @@ CPred<"$_self.isa<::mlir::IntegerType>()">, "LLVM integer type">; -// Type constraints accepting LLVM integer type of a specific width. -class LLVM_IntBase : - Type().getWidth() == " - # width>]>, - "LLVM " # width # "-bit integer type">, - BuildableType< - "::mlir::IntegerType::get($_builder.getContext(), " - # width # ")">; - -def LLVM_i1 : LLVM_IntBase<1>; -def LLVM_i8 : LLVM_IntBase<8>; -def LLVM_i32 : LLVM_IntBase<32>; - // Type constraint accepting LLVM primitive types, i.e. all types except void // and function. def LLVM_PrimitiveType : Type< @@ -107,8 +92,8 @@ // Type constraints accepting LLVM pointer type to integer of a specific width. class LLVM_IntPtrBase : Type< - LLVM_PointerTo>.predicate, - "LLVM pointer to " # LLVM_IntBase.summary>, + LLVM_PointerTo>.predicate, + "LLVM pointer to " # I.summary>, BuildableType<"::mlir::LLVM::LLVMPointerType::get(" "::mlir::IntegerType::get($_builder.getContext(), " # width #"))">; diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td --- a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td +++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td @@ -177,7 +177,7 @@ let arguments = (ins ICmpPredicate:$predicate, LLVM_ScalarOrVectorOf:$lhs, LLVM_ScalarOrVectorOf:$rhs); - let results = (outs LLVM_ScalarOrVectorOf:$res); + let results = (outs LLVM_ScalarOrVectorOf:$res); let llvmBuilder = [{ $res = builder.CreateICmp(getLLVMCmpPredicate($predicate), $lhs, $rhs); }]; @@ -227,7 +227,7 @@ LLVM_ScalarOrVectorOf:$lhs, LLVM_ScalarOrVectorOf:$rhs, DefaultValuedAttr:$fastmathFlags); - let results = (outs LLVM_ScalarOrVectorOf:$res); + let results = (outs LLVM_ScalarOrVectorOf:$res); let llvmBuilder = [{ $res = builder.CreateFCmp(getLLVMCmpPredicate($predicate), $lhs, $rhs); }]; @@ -572,7 +572,7 @@ [NoSideEffect, AllTypesMatch<["trueValue", "falseValue", "res"]>]>, LLVM_Builder< "$res = builder.CreateSelect($condition, $trueValue, $falseValue);"> { - let arguments = (ins LLVM_ScalarOrVectorOf:$condition, + let arguments = (ins LLVM_ScalarOrVectorOf:$condition, LLVM_Type:$trueValue, LLVM_Type:$falseValue); let results = (outs LLVM_Type:$res); let builders = [ @@ -603,7 +603,7 @@ def LLVM_CondBrOp : LLVM_TerminatorOp<"cond_br", [AttrSizedOperandSegments, DeclareOpInterfaceMethods, NoSideEffect]> { - let arguments = (ins LLVM_i1:$condition, + let arguments = (ins I1:$condition, Variadic:$trueDestOperands, Variadic:$falseDestOperands, OptionalAttr:$branch_weights); @@ -676,7 +676,7 @@ def LLVM_SwitchOp : LLVM_TerminatorOp<"switch", [AttrSizedOperandSegments, DeclareOpInterfaceMethods, NoSideEffect]> { - let arguments = (ins LLVM_i32:$value, + let arguments = (ins I32:$value, Variadic:$defaultOperands, Variadic:$caseOperands, OptionalAttr:$case_values, @@ -1231,7 +1231,7 @@ // def LLVM_CoroIdOp : LLVM_IntrOp<"coro.id", [], [], [], 1> { - let arguments = (ins LLVM_i32:$align, + let arguments = (ins I32:$align, LLVM_i8Ptr:$promise, LLVM_i8Ptr:$coroaddr, LLVM_i8Ptr:$fnaddrs); @@ -1256,13 +1256,13 @@ def LLVM_CoroSuspendOp : LLVM_IntrOp<"coro.suspend", [], [], [], 1> { let arguments = (ins LLVM_TokenType:$save, - LLVM_i1:$final); + I1:$final); let assemblyFormat = "$save `,` $final attr-dict `:` type($res)"; } def LLVM_CoroEndOp : LLVM_IntrOp<"coro.end", [], [], [], 1> { let arguments = (ins LLVM_i8Ptr:$handle, - LLVM_i1:$unwind); + I1:$unwind); let assemblyFormat = "$handle `,` $unwind attr-dict `:` type($res)"; } @@ -1532,7 +1532,7 @@ LLVM_AtomicCmpXchgType.predicate>, SubstLeaves<"$_self", "$_self.cast<::mlir::LLVM::LLVMStructType>().getBody()[1]", - LLVM_i1.predicate>]>, + I1.predicate>]>, "an LLVM struct type with any integer or pointer followed by a single-bit " "integer">;