diff --git a/libcxx/include/algorithm b/libcxx/include/algorithm --- a/libcxx/include/algorithm +++ b/libcxx/include/algorithm @@ -385,11 +385,11 @@ RandomAccessIterator result_first, RandomAccessIterator result_last, Compare comp); template - void + constexpr void // constexpr in C++20 nth_element(RandomAccessIterator first, RandomAccessIterator nth, RandomAccessIterator last); template - void + constexpr void // constexpr in C++20 nth_element(RandomAccessIterator first, RandomAccessIterator nth, RandomAccessIterator last, Compare comp); template @@ -3807,7 +3807,7 @@ // stable, 2-3 compares, 0-2 swaps template -unsigned +_LIBCPP_CONSTEXPR_AFTER_CXX11 unsigned __sort3(_ForwardIterator __x, _ForwardIterator __y, _ForwardIterator __z, _Compare __c) { unsigned __r = 0; @@ -3901,7 +3901,7 @@ // Assumes size > 0 template -void +_LIBCPP_CONSTEXPR_AFTER_CXX11 void __selection_sort(_BidirectionalIterator __first, _BidirectionalIterator __last, _Compare __comp) { _BidirectionalIterator __lm1 = __last; @@ -5218,8 +5218,24 @@ // nth_element +template +_LIBCPP_CONSTEXPR_AFTER_CXX11 bool +__nth_element_find_guard(_RandomAccessIterator& __i, _RandomAccessIterator& __j, + _RandomAccessIterator __m, _Compare __comp) +{ + // manually guard downward moving __j against __i + while (true) { + if (__i == --__j) { + return false; + } + if (__comp(*__j, *__m)) { + return true; // found guard for downward moving __j, now use unguarded partition + } + } +} + template -void +_LIBCPP_CONSTEXPR_AFTER_CXX11 void __nth_element(_RandomAccessIterator __first, _RandomAccessIterator __nth, _RandomAccessIterator __last, _Compare __comp) { // _Compare is known to be a reference type @@ -5227,7 +5243,6 @@ const difference_type __limit = 7; while (true) { - __restart: if (__nth == __last) return; difference_type __len = __last - __first; @@ -5267,61 +5282,51 @@ if (!__comp(*__i, *__m)) // if *__first == *__m { // *__first == *__m, *__first doesn't go in first part - // manually guard downward moving __j against __i - while (true) - { - if (__i == --__j) - { - // *__first == *__m, *__m <= all other elements - // Partition instead into [__first, __i) == *__first and *__first < [__i, __last) - ++__i; // __first + 1 - __j = __last; - if (!__comp(*__first, *--__j)) // we need a guard if *__first == *(__last-1) - { - while (true) - { - if (__i == __j) - return; // [__first, __last) all equivalent elements - if (__comp(*__first, *__i)) - { - swap(*__i, *__j); - ++__n_swaps; - ++__i; - break; - } - ++__i; - } - } - // [__first, __i) == *__first and *__first < [__j, __last) and __j == __last - 1 - if (__i == __j) - return; - while (true) - { - while (!__comp(*__first, *__i)) + if (_VSTD::__nth_element_find_guard<_Compare>(__i, __j, __m, __comp)) { + swap(*__i, *__j); + ++__n_swaps; + } else { + // *__first == *__m, *__m <= all other elements + // Partition instead into [__first, __i) == *__first and *__first < [__i, __last) + ++__i; // __first + 1 + __j = __last; + if (!__comp(*__first, *--__j)) { // we need a guard if *__first == *(__last-1) + while (true) { + if (__i == __j) { + return; // [__first, __last) all equivalent elements + } else if (__comp(*__first, *__i)) { + swap(*__i, *__j); + ++__n_swaps; ++__i; - while (__comp(*__first, *--__j)) - ; - if (__i >= __j) break; - swap(*__i, *__j); - ++__n_swaps; + } ++__i; } - // [__first, __i) == *__first and *__first < [__i, __last) - // The first part is sorted, - if (__nth < __i) - return; - // __nth_element the second part - // _VSTD::__nth_element<_Compare>(__i, __nth, __last, __comp); - __first = __i; - goto __restart; } - if (__comp(*__j, *__m)) - { + // [__first, __i) == *__first and *__first < [__j, __last) and __j == __last - 1 + if (__i == __j) { + return; + } + while (true) { + while (!__comp(*__first, *__i)) + ++__i; + while (__comp(*__first, *--__j)) + ; + if (__i >= __j) + break; swap(*__i, *__j); ++__n_swaps; - break; // found guard for downward moving __j, now use unguarded partition + ++__i; } + // [__first, __i) == *__first and *__first < [__i, __last) + // The first part is sorted, + if (__nth < __i) { + return; + } + // __nth_element the second part + // _VSTD::__nth_element<_Compare>(__i, __nth, __last, __comp); + __first = __i; + continue; } } ++__i; @@ -5365,32 +5370,35 @@ { // Check for [__first, __i) already sorted __j = __m = __first; - while (++__j != __i) - { - if (__comp(*__j, *__m)) + while (true) { + if (++__j == __i) { + // [__first, __i) sorted + return; + } + if (__comp(*__j, *__m)) { // not yet sorted, so sort - goto not_sorted; + break; + } __m = __j; } - // [__first, __i) sorted - return; } else { // Check for [__i, __last) already sorted __j = __m = __i; - while (++__j != __last) - { - if (__comp(*__j, *__m)) + while (true) { + if (++__j == __last) { + // [__i, __last) sorted + return; + } + if (__comp(*__j, *__m)) { // not yet sorted, so sort - goto not_sorted; + break; + } __m = __j; } - // [__i, __last) sorted - return; } } -not_sorted: // __nth_element on range containing __nth if (__nth < __i) { @@ -5406,7 +5414,7 @@ } template -inline _LIBCPP_INLINE_VISIBILITY +inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 void nth_element(_RandomAccessIterator __first, _RandomAccessIterator __nth, _RandomAccessIterator __last, _Compare __comp) { @@ -5415,7 +5423,7 @@ } template -inline _LIBCPP_INLINE_VISIBILITY +inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 void nth_element(_RandomAccessIterator __first, _RandomAccessIterator __nth, _RandomAccessIterator __last) { diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element.pass.cpp --- a/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element.pass.cpp +++ b/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element.pass.cpp @@ -9,61 +9,71 @@ // // template -// requires ShuffleIterator -// && LessThanComparable -// void +// requires ShuffleIterator && LessThanComparable +// constexpr void // constexpr in C++20 // nth_element(Iter first, Iter nth, Iter last); #include -#include #include #include "test_macros.h" +#include "test_iterators.h" +#include "MoveOnly.h" -std::mt19937 randomness; - -void -test_one(int N, int M) +template +TEST_CONSTEXPR_CXX20 bool test() { - assert(N != 0); - assert(M < N); - int* array = new int[N]; - for (int i = 0; i < N; ++i) - array[i] = i; - std::shuffle(array, array+N, randomness); - std::nth_element(array, array+M, array+N); - assert(array[M] == M); - std::nth_element(array, array+N, array+N); // begin, end, end - delete [] array; -} + int orig[15] = {3,1,4,1,5, 9,2,6,5,3, 5,8,9,7,9}; + T work[15] = {3,1,4,1,5, 9,2,6,5,3, 5,8,9,7,9}; + for (int n = 0; n < 15; ++n) { + for (int m = 0; m < n; ++m) { + std::nth_element(Iter(work), Iter(work+m), Iter(work+n)); + assert(std::is_permutation(work, work+n, orig)); + // No element to m's left is greater than m. + for (int i = 0; i < m; ++i) { + assert(!(work[i] > work[m])); + } + // No element to m's right is less than m. + for (int i = m; i < n; ++i) { + assert(!(work[i] < work[m])); + } + std::copy(orig, orig+15, work); + } + } -void -test(int N) -{ - test_one(N, 0); - test_one(N, 1); - test_one(N, 2); - test_one(N, 3); - test_one(N, N/2-1); - test_one(N, N/2); - test_one(N, N/2+1); - test_one(N, N-3); - test_one(N, N-2); - test_one(N, N-1); + { + T input[] = {3,1,4,1,5,9,2}; + std::nth_element(Iter(input), Iter(input+4), Iter(input+7)); + assert(input[4] == 4); + assert(input[5] + input[6] == 5 + 9); + } + + { + T input[] = {0, 1, 2, 3, 4, 5, 7, 6}; + std::nth_element(Iter(input), Iter(input + 6), Iter(input + 8)); + assert(input[6] == 6); + assert(input[7] == 7); + } + + return true; } int main(int, char**) { - int d = 0; - std::nth_element(&d, &d, &d); - assert(d == 0); - test(256); - test(257); - test(499); - test(500); - test(997); - test(1000); - test(1009); + test >(); + test(); + +#if TEST_STD_VER >= 11 + test>(); + test(); +#endif + +#if TEST_STD_VER >= 20 + static_assert(test>()); + static_assert(test()); + static_assert(test>()); + static_assert(test()); +#endif - return 0; + return 0; } diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element_comp.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element_comp.pass.cpp --- a/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element_comp.pass.cpp +++ b/libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element_comp.pass.cpp @@ -9,82 +9,64 @@ // // template Compare> -// requires ShuffleIterator -// && CopyConstructible -// void +// requires ShuffleIterator && CopyConstructible +// constexpr void // constexpr in C++20 // nth_element(Iter first, Iter nth, Iter last, Compare comp); #include -#include -#include -#include #include -#include -#include +#include #include "test_macros.h" +#include "test_iterators.h" +#include "MoveOnly.h" -struct indirect_less +template +TEST_CONSTEXPR_CXX20 bool test() { - template - bool operator()(const P& x, const P& y) - {return *x < *y;} -}; - -std::mt19937 randomness; - -void -test_one(int N, int M) -{ - assert(N != 0); - assert(M < N); - int* array = new int[N]; - for (int i = 0; i < N; ++i) - array[i] = i; - std::shuffle(array, array+N, randomness); - std::nth_element(array, array+M, array+N, std::greater()); - assert(array[M] == N-M-1); - std::nth_element(array, array+N, array+N, std::greater()); // begin, end, end - delete [] array; -} + int orig[15] = {3,1,4,1,5, 9,2,6,5,3, 5,8,9,7,9}; + T work[15] = {3,1,4,1,5, 9,2,6,5,3, 5,8,9,7,9}; + for (int n = 0; n < 15; ++n) { + for (int m = 0; m < n; ++m) { + std::nth_element(Iter(work), Iter(work+m), Iter(work+n), std::greater()); + assert(std::is_permutation(work, work+n, orig)); + // No element to m's left is less than m. + for (int i = 0; i < m; ++i) { + assert(!(work[i] < work[m])); + } + // No element to m's right is greater than m. + for (int i = m; i < n; ++i) { + assert(!(work[i] > work[m])); + } + std::copy(orig, orig+15, work); + } + } -void -test(int N) -{ - test_one(N, 0); - test_one(N, 1); - test_one(N, 2); - test_one(N, 3); - test_one(N, N/2-1); - test_one(N, N/2); - test_one(N, N/2+1); - test_one(N, N-3); - test_one(N, N-2); - test_one(N, N-1); + { + T input[] = {3,1,4,1,5,9,2}; + std::nth_element(Iter(input), Iter(input+4), Iter(input+7), std::greater()); + assert(input[4] == 2); + assert(input[5] + input[6] == 1 + 1); + } + return true; } int main(int, char**) { - int d = 0; - std::nth_element(&d, &d, &d); - assert(d == 0); - test(256); - test(257); - test(499); - test(500); - test(997); - test(1000); - test(1009); + test >(); + test(); #if TEST_STD_VER >= 11 - { - std::vector > v(1000); - for (int i = 0; static_cast(i) < v.size(); ++i) - v[i].reset(new int(i)); - std::nth_element(v.begin(), v.begin() + v.size()/2, v.end(), indirect_less()); - assert(static_cast(*v[v.size()/2]) == v.size()/2); - } + test>(); + test(); +#endif + +#if TEST_STD_VER >= 20 + static_assert(test>()); + static_assert(test()); + static_assert(test>()); + static_assert(test()); #endif - return 0; + return 0; }