diff --git a/clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp b/clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp --- a/clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp @@ -712,10 +712,11 @@ if (isa(ContainerExpr)) { ContainerString = "this"; } else { - // For CXXOperatorCallExpr (e.g. vector_ptr->size()), its first argument is - // the class object (vector_ptr) we are targeting. + // For CXXOperatorCallExpr such as vector_ptr->size() we want the class + // object vector_ptr, but for vector[2] we need the whole expression. if (const auto* E = dyn_cast(ContainerExpr)) - ContainerExpr = E->getArg(0); + if (E->getOperator() != OO_Subscript) + ContainerExpr = E->getArg(0); ContainerString = getStringFromRange(Context->getSourceManager(), Context->getLangOpts(), ContainerExpr->getSourceRange()); diff --git a/clang-tools-extra/test/clang-tidy/checkers/modernize-loop-convert-multidimensional.cpp b/clang-tools-extra/test/clang-tidy/checkers/modernize-loop-convert-multidimensional.cpp new file mode 100644 --- /dev/null +++ b/clang-tools-extra/test/clang-tidy/checkers/modernize-loop-convert-multidimensional.cpp @@ -0,0 +1,79 @@ +// RUN: %check_clang_tidy %s modernize-loop-convert %t + +template +struct Vector { + using iterator = T*; + unsigned size() const; + const T &operator[](int) const; + T &operator[](int); + T *begin(); + T *end(); + const T *begin() const; + const T *end() const; +}; + +template +void copyArg(T); + +class TestArrayOfVector { + Vector W[2]; + + void foo() const { + for (int I = 0; I < W[0].size(); ++I) { + if (W[0][I]) + copyArg(W[0][I]); + } + // CHECK-MESSAGES: :[[@LINE-4]]:5: warning: use range-based for loop + // CHECK-FIXES: for (int I : W[0]) { + // CHECK-FIXES-NEXT: if (I) + // CHECK-FIXES-NEXT: copyArg(I); + } +}; + +class TestVectorOfVector { + Vector> X; + + void foo() const { + for (int J = 0; J < X[0].size(); ++J) { + if (X[0][J]) + copyArg(X[0][J]); + } + // CHECK-MESSAGES: :[[@LINE-4]]:5: warning: use range-based for loop + // CHECK-FIXES: for (int J : X[0]) { + // CHECK-FIXES-NEXT: if (J) + // CHECK-FIXES-NEXT: copyArg(J); + } +}; + +void testVectorOfVectorOfVector() { + Vector>> Y; + for (int J = 0; J < Y[3].size(); ++J) { + if (Y[3][J][7]) + copyArg(Y[3][J][8]); + } + // CHECK-MESSAGES: :[[@LINE-4]]:3: warning: use range-based for loop + // CHECK-FIXES: for (auto & J : Y[3]) { + // CHECK-FIXES-NEXT: if (J[7]) + // CHECK-FIXES-NEXT: copyArg(J[8]); + + for (int J = 0; J < Y[3][4].size(); ++J) { + if (Y[3][4][J]) + copyArg(Y[3][4][J]); + } + // CHECK-MESSAGES: :[[@LINE-4]]:3: warning: use range-based for loop + // CHECK-FIXES: for (int J : Y[3][4]) { + // CHECK-FIXES-NEXT: if (J) + // CHECK-FIXES-NEXT: copyArg(J); +} + +void testVectorOfVectorIterator() { + Vector> Z; + for (Vector::iterator it = Z[4].begin(); it != Z[4].end(); ++it) { + if (*it) + copyArg(*it); + } + // CHECK-MESSAGES: :[[@LINE-4]]:3: warning: use range-based for loop + // CHECK-FIXES: for (int & it : Z[4]) { + // CHECK-FIXES-NEXT: if (it) + // CHECK-FIXES-NEXT: copyArg(it); +}