This is an archive of the discontinued LLVM Phabricator instance.

Differential D95462

Fix an error about implicit fallthrough during self build - new tag for ittapi.
ClosedPublic

Authored by zahiraam on Jan 26 2021, 11:06 AM.

Details

Reviewers
bader
Commits
rGf96767368f5d: Fix an error about implicit fallthrough during self build - new tag for ittapi.
Summary

A fix has been implemented in the ittap repo to fix an error about implicit fallthrough in a switch that was occurring during self build.
A new tag has been created for that fix. This is to update the tag.

Diff Detail

Event Timeline

zahiraam created this revision.Jan 26 2021, 11:06 AM
Herald added subscribers: hiraditya, mgorny. · View Herald TranscriptJan 26 2021, 11:06 AM
zahiraam requested review of this revision.Jan 26 2021, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2021, 11:06 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
bader accepted this revision.Jan 26 2021, 11:46 AM

LGTM. Let me know if you need help with submitting this patch.

This revision is now accepted and ready to land.Jan 26 2021, 11:46 AM
zahiraam added a comment.Jan 26 2021, 11:56 AM
In D95462#2523435, @bader wrote:

LGTM. Let me know if you need help with submitting this patch.

Would you mind submitting it for me please! Thanks.

Closed by commit rGf96767368f5d: Fix an error about implicit fallthrough during self build - new tag for ittapi. (authored by bader). · Explain WhyJan 27 2021, 12:57 AM
This revision was automatically updated to reflect the committed changes.
bader added a commit: rGf96767368f5d: Fix an error about implicit fallthrough during self build - new tag for ittapi..

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
IntelJITEvents/
2 lines

Diff 319489

llvm/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt

include_directories( ${CMAKE_CURRENT_SOURCE_DIR}/.. ) include_directories( ${CMAKE_CURRENT_SOURCE_DIR}/.. )
if(NOT DEFINED ITTAPI_GIT_REPOSITORY) if(NOT DEFINED ITTAPI_GIT_REPOSITORY)
set(ITTAPI_GIT_REPOSITORY https://github.com/intel/ittapi.git) set(ITTAPI_GIT_REPOSITORY https://github.com/intel/ittapi.git)
endif() endif()
if(NOT DEFINED ITTAPI_GIT_TAG) if(NOT DEFINED ITTAPI_GIT_TAG)
set(ITTAPI_GIT_TAG v3.18.8) set(ITTAPI_GIT_TAG v3.18.10)
endif() endif()
if(NOT DEFINED ITTAPI_SOURCE_DIR) if(NOT DEFINED ITTAPI_SOURCE_DIR)
set(ITTAPI_SOURCE_DIR ${PROJECT_BINARY_DIR}) set(ITTAPI_SOURCE_DIR ${PROJECT_BINARY_DIR})
endif() endif()
if(NOT EXISTS ${ITTAPI_SOURCE_DIR}/ittapi) if(NOT EXISTS ${ITTAPI_SOURCE_DIR}/ittapi)
execute_process(COMMAND ${GIT_EXECUTABLE} clone ${ITTAPI_GIT_REPOSITORY} execute_process(COMMAND ${GIT_EXECUTABLE} clone ${ITTAPI_GIT_REPOSITORY}
Show All 40 Lines