[flang] Disallow INTENT attribute on procedure dummy arguments

[PeteSteinfeld]

Summary

C843 states that "An entity with the INTENT attribute shall be a dummy
data object or a dummy procedure pointer." This change enforces that
and fixes some tests that erroneously violated this rule.

[tskeith]

flang/lib/Semantics/check-declarations.cpp

635

c843 -> C843 would be consistent with other references to constraints.

[PeteSteinfeld]

flang/lib/Semantics/check-declarations.cpp

635

Oops. I'll fix it.

flang/lib/Semantics/check-declarations.cpp

void CheckHelper::CheckArraySpec(
   if (msg) {
     context_.Say(std::move(*msg), symbol.name());
   }
 }
 
 void CheckHelper::CheckProcEntity(
     const Symbol &symbol, const ProcEntityDetails &details) {
   if (details.isDummy()) {
+    if (!symbol.attrs().test(Attr::POINTER) && // C843
+        (symbol.attrs().test(Attr::INTENT_IN) ||
+            symbol.attrs().test(Attr::INTENT_OUT) ||
+            symbol.attrs().test(Attr::INTENT_INOUT))) {
+      messages_.Say("A dummy procedure without the POINTER attribute"
+                    " may not have an INTENT attribute"_err_en_US);
+    }
+
     const Symbol *interface{details.interface().symbol()};
     if (!symbol.attrs().test(Attr::INTRINSIC) &&
         (symbol.attrs().test(Attr::ELEMENTAL) ||
             (interface && !interface->attrs().test(Attr::INTRINSIC) &&
                 interface->attrs().test(Attr::ELEMENTAL)))) {
       // There's no explicit constraint or "shall" that we can find in the
       // standard for this check, but it seems to be implied in multiple
       // sites, and ELEMENTAL non-intrinsic actual arguments *are*

flang/test/Semantics/assign03.f90

contains
     function f()
       procedure(s), pointer :: f
       f => s
     end
   end
 
   ! C1030 and 10.2.2.4 - procedure names as target of procedure pointer
   subroutine s4(s_dummy)
-    procedure(s), intent(in) :: s_dummy
+    procedure(s) :: s_dummy
     procedure(s), pointer :: p, q
     procedure(), pointer :: r
     integer :: i
     external :: s_external
     p => s_dummy
     p => s_internal
     p => s_module
     q => p

flang/test/Semantics/call09.f90

 ! RUN: %S/test_errors.sh %s %t %f18
 ! Test 15.5.2.9(2,3,5) dummy procedure requirements
+! C843
+!   An entity with the INTENT attribute shall be a dummy data object or a 
+!   dummy procedure pointer.
 
 module m
  contains
 
   integer function intfunc(x)
     integer, intent(in) :: x
     intfunc = x
   end function
   real function realfunc(x)
     real, intent(in) :: x
     realfunc = x
   end function
 
   subroutine s01(p)
     procedure(realfunc), pointer, intent(in) :: p
   end subroutine
   subroutine s02(p)
     procedure(realfunc), pointer :: p
   end subroutine
   subroutine s03(p)
     procedure(realfunc) :: p
   end subroutine
+  subroutine s04(p)
+    !ERROR: A dummy procedure without the POINTER attribute may not have an INTENT attribute
+    procedure(realfunc), intent(in) :: p
+  end subroutine
 
   subroutine selemental1(p)
     procedure(cos) :: p ! ok
   end subroutine
 
   real elemental function elemfunc(x)
     real, intent(in) :: x
     elemfunc = x

flang/test/Semantics/separate-mp02.f90

contains
   module subroutine s3() bind(c, name="s3" // suffix)
   end
 end
 
 
 module m3
   interface
     module subroutine s1(x, y, z)
-      procedure(real), intent(in) :: x
-      procedure(real), intent(out) :: y
-      procedure(real), intent(out) :: z
+      procedure(real), pointer, intent(in) :: x
+      procedure(real), pointer, intent(out) :: y
+      procedure(real), pointer, intent(out) :: z
     end
     module subroutine s2(x, y)
       procedure(real), pointer :: x
       procedure(real) :: y
     end
   end interface
 end
 
 submodule(m3) sm3
 contains
   module subroutine s1(x, y, z)
-    procedure(real), intent(in) :: x
+    procedure(real), pointer, intent(in) :: x
     !ERROR: The intent of dummy argument 'y' does not match the intent of the corresponding argument in the interface body
-    procedure(real), intent(inout) :: y
+    procedure(real), pointer, intent(inout) :: y
     !ERROR: The intent of dummy argument 'z' does not match the intent of the corresponding argument in the interface body
-    procedure(real) :: z
+    procedure(real), pointer :: z
   end
   module subroutine s2(x, y)
     !ERROR: Dummy argument 'x' has the OPTIONAL attribute; the corresponding argument in the interface body does not
     !ERROR: Dummy argument 'x' does not have the POINTER attribute; the corresponding argument in the interface body does
     procedure(real), optional :: x
     !ERROR: Dummy argument 'y' has the POINTER attribute; the corresponding argument in the interface body does not
     procedure(real), pointer :: y
   end