This is an archive of the discontinued LLVM Phabricator instance.

[Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr
ClosedPublic

Authored by sgraenitz on Jan 14 2021, 7:22 AM.

Details

Summary

All other layers in LLJIT are stored as unique_ptr's already. At this point, it is not strictly necessary for ObjTransformLayer, but it makes a follow-up change more straightforward.

Diff Detail

Event Timeline

sgraenitz created this revision.Jan 14 2021, 7:22 AM
sgraenitz requested review of this revision.Jan 14 2021, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2021, 7:22 AM

The follow-up change is D94690. It also moves the instantiation of ObjLinkingLayer from the initialization list to the ctor body.

lhames accepted this revision.Jan 14 2021, 12:45 PM

LGTM!

This revision is now accepted and ready to land.Jan 14 2021, 12:45 PM
This revision was landed with ongoing or failed builds.Jan 15 2021, 3:54 AM
This revision was automatically updated to reflect the committed changes.