This is an archive of the discontinued LLVM Phabricator instance.

Differential D94634

[libc][NFC] change isblank and iscntrl from implicit casting
ClosedPublic

Authored by michaelrj on Jan 13 2021, 2:04 PM.

Details

Reviewers
sivachandra
Commits
rGea8034ec35a9: [libc][NFC] change isblank and iscntrl from implicit casting
Summary

isblank and iscntrl were casting an int to a char implicitly and this
was throwing errors under Fuchsia. I've added a static cast to resolve
this issue.

Diff Detail

Event Timeline

michaelrj created this revision.Jan 13 2021, 2:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2021, 2:04 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Jan 13 2021, 2:04 PM
sivachandra accepted this revision.Jan 13 2021, 2:06 PM
This revision is now accepted and ready to land.Jan 13 2021, 2:06 PM
This revision was landed with ongoing or failed builds.Jan 13 2021, 2:07 PM
Closed by commit rGea8034ec35a9: [libc][NFC] change isblank and iscntrl from implicit casting (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGea8034ec35a9: [libc][NFC] change isblank and iscntrl from implicit casting.
Harbormaster completed remote builds in B85092: Diff 316513.Jan 13 2021, 2:38 PM

Revision Contents

PathSize
libc/
src/
ctype/
2 lines
2 lines

Diff 316514

libc/src/ctype/isblank.cpp

Show All 9 Lines
#include "src/__support/common.h" #include "src/__support/common.h"
namespace __llvm_libc { namespace __llvm_libc {
// TODO: Currently restricted to default locale. // TODO: Currently restricted to default locale.
// These should be extended using locale information. // These should be extended using locale information.
LLVM_LIBC_FUNCTION(int, isblank, (int c)) { LLVM_LIBC_FUNCTION(int, isblank, (int c)) {
const unsigned char ch = c; const unsigned char ch = static_cast<char>(c);
return ch == ' ' || ch == '\t'; return ch == ' ' || ch == '\t';
} }
} // namespace __llvm_libc } // namespace __llvm_libc

libc/src/ctype/iscntrl.cpp

Show All 9 Lines
#include "src/__support/common.h" #include "src/__support/common.h"
namespace __llvm_libc { namespace __llvm_libc {
// TODO: Currently restricted to default locale. // TODO: Currently restricted to default locale.
// These should be extended using locale information. // These should be extended using locale information.
LLVM_LIBC_FUNCTION(int, iscntrl, (int c)) { LLVM_LIBC_FUNCTION(int, iscntrl, (int c)) {
const unsigned char ch = c; const unsigned char ch = static_cast<char>(c);
return ch < 0x20 || ch == 0x7f; return ch < 0x20 || ch == 0x7f;
} }
} // namespace __llvm_libc } // namespace __llvm_libc