diff --git a/llvm/include/llvm/Support/TaskQueue.h b/llvm/include/llvm/Support/TaskQueue.h --- a/llvm/include/llvm/Support/TaskQueue.h +++ b/llvm/include/llvm/Support/TaskQueue.h @@ -98,7 +98,7 @@ IsTaskInFlight = true; } } - return std::move(F); + return F; } private: diff --git a/llvm/unittests/Support/CrashRecoveryTest.cpp b/llvm/unittests/Support/CrashRecoveryTest.cpp --- a/llvm/unittests/Support/CrashRecoveryTest.cpp +++ b/llvm/unittests/Support/CrashRecoveryTest.cpp @@ -109,8 +109,9 @@ std::string Str = RawStream.str(); // FIXME: Handle "Depth" parameter in PrintStackTrace() function // to print stack trace upto a specified Depth. - if (!Triple(sys::getProcessTriple()).isOSWindows()) + if (!Triple(sys::getProcessTriple()).isOSWindows()) { EXPECT_EQ(std::string::npos, Str.find("#1")); + } } #ifdef _WIN32 diff --git a/mlir/include/mlir/Parser.h b/mlir/include/mlir/Parser.h --- a/mlir/include/mlir/Parser.h +++ b/mlir/include/mlir/Parser.h @@ -67,7 +67,7 @@ // contain the operations inside of it. if (failed(op.verify())) return OwningOpRef(); - return std::move(opRef); + return opRef; } } // end namespace detail diff --git a/mlir/tools/mlir-tblgen/OpFormatGen.cpp b/mlir/tools/mlir-tblgen/OpFormatGen.cpp --- a/mlir/tools/mlir-tblgen/OpFormatGen.cpp +++ b/mlir/tools/mlir-tblgen/OpFormatGen.cpp @@ -1641,7 +1641,7 @@ lastWasPunctuation); // Emit a whitespace element. - if (NewlineElement *newline = dyn_cast(element)) { + if (isa(element)) { body << " p.printNewline();\n"; return; } diff --git a/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp b/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp --- a/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp +++ b/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp @@ -244,7 +244,7 @@ "is", "lambda", "nonlocal", "not", "or", "pass", "raise", "return", "try", "while", "with", "yield"}); return keywords.contains(str); -}; +} /// Checks whether `str` would shadow a generated variable or attribute /// part of the OpView API.