diff --git a/llvm/include/llvm/ADT/Optional.h b/llvm/include/llvm/ADT/Optional.h --- a/llvm/include/llvm/ADT/Optional.h +++ b/llvm/include/llvm/ADT/Optional.h @@ -15,6 +15,7 @@ #ifndef LLVM_ADT_OPTIONAL_H #define LLVM_ADT_OPTIONAL_H +#include "llvm/ADT/Hashing.h" #include "llvm/ADT/None.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/type_traits.h" @@ -299,6 +300,10 @@ #endif }; +template llvm::hash_code hash_value(const Optional &O) { + return O ? hash_combine(true, *O) : hash_value(false); +} + template constexpr bool operator==(const Optional &X, const Optional &Y) { if (X && Y) diff --git a/llvm/unittests/ADT/OptionalTest.cpp b/llvm/unittests/ADT/OptionalTest.cpp --- a/llvm/unittests/ADT/OptionalTest.cpp +++ b/llvm/unittests/ADT/OptionalTest.cpp @@ -599,4 +599,21 @@ EXPECT_NONFATAL_FAILURE(EXPECT_EQ(llvm::None, Comparable::get()), "object"); } +TEST(OptionalTest, HashValue) { + // Check that None, false, and true all hash differently. + Optional B, B0 = false, B1 = true; + EXPECT_NE(hash_value(B0), hash_value(B)); + EXPECT_NE(hash_value(B1), hash_value(B)); + EXPECT_NE(hash_value(B1), hash_value(B0)); + + // Check that None, 0, and 1 all hash differently. + Optional I, I0 = 0, I1 = 1; + EXPECT_NE(hash_value(I0), hash_value(I)); + EXPECT_NE(hash_value(I1), hash_value(I)); + EXPECT_NE(hash_value(I1), hash_value(I0)); + + // Check None hash the same way regardless of type. + EXPECT_EQ(hash_value(B), hash_value(I)); +} + } // end anonymous namespace