This is an archive of the discontinued LLVM Phabricator instance.

Differential D92566

[NFC][Tests] Added one additional test case for NaryRessociation pass.
ClosedPublic

Authored by ebrevnov on Dec 3 2020, 4:03 AM.

Details

Reviewers
ebrevnov
Commits
rG5c6dc7b882be: [NFC][Tests] Added one additional test case for NaryRessociation pass.
Summary

New tes cases added. Change var names to avoid the following warning from update_test_checks.py:

WARNING: Change IR value name 'tmp5' to prevent possible conflict with scripted FileCheck name.

Diff Detail

Event Timeline

ebrevnov created this revision.Dec 3 2020, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 4:03 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
ebrevnov requested review of this revision.Dec 3 2020, 4:03 AM
ebrevnov accepted this revision.Dec 3 2020, 4:05 AM
ebrevnov edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 3 2020, 4:05 AM
This revision was landed with ongoing or failed builds.Dec 3 2020, 4:11 AM
Closed by commit rG5c6dc7b882be: [NFC][Tests] Added one additional test case for NaryRessociation pass. (authored by Evgeniy Brevnov <ybrevnov@azul.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Evgeniy Brevnov <ybrevnov@azul.com> added a commit: rG5c6dc7b882be: [NFC][Tests] Added one additional test case for NaryRessociation pass..
Harbormaster completed remote builds in B80943: Diff 309219.Dec 3 2020, 4:52 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
NaryReassociate/
47 lines

Diff 309221

llvm/test/Transforms/NaryReassociate/pr24301.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -nary-reassociate -S | FileCheck %s ; RUN: opt < %s -nary-reassociate -S | FileCheck %s
; RUN: opt < %s -passes='nary-reassociate' -S | FileCheck %s ; RUN: opt < %s -passes='nary-reassociate' -S | FileCheck %s
define i32 @foo(i32 %tmp4) { define i32 @foo(i32 %t4) {
; CHECK-LABEL: @foo( ; CHECK-LABEL: @foo(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP5:%.*]] = add i32 [[TMP4:%.*]], 8 ; CHECK-NEXT: [[T5:%.*]] = add i32 [[T4:%.*]], 8
; CHECK-NEXT: [[TMP14:%.*]] = add i32 [[TMP5]], -128 ; CHECK-NEXT: [[T14:%.*]] = add i32 [[T5]], -128
; CHECK-NEXT: [[TMP21:%.*]] = add i32 119, [[TMP4]] ; CHECK-NEXT: [[T21:%.*]] = add i32 119, [[T4]]
; CHECK-NEXT: [[TMP23:%.*]] = add i32 [[TMP21]], -128 ; CHECK-NEXT: [[T23:%.*]] = add i32 [[T21]], -128
; CHECK-NEXT: ret i32 [[TMP23]] ; CHECK-NEXT: ret i32 [[T23]]
; ;
entry: entry:
%tmp5 = add i32 %tmp4, 8 %t5 = add i32 %t4, 8
%tmp13 = add i32 %tmp4, -128 ; deleted %t13 = add i32 %t4, -128 ; deleted
%tmp14 = add i32 %tmp13, 8 ; => %tmp5 + -128 %t14 = add i32 %t13, 8 ; => %t5 + -128
%tmp21 = add i32 119, %tmp4 %t21 = add i32 119, %t4
; do not rewrite %tmp23 against %tmp13 because %tmp13 is already deleted ; do not rewrite %t23 against %t13 because %t13 is already deleted
%tmp23 = add i32 %tmp21, -128 %t23 = add i32 %t21, -128
ret i32 %tmp23 ret i32 %t23
}
; This is essentially the same test as the previous one but intermidiate result (t14) has a use.
define i32 @foo2(i32 %t4) {
; CHECK-LABEL: @foo2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[T5:%.*]] = add i32 [[T4:%.*]], 8
; CHECK-NEXT: [[T14:%.*]] = add i32 [[T5]], -128
; CHECK-NEXT: [[T21:%.*]] = add i32 119, [[T4]]
; CHECK-NEXT: [[T23:%.*]] = add i32 [[T21]], -128
; CHECK-NEXT: [[RES:%.*]] = add i32 [[T14]], [[T23]]
; CHECK-NEXT: ret i32 [[RES]]
;
entry:
%t5 = add i32 %t4, 8
%t13 = add i32 %t4, -128 ; deleted
%t14 = add i32 %t13, 8 ; => %t5 + -128
%t21 = add i32 119, %t4
%t23 = add i32 %t21, -128
%res = add i32 %t14, %t23
ret i32 %res
} }