Index: llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h =================================================================== --- llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h +++ llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h @@ -24,6 +24,7 @@ #include "llvm/IR/IRBuilder.h" #include "llvm/IR/ValueHandle.h" #include "llvm/Support/CommandLine.h" +#include "llvm/Support/InstructionCost.h" namespace llvm { extern cl::opt SCEVCheapExpansionBudget; @@ -235,7 +236,7 @@ return true; // by always claiming to be high-cost. SmallVector Worklist; SmallPtrSet Processed; - int BudgetRemaining = Budget * TargetTransformInfo::TCC_Basic; + InstructionCost BudgetRemaining(Budget * TargetTransformInfo::TCC_Basic); Worklist.emplace_back(-1, -1, Expr); while (!Worklist.empty()) { const SCEVOperand WorkItem = Worklist.pop_back_val(); @@ -243,6 +244,7 @@ *TTI, Processed, Worklist)) return true; } + assert(BudgetRemaining.isValid() && "Expected a valid cost"); assert(BudgetRemaining >= 0 && "Should have returned from inner loop."); return false; } @@ -409,7 +411,7 @@ /// Recursive helper function for isHighCostExpansion. bool isHighCostExpansionHelper( const SCEVOperand &WorkItem, Loop *L, const Instruction &At, - int &BudgetRemaining, const TargetTransformInfo &TTI, + InstructionCost &BudgetRemaining, const TargetTransformInfo &TTI, SmallPtrSetImpl &Processed, SmallVectorImpl &Worklist); Index: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp =================================================================== --- llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp +++ llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp @@ -2199,13 +2199,13 @@ return None; } -template static int costAndCollectOperands( +template static InstructionCost costAndCollectOperands( const SCEVOperand &WorkItem, const TargetTransformInfo &TTI, TargetTransformInfo::TargetCostKind CostKind, SmallVectorImpl &Worklist) { const T *S = cast(WorkItem.S); - int Cost = 0; + InstructionCost Cost = 0; // Object to help map SCEV operands to expanded IR instructions. struct OperationIndices { OperationIndices(unsigned Opc, size_t min, size_t max) : @@ -2220,7 +2220,7 @@ // we know what the generated user(s) will be. SmallVector Operations; - auto CastCost = [&](unsigned Opcode) { + auto CastCost = [&](unsigned Opcode) -> InstructionCost { Operations.emplace_back(Opcode, 0, 0); return TTI.getCastInstrCost(Opcode, S->getType(), S->getOperand(0)->getType(), @@ -2228,14 +2228,15 @@ }; auto ArithCost = [&](unsigned Opcode, unsigned NumRequired, - unsigned MinIdx = 0, unsigned MaxIdx = 1) { + unsigned MinIdx = 0, + unsigned MaxIdx = 1) -> InstructionCost { Operations.emplace_back(Opcode, MinIdx, MaxIdx); return NumRequired * TTI.getArithmeticInstrCost(Opcode, S->getType(), CostKind); }; - auto CmpSelCost = [&](unsigned Opcode, unsigned NumRequired, - unsigned MinIdx, unsigned MaxIdx) { + auto CmpSelCost = [&](unsigned Opcode, unsigned NumRequired, unsigned MinIdx, + unsigned MaxIdx) -> InstructionCost { Operations.emplace_back(Opcode, MinIdx, MaxIdx); Type *OpType = S->getOperand(0)->getType(); return NumRequired * TTI.getCmpSelInstrCost( @@ -2306,10 +2307,11 @@ // Much like with normal add expr, the polynominal will require // one less addition than the number of it's terms. - int AddCost = ArithCost(Instruction::Add, NumTerms - 1, - /*MinIdx*/1, /*MaxIdx*/1); + InstructionCost AddCost = ArithCost(Instruction::Add, NumTerms - 1, + /*MinIdx*/ 1, /*MaxIdx*/ 1); // Here, *each* one of those will require a multiplication. - int MulCost = ArithCost(Instruction::Mul, NumNonZeroDegreeNonOneTerms); + InstructionCost MulCost = + ArithCost(Instruction::Mul, NumNonZeroDegreeNonOneTerms); Cost = AddCost + MulCost; // What is the degree of this polynominal? @@ -2340,10 +2342,10 @@ bool SCEVExpander::isHighCostExpansionHelper( const SCEVOperand &WorkItem, Loop *L, const Instruction &At, - int &BudgetRemaining, const TargetTransformInfo &TTI, + InstructionCost &BudgetRemaining, const TargetTransformInfo &TTI, SmallPtrSetImpl &Processed, SmallVectorImpl &Worklist) { - if (BudgetRemaining < 0) + if (!BudgetRemaining.isValid() || BudgetRemaining < 0) return true; // Already run out of budget, give up. const SCEV *S = WorkItem.S; @@ -2375,16 +2377,15 @@ Type *Ty = S->getType(); BudgetRemaining -= TTI.getIntImmCostInst( WorkItem.ParentOpcode, WorkItem.OperandIdx, Imm, Ty, CostKind); - return BudgetRemaining < 0; + return !BudgetRemaining.isValid() || BudgetRemaining < 0; } case scTruncate: case scPtrToInt: case scZeroExtend: case scSignExtend: { - int Cost = + BudgetRemaining -= costAndCollectOperands(WorkItem, TTI, CostKind, Worklist); - BudgetRemaining -= Cost; - return false; // Will answer upon next entry into this function. + return !BudgetRemaining.isValid() || BudgetRemaining < 0; } case scUDivExpr: { // UDivExpr is very likely a UDiv that ScalarEvolution's HowFarToZero or @@ -2399,11 +2400,9 @@ SE.getAddExpr(S, SE.getConstant(S->getType(), 1)), &At, L)) return false; // Consider it to be free. - int Cost = + BudgetRemaining -= costAndCollectOperands(WorkItem, TTI, CostKind, Worklist); - // Need to count the cost of this UDiv. - BudgetRemaining -= Cost; - return false; // Will answer upon next entry into this function. + return !BudgetRemaining.isValid() || BudgetRemaining < 0; } case scAddExpr: case scMulExpr: @@ -2415,17 +2414,16 @@ "Nary expr should have more than 1 operand."); // The simple nary expr will require one less op (or pair of ops) // than the number of it's terms. - int Cost = + BudgetRemaining -= costAndCollectOperands(WorkItem, TTI, CostKind, Worklist); - BudgetRemaining -= Cost; - return BudgetRemaining < 0; + return !BudgetRemaining.isValid() || BudgetRemaining < 0; } case scAddRecExpr: { assert(cast(S)->getNumOperands() >= 2 && "Polynomial should be at least linear"); BudgetRemaining -= costAndCollectOperands( WorkItem, TTI, CostKind, Worklist); - return BudgetRemaining < 0; + return !BudgetRemaining.isValid() || BudgetRemaining < 0; } } llvm_unreachable("Unknown SCEV kind!");