Page MenuHomePhabricator
Differential D92087

[llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic tag is invalid.
ClosedPublic
Actions

Authored by grimar on Nov 25 2020, 3:08 AM.

Details

Reviewers
jhenderson
MaskRay
• espindola
Commits
rG54ec9bb5510d: [llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic…
Summary

We report an error for unknown DT_PLTREL values.
This switches the error to warning.

Diff Detail

Event Timeline

grimar created this revision.Nov 25 2020, 3:08 AM
Herald added a reviewer: • espindola. · View Herald TranscriptNov 25 2020, 3:08 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rupprecht, emaste. · View Herald Transcript
grimar requested review of this revision.Nov 25 2020, 3:08 AM
Harbormaster completed remote builds in B80074: Diff 307566.Nov 25 2020, 3:48 AM
MaskRay accepted this revision.Nov 25 2020, 11:01 AM

Thanks!

This revision is now accepted and ready to land.Nov 25 2020, 11:01 AM
jhenderson accepted this revision.Nov 26 2020, 12:19 AM

LGTM too.

Closed by commit rG54ec9bb5510d: [llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic… (authored by grimar). · Explain WhyNov 26 2020, 2:16 AM
This revision was automatically updated to reflect the committed changes.
grimar added a commit: rG54ec9bb5510d: [llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic….

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
2 lines
35 lines
tools/
llvm-readobj/
7 lines

Diff 307799

View Options

llvm/test/tools/llvm-readobj/ELF/broken-dynamic-reloc.test

Loading...
View Options

llvm/test/tools/llvm-readobj/ELF/dynamic-reloc.test

Loading...
View Options

llvm/tools/llvm-readobj/ELFDumper.cpp

Loading...