This is an archive of the discontinued LLVM Phabricator instance.

Enable retry on failed git operations
ClosedPublic

Authored by kuhnel on Nov 23 2020, 12:58 AM.

Details

Summary

I somtimes see fatal: unable to access 'https://github.com/llvm/llvm-project.git/': Could not resolve host: github.com
in buildbot log files, one recent example:
http://lab.llvm.org:8011/#/builders/131/builds/7

From looking at the documentation, the Git step supports also retryFetch, I hope this fixes these issues.

I can't test his as I do not have a running master instance.

Diff Detail

Event Timeline

kuhnel created this revision.Nov 23 2020, 12:58 AM
kuhnel requested review of this revision.Nov 23 2020, 12:58 AM
kuhnel edited the summary of this revision. (Show Details)Nov 23 2020, 1:02 AM
kuhnel added a reviewer: kadircet.
kuhnel edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 23 2020, 1:08 AM
gkistanova accepted this revision.May 17 2021, 10:12 PM

Thanks, Christian.
LGTM

Did you analyze what's the most often reason of git fetch failures? Shall we also set clobberOnFailure to escalate a clone?

kuhnel added a comment.Jun 8 2021, 2:45 AM

Hi @gkistanova,

no I haven't really investigated this. My gut feeling says it's just a connection issue with GitHub. Performing a clone might recover more cases at the expense of network traffic and build time. I would prioritize automatic build recovery higher, so I like your proposal.

Thx for looking into this!

I'll update the patch.

kuhnel updated this revision to Diff 350545.Jun 8 2021, 2:47 AM

added clobberOnFailure=True

kuhnel updated this revision to Diff 350550.Jun 8 2021, 2:49 AM

added clobberOnFailure=True to the 2nd call as well

This revision was automatically updated to reflect the committed changes.