Index: lib/Target/ARM/ARMConstantIslandPass.cpp =================================================================== --- lib/Target/ARM/ARMConstantIslandPass.cpp +++ lib/Target/ARM/ARMConstantIslandPass.cpp @@ -53,11 +53,6 @@ AdjustJumpTableBlocks("arm-adjust-jump-tables", cl::Hidden, cl::init(true), cl::desc("Adjust basic block layout to better use TB[BH]")); -// FIXME: This option should be removed once it has received sufficient testing. -static cl::opt -AlignConstantIslands("arm-align-constant-islands", cl::Hidden, cl::init(true), - cl::desc("Align constant islands in code")); - /// UnknownPadding - Return the worst case padding that could result from /// unknown offset bits. This does not include alignment padding caused by /// known offset bits. @@ -412,13 +407,6 @@ MF->RenumberBlocks(); } - // Thumb1 functions containing constant pools get 4-byte alignment. - // This is so we can keep exact track of where the alignment padding goes. - - // ARM and Thumb2 functions need to be 4-byte aligned. - if (!isThumb1) - MF->ensureAlignment(2); // 2 = log2(4) - // Perform the initial placement of the constant pool entries. To start with, // we put them all at the end of the function. std::vector CPEMIs; @@ -513,8 +501,7 @@ unsigned MaxAlign = Log2_32(MCP->getConstantPoolAlignment()); // Mark the basic block as required by the const-pool. - // If AlignConstantIslands isn't set, use 4-byte alignment for everything. - BB->setAlignment(AlignConstantIslands ? MaxAlign : 2); + BB->setAlignment(MaxAlign); // The function needs to be as aligned as the basic blocks. The linker may // move functions around based on their alignment. @@ -604,10 +591,6 @@ unsigned ARMConstantIslands::getCPELogAlign(const MachineInstr *CPEMI) { assert(CPEMI && CPEMI->getOpcode() == ARM::CONSTPOOL_ENTRY); - // Everything is 4-byte aligned unless AlignConstantIslands is set. - if (!AlignConstantIslands) - return 2; - unsigned CPI = CPEMI->getOperand(1).getIndex(); assert(CPI < MCP->getConstants().size() && "Invalid constant pool index."); unsigned Align = MCP->getConstants()[CPI].getAlignment(); Index: test/CodeGen/ARM/thumb-alignment.ll =================================================================== --- /dev/null +++ test/CodeGen/ARM/thumb-alignment.ll @@ -0,0 +1,15 @@ +; RUN: llc -relocation-model=pic -mtriple=thumbv7-unknown-linux -o - %s | FileCheck %s + +@x = external global i32 + +; CHECK: .globl foo +; CHECK-NEXT: .align 2 +define i32* @foo() { + ret i32* @x +} + +; CHECK: .globl bar +; CHECK-NEXT: .align 1 +define i32* @bar() { + ret i32* zeroinitializer +} Index: test/MC/ARM/elf-thumbfunc-reloc.ll =================================================================== --- test/MC/ARM/elf-thumbfunc-reloc.ll +++ test/MC/ARM/elf-thumbfunc-reloc.ll @@ -24,13 +24,13 @@ ; make sure that bl 0 (fff7feff) is correctly encoded ; CHECK: Sections [ ; CHECK: SectionData ( -; CHECK: 0000: 704700BF 2DE90048 FFF7FEFF BDE80088 +; CHECK: 0000: 70472DE9 0048FFF7 FEFFBDE8 0088 ; CHECK: ) ; CHECK: ] ; CHECK: Relocations [ ; CHECK-NEXT: Section (2) .rel.text { -; CHECK-NEXT: 0x8 R_ARM_THM_CALL foo 0x0 +; CHECK-NEXT: 0x6 R_ARM_THM_CALL foo 0x0 ; CHECK-NEXT: } ; CHECK-NEXT: Section (7) .rel.ARM.exidx { ; CHECK-NEXT: 0x0 R_ARM_PREL31 .text 0x0