diff --git a/libcxx/src/filesystem/operations.cpp b/libcxx/src/filesystem/operations.cpp --- a/libcxx/src/filesystem/operations.cpp +++ b/libcxx/src/filesystem/operations.cpp @@ -1022,15 +1022,32 @@ path __current_path(error_code* ec) { ErrorHandler err("current_path", ec); +#if defined(_LIBCPP_WIN32API) + // Common extension outside of POSIX getcwd() spec, without needing to + // preallocate a buffer. Also supported by a number of other POSIX libcs. + int size = 0; + path::value_type* ptr = nullptr; + typedef decltype(&::free) Deleter; + Deleter deleter = &::free; +#else auto size = ::pathconf(".", _PC_PATH_MAX); _LIBCPP_ASSERT(size >= 0, "pathconf returned a 0 as max size"); - auto buff = unique_ptr(new char[size + 1]); - char* ret; - if ((ret = ::getcwd(buff.get(), static_cast(size))) == nullptr) + auto buff = unique_ptr(new path::value_type[size + 1]); + path::value_type* ptr = buff.get(); + + // Preallocated buffer, don't free the buffer in the second unique_ptr + // below. + struct Deleter { void operator()(void*) const {} }; + Deleter deleter; +#endif + + unique_ptr hold(detail::getcwd(ptr, size), + deleter); + if (hold.get() == nullptr) return err.report(capture_errno(), "call to getcwd failed"); - return {buff.get()}; + return {hold.get()}; } void __current_path(const path& p, error_code* ec) { diff --git a/libcxx/src/filesystem/posix_compat.h b/libcxx/src/filesystem/posix_compat.h --- a/libcxx/src/filesystem/posix_compat.h +++ b/libcxx/src/filesystem/posix_compat.h @@ -311,6 +311,7 @@ return 0; } +wchar_t *getcwd(wchar_t *buff, size_t size) { return _wgetcwd(buff, size); } #else int symlink_file(const char *oldname, const char *newname) { return ::symlink(oldname, newname); @@ -322,6 +323,7 @@ using ::close; using ::fstat; using ::ftruncate; +using ::getcwd; using ::link; using ::lstat; using ::mkdir;