Page MenuHomePhabricator

[lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD
ClosedPublic

Authored by mgorny on Nov 10 2020, 8:18 AM.

Details

Summary

Copy the recent improvements from the FreeBSDRemote plugin, notably:

  • moving event reporting setup into SetupTrace() helper
  • adding more debug info into SIGTRAP handling
  • handling user-generated (and unknown) SIGTRAP events
  • adding missing error handling to the generic signal handler
  • fixing attaching to processes
  • switching watchpoint helpers to use llvm::Error
  • minor style and formatting changes

This fixes a number of tests, mostly related to fixed attaching.

Diff Detail

Event Timeline

mgorny created this revision.Nov 10 2020, 8:18 AM
mgorny requested review of this revision.Nov 10 2020, 8:18 AM
krytarowski accepted this revision.Nov 10 2020, 8:39 AM
This revision is now accepted and ready to land.Nov 10 2020, 8:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 11:21 AM