diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp b/clang/lib/CodeGen/CGOpenMPRuntime.cpp --- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp +++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp @@ -2260,7 +2260,7 @@ if (!CGF.HaveInsertPoint()) return; if (CGF.CGM.getLangOpts().OpenMPIRBuilder) { - OMPBuilder.CreateTaskyield(CGF.Builder); + OMPBuilder.createTaskyield(CGF.Builder); } else { // Build call __kmpc_omp_taskyield(loc, thread_id, 0); llvm::Value *Args[] = { @@ -2515,7 +2515,7 @@ auto *OMPRegionInfo = dyn_cast_or_null(CGF.CapturedStmtInfo); if (CGF.CGM.getLangOpts().OpenMPIRBuilder) { - CGF.Builder.restoreIP(OMPBuilder.CreateBarrier( + CGF.Builder.restoreIP(OMPBuilder.createBarrier( CGF.Builder, Kind, ForceSimpleCall, EmitChecks)); return; } @@ -2877,7 +2877,7 @@ void CGOpenMPRuntime::emitFlush(CodeGenFunction &CGF, ArrayRef, SourceLocation Loc, llvm::AtomicOrdering AO) { if (CGF.CGM.getLangOpts().OpenMPIRBuilder) { - OMPBuilder.CreateFlush(CGF.Builder); + OMPBuilder.createFlush(CGF.Builder); } else { if (!CGF.HaveInsertPoint()) return; @@ -6187,7 +6187,7 @@ return; if (CGF.CGM.getLangOpts().OpenMPIRBuilder) { - OMPBuilder.CreateTaskwait(CGF.Builder); + OMPBuilder.createTaskwait(CGF.Builder); } else { // Build call kmp_int32 __kmpc_omp_taskwait(ident_t *loc, kmp_int32 // global_tid); diff --git a/clang/lib/CodeGen/CGStmtOpenMP.cpp b/clang/lib/CodeGen/CGStmtOpenMP.cpp --- a/clang/lib/CodeGen/CGStmtOpenMP.cpp +++ b/clang/lib/CodeGen/CGStmtOpenMP.cpp @@ -1614,11 +1614,11 @@ Allocator = CGF.Builder.CreatePointerBitCastOrAddrSpaceCast(Allocator, CGM.VoidPtrTy); - llvm::Value *Addr = OMPBuilder.CreateOMPAlloc( + llvm::Value *Addr = OMPBuilder.createOMPAlloc( CGF.Builder, Size, Allocator, getNameWithSeparators({CVD->getName(), ".void.addr"}, ".", ".")); llvm::CallInst *FreeCI = - OMPBuilder.CreateOMPFree(CGF.Builder, Addr, Allocator); + OMPBuilder.createOMPFree(CGF.Builder, Addr, Allocator); CGF.EHStack.pushCleanup(NormalAndEHCleanup, FreeCI); Addr = CGF.Builder.CreatePointerBitCastOrAddrSpaceCast( @@ -1646,7 +1646,7 @@ llvm::Twine CacheName = Twine(CGM.getMangledName(VD)).concat(Suffix); llvm::CallInst *ThreadPrivateCacheCall = - OMPBuilder.CreateCachedThreadPrivate(CGF.Builder, Data, Size, CacheName); + OMPBuilder.createCachedThreadPrivate(CGF.Builder, Data, Size, CacheName); return Address(ThreadPrivateCacheCall, VDAddr.getAlignment()); } @@ -1718,7 +1718,7 @@ llvm::OpenMPIRBuilder::InsertPointTy AllocaIP( AllocaInsertPt->getParent(), AllocaInsertPt->getIterator()); Builder.restoreIP( - OMPBuilder.CreateParallel(Builder, AllocaIP, BodyGenCB, PrivCB, FiniCB, + OMPBuilder.createParallel(Builder, AllocaIP, BodyGenCB, PrivCB, FiniCB, IfCond, NumThreads, ProcBind, S.hasCancel())); return; } @@ -3641,7 +3641,7 @@ LexicalScope Scope(*this, S.getSourceRange()); EmitStopPoint(&S); - Builder.restoreIP(OMPBuilder.CreateMaster(Builder, BodyGenCB, FiniCB)); + Builder.restoreIP(OMPBuilder.createMaster(Builder, BodyGenCB, FiniCB)); return; } @@ -3682,7 +3682,7 @@ LexicalScope Scope(*this, S.getSourceRange()); EmitStopPoint(&S); - Builder.restoreIP(OMPBuilder.CreateCritical( + Builder.restoreIP(OMPBuilder.createCritical( Builder, BodyGenCB, FiniCB, S.getDirectiveName().getAsString(), HintInst)); @@ -5976,7 +5976,7 @@ IfCondition = EmitScalarExpr(IfCond, /*IgnoreResultAssign=*/true); return Builder.restoreIP( - OMPBuilder.CreateCancel(Builder, IfCondition, S.getCancelRegion())); + OMPBuilder.createCancel(Builder, IfCondition, S.getCancelRegion())); } } diff --git a/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h b/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h --- a/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h +++ b/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h @@ -58,7 +58,7 @@ struct FinalizationInfo { /// The finalization callback provided by the last in-flight invocation of - /// CreateXXXX for the directive of kind DK. + /// createXXXX for the directive of kind DK. FinalizeCallbackTy FiniCB; /// The directive kind of the innermost directive that has an associated @@ -152,7 +152,7 @@ /// should be checked and acted upon. /// /// \returns The insertion point after the barrier. - InsertPointTy CreateBarrier(const LocationDescription &Loc, omp::Directive DK, + InsertPointTy createBarrier(const LocationDescription &Loc, omp::Directive DK, bool ForceSimpleCall = false, bool CheckCancelFlag = true); @@ -163,7 +163,7 @@ /// \param CanceledDirective The kind of directive that is cancled. /// /// \returns The insertion point after the barrier. - InsertPointTy CreateCancel(const LocationDescription &Loc, Value *IfCondition, + InsertPointTy createCancel(const LocationDescription &Loc, Value *IfCondition, omp::Directive CanceledDirective); /// Generator for '#omp parallel' @@ -180,7 +180,7 @@ /// /// \returns The insertion position *after* the parallel. IRBuilder<>::InsertPoint - CreateParallel(const LocationDescription &Loc, InsertPointTy AllocaIP, + createParallel(const LocationDescription &Loc, InsertPointTy AllocaIP, BodyGenCallbackTy BodyGenCB, PrivatizeCallbackTy PrivCB, FinalizeCallbackTy FiniCB, Value *IfCondition, Value *NumThreads, omp::ProcBindKind ProcBind, @@ -202,7 +202,7 @@ /// /// \returns An object representing the created control flow structure which /// can be used for loop-associated directives. - CanonicalLoopInfo *CreateCanonicalLoop(const LocationDescription &Loc, + CanonicalLoopInfo *createCanonicalLoop(const LocationDescription &Loc, LoopBodyGenCallbackTy BodyGenCB, Value *TripCount); @@ -250,7 +250,7 @@ /// /// \returns An object representing the created control flow structure which /// can be used for loop-associated directives. - CanonicalLoopInfo *CreateCanonicalLoop(const LocationDescription &Loc, + CanonicalLoopInfo *createCanonicalLoop(const LocationDescription &Loc, LoopBodyGenCallbackTy BodyGenCB, Value *Start, Value *Stop, Value *Step, bool IsSigned, bool InclusiveStop); @@ -258,17 +258,17 @@ /// Generator for '#omp flush' /// /// \param Loc The location where the flush directive was encountered - void CreateFlush(const LocationDescription &Loc); + void createFlush(const LocationDescription &Loc); /// Generator for '#omp taskwait' /// /// \param Loc The location where the taskwait directive was encountered. - void CreateTaskwait(const LocationDescription &Loc); + void createTaskwait(const LocationDescription &Loc); /// Generator for '#omp taskyield' /// /// \param Loc The location where the taskyield directive was encountered. - void CreateTaskyield(const LocationDescription &Loc); + void createTaskyield(const LocationDescription &Loc); ///} @@ -417,7 +417,7 @@ /// /// \return The insertion position *after* the CopyPrivate call. - InsertPointTy CreateCopyPrivate(const LocationDescription &Loc, + InsertPointTy createCopyPrivate(const LocationDescription &Loc, llvm::Value *BufSize, llvm::Value *CpyBuf, llvm::Value *CpyFn, llvm::Value *DidIt); @@ -429,7 +429,7 @@ /// \param DidIt Local variable used as a flag to indicate 'single' thread /// /// \returns The insertion position *after* the single call. - InsertPointTy CreateSingle(const LocationDescription &Loc, + InsertPointTy createSingle(const LocationDescription &Loc, BodyGenCallbackTy BodyGenCB, FinalizeCallbackTy FiniCB, llvm::Value *DidIt); @@ -440,7 +440,7 @@ /// \param FiniCB Callback to finalize variable copies. /// /// \returns The insertion position *after* the master. - InsertPointTy CreateMaster(const LocationDescription &Loc, + InsertPointTy createMaster(const LocationDescription &Loc, BodyGenCallbackTy BodyGenCB, FinalizeCallbackTy FiniCB); @@ -453,7 +453,7 @@ /// \param HintInst Hint Instruction for hint clause associated with critical /// /// \returns The insertion position *after* the master. - InsertPointTy CreateCritical(const LocationDescription &Loc, + InsertPointTy createCritical(const LocationDescription &Loc, BodyGenCallbackTy BodyGenCB, FinalizeCallbackTy FiniCB, StringRef CriticalName, Value *HintInst); @@ -470,7 +470,7 @@ // and copy.in.end block /// /// \returns The insertion point where copying operation to be emitted. - InsertPointTy CreateCopyinClauseBlocks(InsertPointTy IP, Value *MasterAddr, + InsertPointTy createCopyinClauseBlocks(InsertPointTy IP, Value *MasterAddr, Value *PrivateAddr, llvm::IntegerType *IntPtrTy, bool BranchtoEnd = true); @@ -483,7 +483,7 @@ /// \param Name Name of call Instruction for OMP_alloc /// /// \returns CallInst to the OMP_Alloc call - CallInst *CreateOMPAlloc(const LocationDescription &Loc, Value *Size, + CallInst *createOMPAlloc(const LocationDescription &Loc, Value *Size, Value *Allocator, std::string Name = ""); /// Create a runtime call for kmpc_free @@ -494,7 +494,7 @@ /// \param Name Name of call Instruction for OMP_Free /// /// \returns CallInst to the OMP_Free call - CallInst *CreateOMPFree(const LocationDescription &Loc, Value *Addr, + CallInst *createOMPFree(const LocationDescription &Loc, Value *Addr, Value *Allocator, std::string Name = ""); /// Create a runtime call for kmpc_threadprivate_cached @@ -505,7 +505,7 @@ /// \param Name Name of call Instruction for callinst /// /// \returns CallInst to the thread private cache call. - CallInst *CreateCachedThreadPrivate(const LocationDescription &Loc, + CallInst *createCachedThreadPrivate(const LocationDescription &Loc, llvm::Value *Pointer, llvm::ConstantInt *Size, const llvm::Twine &Name = Twine("")); diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp --- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp +++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp @@ -290,7 +290,7 @@ } OpenMPIRBuilder::InsertPointTy -OpenMPIRBuilder::CreateBarrier(const LocationDescription &Loc, Directive DK, +OpenMPIRBuilder::createBarrier(const LocationDescription &Loc, Directive DK, bool ForceSimpleCall, bool CheckCancelFlag) { if (!updateToLocation(Loc)) return Loc.IP; @@ -345,7 +345,7 @@ } OpenMPIRBuilder::InsertPointTy -OpenMPIRBuilder::CreateCancel(const LocationDescription &Loc, +OpenMPIRBuilder::createCancel(const LocationDescription &Loc, Value *IfCondition, omp::Directive CanceledDirective) { if (!updateToLocation(Loc)) @@ -422,7 +422,7 @@ Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } -IRBuilder<>::InsertPoint OpenMPIRBuilder::CreateParallel( +IRBuilder<>::InsertPoint OpenMPIRBuilder::createParallel( const LocationDescription &Loc, InsertPointTy OuterAllocaIP, BodyGenCallbackTy BodyGenCB, PrivatizeCallbackTy PrivCB, FinalizeCallbackTy FiniCB, Value *IfCondition, Value *NumThreads, @@ -748,7 +748,7 @@ Builder.CreateCall(getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_flush), Args); } -void OpenMPIRBuilder::CreateFlush(const LocationDescription &Loc) { +void OpenMPIRBuilder::createFlush(const LocationDescription &Loc) { if (!updateToLocation(Loc)) return; emitFlush(Loc); @@ -766,7 +766,7 @@ Args); } -void OpenMPIRBuilder::CreateTaskwait(const LocationDescription &Loc) { +void OpenMPIRBuilder::createTaskwait(const LocationDescription &Loc) { if (!updateToLocation(Loc)) return; emitTaskwaitImpl(Loc); @@ -783,14 +783,14 @@ Args); } -void OpenMPIRBuilder::CreateTaskyield(const LocationDescription &Loc) { +void OpenMPIRBuilder::createTaskyield(const LocationDescription &Loc) { if (!updateToLocation(Loc)) return; emitTaskyieldImpl(Loc); } OpenMPIRBuilder::InsertPointTy -OpenMPIRBuilder::CreateMaster(const LocationDescription &Loc, +OpenMPIRBuilder::createMaster(const LocationDescription &Loc, BodyGenCallbackTy BodyGenCB, FinalizeCallbackTy FiniCB) { @@ -814,7 +814,7 @@ } CanonicalLoopInfo * -OpenMPIRBuilder::CreateCanonicalLoop(const LocationDescription &Loc, +OpenMPIRBuilder::createCanonicalLoop(const LocationDescription &Loc, LoopBodyGenCallbackTy BodyGenCB, Value *TripCount) { BasicBlock *BB = Loc.IP.getBlock(); @@ -888,7 +888,7 @@ return CL; } -CanonicalLoopInfo *OpenMPIRBuilder::CreateCanonicalLoop( +CanonicalLoopInfo *OpenMPIRBuilder::createCanonicalLoop( const LocationDescription &Loc, LoopBodyGenCallbackTy BodyGenCB, Value *Start, Value *Stop, Value *Step, bool IsSigned, bool InclusiveStop) { // Consider the following difficulties (assuming 8-bit signed integers): @@ -951,7 +951,7 @@ Value *IndVar = Builder.CreateAdd(Span, Start); BodyGenCB(Builder.saveIP(), IndVar); }; - return CreateCanonicalLoop(Builder.saveIP(), BodyGen, TripCount); + return createCanonicalLoop(Builder.saveIP(), BodyGen, TripCount); } void CanonicalLoopInfo::eraseFromParent() { @@ -969,7 +969,7 @@ } OpenMPIRBuilder::InsertPointTy -OpenMPIRBuilder::CreateCopyPrivate(const LocationDescription &Loc, +OpenMPIRBuilder::createCopyPrivate(const LocationDescription &Loc, llvm::Value *BufSize, llvm::Value *CpyBuf, llvm::Value *CpyFn, llvm::Value *DidIt) { if (!updateToLocation(Loc)) @@ -990,7 +990,7 @@ } OpenMPIRBuilder::InsertPointTy -OpenMPIRBuilder::CreateSingle(const LocationDescription &Loc, +OpenMPIRBuilder::createSingle(const LocationDescription &Loc, BodyGenCallbackTy BodyGenCB, FinalizeCallbackTy FiniCB, llvm::Value *DidIt) { @@ -1024,7 +1024,7 @@ /*Conditional*/ true, /*hasFinalize*/ true); } -OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::CreateCritical( +OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::createCritical( const LocationDescription &Loc, BodyGenCallbackTy BodyGenCB, FinalizeCallbackTy FiniCB, StringRef CriticalName, Value *HintInst) { @@ -1188,7 +1188,7 @@ ExitCall->getIterator()); } -OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::CreateCopyinClauseBlocks( +OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::createCopyinClauseBlocks( InsertPointTy IP, Value *MasterAddr, Value *PrivateAddr, llvm::IntegerType *IntPtrTy, bool BranchtoEnd) { if (!IP.isSet()) @@ -1238,7 +1238,7 @@ return Builder.saveIP(); } -CallInst *OpenMPIRBuilder::CreateOMPAlloc(const LocationDescription &Loc, +CallInst *OpenMPIRBuilder::createOMPAlloc(const LocationDescription &Loc, Value *Size, Value *Allocator, std::string Name) { IRBuilder<>::InsertPointGuard IPG(Builder); @@ -1254,7 +1254,7 @@ return Builder.CreateCall(Fn, Args, Name); } -CallInst *OpenMPIRBuilder::CreateOMPFree(const LocationDescription &Loc, +CallInst *OpenMPIRBuilder::createOMPFree(const LocationDescription &Loc, Value *Addr, Value *Allocator, std::string Name) { IRBuilder<>::InsertPointGuard IPG(Builder); @@ -1268,7 +1268,7 @@ return Builder.CreateCall(Fn, Args, Name); } -CallInst *OpenMPIRBuilder::CreateCachedThreadPrivate( +CallInst *OpenMPIRBuilder::createCachedThreadPrivate( const LocationDescription &Loc, llvm::Value *Pointer, llvm::ConstantInt *Size, const llvm::Twine &Name) { IRBuilder<>::InsertPointGuard IPG(Builder); diff --git a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp --- a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp +++ b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp @@ -690,7 +690,7 @@ OriginalFn->getEntryBlock().getFirstInsertionPt()); // Create the merged parallel region with default proc binding, to // avoid overriding binding settings, and without explicit cancellation. - InsertPointTy AfterIP = OMPInfoCache.OMPBuilder.CreateParallel( + InsertPointTy AfterIP = OMPInfoCache.OMPBuilder.createParallel( Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, /* IsCancellable */ false); BranchInst::Create(AfterBB, AfterIP.getBlock()); @@ -730,7 +730,7 @@ if (CI != MergableCIs.back()) { // TODO: Remove barrier if the merged parallel region includes the // 'nowait' clause. - OMPInfoCache.OMPBuilder.CreateBarrier( + OMPInfoCache.OMPBuilder.createBarrier( InsertPointTy(NewCI->getParent(), NewCI->getNextNode()->getIterator()), OMPD_parallel); diff --git a/llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp b/llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp --- a/llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp +++ b/llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp @@ -66,14 +66,14 @@ IRBuilder<> Builder(BB); - OMPBuilder.CreateBarrier({IRBuilder<>::InsertPoint()}, OMPD_for); + OMPBuilder.createBarrier({IRBuilder<>::InsertPoint()}, OMPD_for); EXPECT_TRUE(M->global_empty()); EXPECT_EQ(M->size(), 1U); EXPECT_EQ(F->size(), 1U); EXPECT_EQ(BB->size(), 0U); OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()}); - OMPBuilder.CreateBarrier(Loc, OMPD_for); + OMPBuilder.createBarrier(Loc, OMPD_for); EXPECT_FALSE(M->global_empty()); EXPECT_EQ(M->size(), 3U); EXPECT_EQ(F->size(), 1U); @@ -116,7 +116,7 @@ IRBuilder<> Builder(BB); OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()}); - auto NewIP = OMPBuilder.CreateCancel(Loc, nullptr, OMPD_parallel); + auto NewIP = OMPBuilder.createCancel(Loc, nullptr, OMPD_parallel); Builder.restoreIP(NewIP); EXPECT_FALSE(M->global_empty()); EXPECT_EQ(M->size(), 3U); @@ -171,7 +171,7 @@ IRBuilder<> Builder(BB); OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()}); - auto NewIP = OMPBuilder.CreateCancel(Loc, Builder.getTrue(), OMPD_parallel); + auto NewIP = OMPBuilder.createCancel(Loc, Builder.getTrue(), OMPD_parallel); Builder.restoreIP(NewIP); EXPECT_FALSE(M->global_empty()); EXPECT_EQ(M->size(), 3U); @@ -232,7 +232,7 @@ IRBuilder<> Builder(BB); OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP()}); - auto NewIP = OMPBuilder.CreateBarrier(Loc, OMPD_for); + auto NewIP = OMPBuilder.createBarrier(Loc, OMPD_for); Builder.restoreIP(NewIP); EXPECT_FALSE(M->global_empty()); EXPECT_EQ(M->size(), 3U); @@ -278,7 +278,7 @@ IRBuilder<> Builder(BB); OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP(), DL}); - OMPBuilder.CreateBarrier(Loc, OMPD_for); + OMPBuilder.createBarrier(Loc, OMPD_for); CallInst *GTID = dyn_cast(&BB->front()); CallInst *Barrier = dyn_cast(GTID->getNextNode()); EXPECT_EQ(GTID->getDebugLoc(), DL); @@ -365,7 +365,7 @@ IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(), F->getEntryBlock().getFirstInsertionPt()); IRBuilder<>::InsertPoint AfterIP = - OMPBuilder.CreateParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, + OMPBuilder.createParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, false); EXPECT_EQ(NumBodiesGenerated, 1U); EXPECT_EQ(NumPrivatizedVars, 1U); @@ -445,7 +445,7 @@ CGBB->getTerminator()->eraseFromParent(); ; - IRBuilder<>::InsertPoint AfterIP = OMPBuilder.CreateParallel( + IRBuilder<>::InsertPoint AfterIP = OMPBuilder.createParallel( InsertPointTy(CGBB, CGBB->end()), AllocaIP, InnerBodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, false); @@ -456,7 +456,7 @@ IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(), F->getEntryBlock().getFirstInsertionPt()); IRBuilder<>::InsertPoint AfterIP = - OMPBuilder.CreateParallel(Loc, AllocaIP, OuterBodyGenCB, PrivCB, FiniCB, + OMPBuilder.createParallel(Loc, AllocaIP, OuterBodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, false); EXPECT_EQ(NumInnerBodiesGenerated, 1U); @@ -540,14 +540,14 @@ NewBB1->getTerminator()->eraseFromParent(); ; - IRBuilder<>::InsertPoint AfterIP1 = OMPBuilder.CreateParallel( + IRBuilder<>::InsertPoint AfterIP1 = OMPBuilder.createParallel( InsertPointTy(CGBB, CGBB->end()), AllocaIP, InnerBodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, false); Builder.restoreIP(AfterIP1); Builder.CreateBr(NewBB1); - IRBuilder<>::InsertPoint AfterIP2 = OMPBuilder.CreateParallel( + IRBuilder<>::InsertPoint AfterIP2 = OMPBuilder.createParallel( InsertPointTy(NewBB1, NewBB1->end()), AllocaIP, InnerBodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, false); @@ -558,7 +558,7 @@ IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(), F->getEntryBlock().getFirstInsertionPt()); IRBuilder<>::InsertPoint AfterIP = - OMPBuilder.CreateParallel(Loc, AllocaIP, OuterBodyGenCB, PrivCB, FiniCB, + OMPBuilder.createParallel(Loc, AllocaIP, OuterBodyGenCB, PrivCB, FiniCB, nullptr, nullptr, OMP_PROC_BIND_default, false); EXPECT_EQ(NumInnerBodiesGenerated, 2U); @@ -666,7 +666,7 @@ IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(), F->getEntryBlock().getFirstInsertionPt()); IRBuilder<>::InsertPoint AfterIP = - OMPBuilder.CreateParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, + OMPBuilder.createParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, Builder.CreateIsNotNull(F->arg_begin()), nullptr, OMP_PROC_BIND_default, false); @@ -741,7 +741,7 @@ Function *CBFn, *BFn; Builder.restoreIP( - OMPBuilder.CreateBarrier(Builder.saveIP(), OMPD_parallel)); + OMPBuilder.createBarrier(Builder.saveIP(), OMPD_parallel)); CBFn = M->getFunction("__kmpc_cancel_barrier"); BFn = M->getFunction("__kmpc_barrier"); @@ -753,7 +753,7 @@ CheckedBarrier = cast(CBFn->user_back()); Builder.restoreIP( - OMPBuilder.CreateBarrier(Builder.saveIP(), OMPD_parallel, true)); + OMPBuilder.createBarrier(Builder.saveIP(), OMPD_parallel, true)); CBFn = M->getFunction("__kmpc_cancel_barrier"); BFn = M->getFunction("__kmpc_barrier"); ASSERT_NE(CBFn, nullptr); @@ -763,7 +763,7 @@ ASSERT_TRUE(isa(BFn->user_back())); ASSERT_EQ(BFn->user_back()->getNumUses(), 0U); - Builder.restoreIP(OMPBuilder.CreateBarrier(Builder.saveIP(), OMPD_parallel, + Builder.restoreIP(OMPBuilder.createBarrier(Builder.saveIP(), OMPD_parallel, false, false)); ASSERT_EQ(CBFn->getNumUses(), 2U); ASSERT_EQ(BFn->getNumUses(), 1U); @@ -794,7 +794,7 @@ IRBuilder<>::InsertPoint AllocaIP(&F->getEntryBlock(), F->getEntryBlock().getFirstInsertionPt()); IRBuilder<>::InsertPoint AfterIP = - OMPBuilder.CreateParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, + OMPBuilder.createParallel(Loc, AllocaIP, BodyGenCB, PrivCB, FiniCB, Builder.CreateIsNotNull(F->arg_begin()), nullptr, OMP_PROC_BIND_default, true); @@ -850,7 +850,7 @@ }; CanonicalLoopInfo *Loop = - OMPBuilder.CreateCanonicalLoop(Loc, LoopBodyGenCB, TripCount); + OMPBuilder.createCanonicalLoop(Loc, LoopBodyGenCB, TripCount); Builder.restoreIP(Loop->getAfterIP()); ReturnInst *RetInst = Builder.CreateRetVoid(); @@ -904,7 +904,7 @@ Value *StepVal = ConstantInt::get(LCTy, Step); auto LoopBodyGenCB = [&](InsertPointTy CodeGenIP, llvm::Value *LC) {}; CanonicalLoopInfo *Loop = - OMPBuilder.CreateCanonicalLoop(Loc, LoopBodyGenCB, StartVal, StopVal, + OMPBuilder.createCanonicalLoop(Loc, LoopBodyGenCB, StartVal, StopVal, StepVal, IsSigned, InclusiveStop); Loop->assertOK(); Builder.restoreIP(Loop->getAfterIP()); @@ -1004,7 +1004,7 @@ EXPECT_NE(IPBB->end(), IP.getPoint()); }; - Builder.restoreIP(OMPBuilder.CreateMaster(Builder, BodyGenCB, FiniCB)); + Builder.restoreIP(OMPBuilder.createMaster(Builder, BodyGenCB, FiniCB)); Value *EntryBBTI = EntryBB->getTerminator(); EXPECT_NE(EntryBBTI, nullptr); EXPECT_TRUE(isa(EntryBBTI)); @@ -1074,7 +1074,7 @@ EXPECT_NE(IPBB->end(), IP.getPoint()); }; - Builder.restoreIP(OMPBuilder.CreateCritical(Builder, BodyGenCB, FiniCB, + Builder.restoreIP(OMPBuilder.createCritical(Builder, BodyGenCB, FiniCB, "testCRT", nullptr)); Value *EntryBBTI = EntryBB->getTerminator(); @@ -1130,7 +1130,8 @@ BasicBlock *EntryBB = BB; - OMPBuilder.CreateCopyinClauseBlocks(Builder.saveIP(), MasterAddress, PrivAddress, Int32, /*BranchtoEnd*/true); + OMPBuilder.createCopyinClauseBlocks(Builder.saveIP(), MasterAddress, + PrivAddress, Int32, /*BranchtoEnd*/ true); BranchInst* EntryBr = dyn_cast_or_null(EntryBB->getTerminator()); @@ -1197,7 +1198,7 @@ }; Builder.restoreIP( - OMPBuilder.CreateSingle(Builder, BodyGenCB, FiniCB, /*DidIt*/ nullptr)); + OMPBuilder.createSingle(Builder, BodyGenCB, FiniCB, /*DidIt*/ nullptr)); Value *EntryBBTI = EntryBB->getTerminator(); EXPECT_NE(EntryBBTI, nullptr); EXPECT_TRUE(isa(EntryBBTI)); diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp --- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp +++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp @@ -459,7 +459,7 @@ // above. llvm::OpenMPIRBuilder::InsertPointTy allocaIP(builder.saveIP()); builder.restoreIP( - ompBuilder->CreateParallel(builder, allocaIP, bodyGenCB, privCB, finiCB, + ompBuilder->createParallel(builder, allocaIP, bodyGenCB, privCB, finiCB, ifCond, numThreads, pbKind, isCancellable)); return success(); } @@ -475,15 +475,15 @@ } return llvm::TypeSwitch(&opInst) .Case([&](omp::BarrierOp) { - ompBuilder->CreateBarrier(builder.saveIP(), llvm::omp::OMPD_barrier); + ompBuilder->createBarrier(builder.saveIP(), llvm::omp::OMPD_barrier); return success(); }) .Case([&](omp::TaskwaitOp) { - ompBuilder->CreateTaskwait(builder.saveIP()); + ompBuilder->createTaskwait(builder.saveIP()); return success(); }) .Case([&](omp::TaskyieldOp) { - ompBuilder->CreateTaskyield(builder.saveIP()); + ompBuilder->createTaskyield(builder.saveIP()); return success(); }) .Case([&](omp::FlushOp) { @@ -495,7 +495,7 @@ // // The argument list is discarded so that, flush with a list is treated // same as a flush without a list. - ompBuilder->CreateFlush(builder.saveIP()); + ompBuilder->createFlush(builder.saveIP()); return success(); }) .Case([&](omp::TerminatorOp) {