Page MenuHomePhabricator
Differential D91080

[mlir][spirv] Expose more query APIs directly on TargetEnv
ClosedPublic
Actions

Authored by antiagainst on Nov 9 2020, 7:07 AM.

Details

Reviewers
mravishankar
hanchung
ThomasRaoux
Commits
rG21eb8127f412: [mlir][spirv] Expose more query APIs directly on TargetEnv
Summary

This allows us to omit one level of indirection when querying
the information from the underlying attribute.

Diff Detail

Event Timeline

antiagainst created this revision.Nov 9 2020, 7:07 AM
Herald added a reviewer: mravishankar. · View Herald TranscriptNov 9 2020, 7:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rdzhabarov, tatianashp, ThomasRaoux and 15 others. · View Herald Transcript
antiagainst requested review of this revision.Nov 9 2020, 7:07 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 9 2020, 7:07 AM
antiagainst added a reviewer: hanchung.Nov 9 2020, 7:07 AM
antiagainst retitled this revision from [mlir][spirv] NFC: expose more query APIs directly on TargetEnv to [mlir][spirv] Expose more query APIs directly on TargetEnv.Nov 9 2020, 7:19 AM
antiagainst added a reviewer: ThomasRaoux.
Harbormaster completed remote builds in B78126: Diff 303866.Nov 9 2020, 7:27 AM
hanchung accepted this revision.Nov 9 2020, 8:29 AM
This revision is now accepted and ready to land.Nov 9 2020, 8:29 AM
ThomasRaoux accepted this revision.Nov 9 2020, 8:52 AM
Closed by commit rG21eb8127f412: [mlir][spirv] Expose more query APIs directly on TargetEnv (authored by antiagainst). · Explain WhyNov 9 2020, 3:03 PM
This revision was automatically updated to reflect the committed changes.
antiagainst added a commit: rG21eb8127f412: [mlir][spirv] Expose more query APIs directly on TargetEnv.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SPIRV/
12 lines
16 lines
lib/
Dialect/
SPIRV/
14 lines
22 lines

Diff 303998

View Options

mlir/include/mlir/Dialect/SPIRV/SPIRVAttributes.h

Loading...
View Options

mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h

Loading...
View Options

mlir/lib/Dialect/SPIRV/SPIRVAttributes.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/TargetAndABI.cpp

Loading...