diff --git a/llvm/include/llvm/ADT/PackedVector.h b/llvm/include/llvm/ADT/PackedVector.h --- a/llvm/include/llvm/ADT/PackedVector.h +++ b/llvm/include/llvm/ADT/PackedVector.h @@ -30,14 +30,14 @@ static T getValue(const BitVectorTy &Bits, unsigned Idx) { T val = T(); for (unsigned i = 0; i != BitNum; ++i) - val = T(val | ((Bits[(Idx << (BitNum-1)) + i] ? 1UL : 0UL) << i)); + val = T(val | ((Bits[(Idx * BitNum) + i] ? 1UL : 0UL) << i)); return val; } static void setValue(BitVectorTy &Bits, unsigned Idx, T val) { assert((val >> BitNum) == 0 && "value is too big"); for (unsigned i = 0; i != BitNum; ++i) - Bits[(Idx << (BitNum-1)) + i] = val & (T(1) << i); + Bits[(Idx * BitNum) + i] = val & (T(1) << i); } }; @@ -47,8 +47,8 @@ static T getValue(const BitVectorTy &Bits, unsigned Idx) { T val = T(); for (unsigned i = 0; i != BitNum-1; ++i) - val = T(val | ((Bits[(Idx << (BitNum-1)) + i] ? 1UL : 0UL) << i)); - if (Bits[(Idx << (BitNum-1)) + BitNum-1]) + val = T(val | ((Bits[(Idx * BitNum) + i] ? 1UL : 0UL) << i)); + if (Bits[(Idx * BitNum) + BitNum - 1]) val = ~val; return val; } @@ -56,11 +56,11 @@ static void setValue(BitVectorTy &Bits, unsigned Idx, T val) { if (val < 0) { val = ~val; - Bits.set((Idx << (BitNum-1)) + BitNum-1); + Bits.set((Idx * BitNum) + BitNum - 1); } assert((val >> (BitNum-1)) == 0 && "value is too big"); for (unsigned i = 0; i != BitNum-1; ++i) - Bits[(Idx << (BitNum-1)) + i] = val & (T(1) << i); + Bits[(Idx * BitNum) + i] = val & (T(1) << i); } }; @@ -98,17 +98,17 @@ }; PackedVector() = default; - explicit PackedVector(unsigned size) : Bits(size << (BitNum-1)) {} + explicit PackedVector(unsigned size) : Bits(size * BitNum) {} bool empty() const { return Bits.empty(); } - unsigned size() const { return Bits.size() >> (BitNum - 1); } + unsigned size() const { return Bits.size() / BitNum; } void clear() { Bits.clear(); } - void resize(unsigned N) { Bits.resize(N << (BitNum - 1)); } + void resize(unsigned N) { Bits.resize(N * BitNum); } - void reserve(unsigned N) { Bits.reserve(N << (BitNum-1)); } + void reserve(unsigned N) { Bits.reserve(N * BitNum); } PackedVector &reset() { Bits.reset(); diff --git a/llvm/unittests/ADT/PackedVectorTest.cpp b/llvm/unittests/ADT/PackedVectorTest.cpp --- a/llvm/unittests/ADT/PackedVectorTest.cpp +++ b/llvm/unittests/ADT/PackedVectorTest.cpp @@ -61,6 +61,20 @@ EXPECT_EQ(3U, Vec[1]); } +TEST(PackedVectorTest, LongBits) { + PackedVector Vec1(8); + Vec1[0] = 100; + EXPECT_EQ(Vec1[0], 100); + Vec1[1] = 0x40000000 - 100; + EXPECT_EQ(Vec1[1], 0x40000000 - 100); + + PackedVector Vec2(8); + Vec2[7] = -100; + EXPECT_EQ(Vec2[7], -100); + Vec2[6] = 100 - 0x20000000; + EXPECT_EQ(Vec2[6], 100 - 0x20000000); +} + #ifdef EXPECT_DEBUG_DEATH TEST(PackedVectorTest, UnsignedValues) {