diff --git a/compiler-rt/lib/scudo/standalone/memtag.h b/compiler-rt/lib/scudo/standalone/memtag.h --- a/compiler-rt/lib/scudo/standalone/memtag.h +++ b/compiler-rt/lib/scudo/standalone/memtag.h @@ -28,9 +28,7 @@ inline uptr untagPointer(uptr Ptr) { return Ptr & ((1ULL << 56) - 1); } -inline uint8_t extractTag(uptr Ptr) { - return (Ptr >> 56) & 0xf; -} +inline uint8_t extractTag(uptr Ptr) { return (Ptr >> 56) & 0xf; } #else @@ -82,7 +80,7 @@ class ScopedDisableMemoryTagChecks { size_t PrevTCO; - public: +public: ScopedDisableMemoryTagChecks() { __asm__ __volatile__(".arch_extension mte; mrs %0, tco; msr tco, #1" : "=r"(PrevTCO)); @@ -190,8 +188,8 @@ 2: )" - : [ Cur ] "+&r"(RoundOldPtr), [ End ] "+&r"(NewPtr) - : [ BlockEnd ] "r"(BlockEnd) + : [Cur] "+&r"(RoundOldPtr), [End] "+&r"(NewPtr) + : [BlockEnd] "r"(BlockEnd) : "memory"); } diff --git a/compiler-rt/lib/scudo/standalone/options.h b/compiler-rt/lib/scudo/standalone/options.h --- a/compiler-rt/lib/scudo/standalone/options.h +++ b/compiler-rt/lib/scudo/standalone/options.h @@ -40,9 +40,7 @@ atomic_u32 Val; public: - Options load() const { - return Options{atomic_load(&Val, memory_order_relaxed)}; - } + Options load() const { return Options{atomic_load_relaxed(&Val)}; } void clear(OptionBit Opt) { atomic_fetch_and(&Val, ~(1U << static_cast(Opt)), @@ -54,7 +52,7 @@ } void setFillContentsMode(FillContentsMode FillContents) { - u32 Opts = atomic_load(&Val, memory_order_relaxed), NewOpts; + u32 Opts = atomic_load_relaxed(&Val), NewOpts; do { NewOpts = Opts; NewOpts &= ~(3U << static_cast(OptionBit::FillContents0of2)); diff --git a/compiler-rt/lib/scudo/standalone/primary32.h b/compiler-rt/lib/scudo/standalone/primary32.h --- a/compiler-rt/lib/scudo/standalone/primary32.h +++ b/compiler-rt/lib/scudo/standalone/primary32.h @@ -190,7 +190,7 @@ const s32 Interval = Max(Min(static_cast(Value), MaxReleaseToOsIntervalMs), MinReleaseToOsIntervalMs); - atomic_store(&ReleaseToOsIntervalMs, Interval, memory_order_relaxed); + atomic_store_relaxed(&ReleaseToOsIntervalMs, Interval); return true; } // Not supported by the Primary, but not an error either. @@ -462,8 +462,7 @@ } if (!Force) { - const s32 IntervalMs = - atomic_load(&ReleaseToOsIntervalMs, memory_order_relaxed); + const s32 IntervalMs = atomic_load_relaxed(&ReleaseToOsIntervalMs); if (IntervalMs < 0) return 0; if (Sci->ReleaseInfo.LastReleaseAtNs + diff --git a/compiler-rt/lib/scudo/standalone/primary64.h b/compiler-rt/lib/scudo/standalone/primary64.h --- a/compiler-rt/lib/scudo/standalone/primary64.h +++ b/compiler-rt/lib/scudo/standalone/primary64.h @@ -191,7 +191,7 @@ const s32 Interval = Max(Min(static_cast(Value), MaxReleaseToOsIntervalMs), MinReleaseToOsIntervalMs); - atomic_store(&ReleaseToOsIntervalMs, Interval, memory_order_relaxed); + atomic_store_relaxed(&ReleaseToOsIntervalMs, Interval); return true; } // Not supported by the Primary, but not an error either. @@ -470,8 +470,7 @@ } if (!Force) { - const s32 IntervalMs = - atomic_load(&ReleaseToOsIntervalMs, memory_order_relaxed); + const s32 IntervalMs = atomic_load_relaxed(&ReleaseToOsIntervalMs); if (IntervalMs < 0) return 0; if (Region->ReleaseInfo.LastReleaseAtNs + diff --git a/compiler-rt/lib/scudo/standalone/secondary.h b/compiler-rt/lib/scudo/standalone/secondary.h --- a/compiler-rt/lib/scudo/standalone/secondary.h +++ b/compiler-rt/lib/scudo/standalone/secondary.h @@ -94,7 +94,7 @@ bool EntryCached = false; bool EmptyCache = false; const u64 Time = getMonotonicTime(); - const u32 MaxCount = atomic_load(&MaxEntriesCount, memory_order_relaxed); + const u32 MaxCount = atomic_load_relaxed(&MaxEntriesCount); { ScopedLock L(Mutex); if (EntriesCount >= MaxCount) { @@ -121,15 +121,14 @@ s32 Interval; if (EmptyCache) empty(); - else if ((Interval = atomic_load(&ReleaseToOsIntervalMs, - memory_order_relaxed)) >= 0) + else if ((Interval = atomic_load_relaxed(&ReleaseToOsIntervalMs)) >= 0) releaseOlderThan(Time - static_cast(Interval) * 1000000); return EntryCached; } bool retrieve(uptr Size, LargeBlock::Header **H) { const uptr PageSize = getPageSizeCached(); - const u32 MaxCount = atomic_load(&MaxEntriesCount, memory_order_relaxed); + const u32 MaxCount = atomic_load_relaxed(&MaxEntriesCount); ScopedLock L(Mutex); if (EntriesCount == 0) return false; @@ -154,8 +153,8 @@ } bool canCache(uptr Size) { - return atomic_load(&MaxEntriesCount, memory_order_relaxed) != 0U && - Size <= atomic_load(&MaxEntrySize, memory_order_relaxed); + return atomic_load_relaxed(&MaxEntriesCount) != 0U && + Size <= atomic_load_relaxed(&MaxEntrySize); } bool setOption(Option O, sptr Value) { @@ -163,17 +162,16 @@ const s32 Interval = Max(Min(static_cast(Value), MaxReleaseToOsIntervalMs), MinReleaseToOsIntervalMs); - atomic_store(&ReleaseToOsIntervalMs, Interval, memory_order_relaxed); + atomic_store_relaxed(&ReleaseToOsIntervalMs, Interval); return true; } else if (O == Option::MaxCacheEntriesCount) { const u32 MaxCount = static_cast(Value); if (MaxCount > EntriesArraySize) return false; - atomic_store(&MaxEntriesCount, MaxCount, memory_order_relaxed); + atomic_store_relaxed(&MaxEntriesCount, MaxCount); return true; } else if (O == Option::MaxCacheEntrySize) { - atomic_store(&MaxEntrySize, static_cast(Value), - memory_order_relaxed); + atomic_store_relaxed(&MaxEntrySize, static_cast(Value)); return true; } // Not supported by the Secondary Cache, but not an error either. diff --git a/compiler-rt/lib/scudo/standalone/stack_depot.h b/compiler-rt/lib/scudo/standalone/stack_depot.h --- a/compiler-rt/lib/scudo/standalone/stack_depot.h +++ b/compiler-rt/lib/scudo/standalone/stack_depot.h @@ -20,7 +20,7 @@ static const u32 R = 24; u32 H; - public: +public: explicit MurMur2HashBuilder(u32 Init = 0) { H = Seed ^ Init; } void add(u32 K) { K *= M;