Add -S option

[coti]

Summary

Everything is in the title. -S (do not assemble) is not supported by the frontend yet.

When -S is passed:

• do not call the link command ad the end (driver.compileOnly = true)
• the generated file (relo) ends with .s and not with .o
• do not remove it

I have also added it in the help displayed by -h.

I don't really know what to test in the associated unit test, since the generated assembly code depends on the backed compiler we are using...

[AlexisPerry]

The idea seems solid to me, but I am also unsure how best to test this. Also, did you clang-format the code before uploading the patch?

[coti]

yes, I clang-format-ed the code, and I think this is what explains the modification line 620 for example.

[awarzynski]

This patch touches the old driver, f18, which has been deleted a while back: https://reviews.llvm.org/D105811. I suggest closing this PR.

If you require this functionality, it's currently under active development in fir-dev.

-Andrzej

flang/tools/f18/f18.cpp

   bool getDefinition{false};
   GetDefinitionArgs getDefinitionArgs{0, 0, 0};
   bool getSymbolsSources{false};
+  bool dashc{true};
+  bool assemble{true};
 };
 
 void Exec(std::vector<llvm::StringRef> &argv, bool verbose = false) {

   for (size_t j{0}; j < driver.F18_FCArgs.size(); ++j) {
     argv.push_back(driver.F18_FCArgs[j]);
   }
-  char dashC[3] = "-c", dashO[3] = "-o";
-  argv.push_back(dashC);
+  char dashC[3] = "-c", dashO[3] = "-o", dashS[3] = "-S";
+  if (driver.dashc) {
+    argv.push_back(dashC);
+  }
   argv.push_back(dashO);
   argv.push_back(relo);
+  if (!driver.assemble) {
+    argv.push_back(dashS);
+  }
   argv.push_back(source);
   Exec(argv, driver.verbose);
 }

   if (dot != std::string::npos) {
     relo = base.substr(0, dot);
   }
-  relo += ".o";
+  if (driver.assemble) {
+    relo += ".o";
+  } else {
+    relo += ".s";
+  }
   return relo;
 }
 

           << "\n"
           << "Defaults:\n"
           << "  When invoked with input files, and no options to tell\n"
-          << "  it otherwise, f18 will unparse its input and pass that on to an\n"
+          << "  it otherwise, f18 will unparse its input and pass that on to "
+             "an\n"
           << "  external compiler to continue the compilation.\n"
           << "  The external compiler is specified by the F18_FC environment\n"
           << "  variable. The default is 'gfortran'.\n"

           << "  -fdebug-no-semantics  disable semantic checks\n"
           << "  -fget-definition\n"
           << "  -fget-symbols-sources\n"
-          << "  -v -c -o -I -D -U    have their usual meanings\n"
+          << "  -v -c -o -I -D -U -S   have their usual meanings\n"
           << "  -help                print this again\n"
-          << "Unrecognised options are passed through to the external compiler\n"
+          << "Unrecognised options are passed through to the external "
+             "compiler\n"
           << "set by F18_FC (see defaults).\n";
       return exitStatus;
     } else if (arg == "-V" || arg == "--version") {
       return printVersion();
+    } else if (arg == "-S") {
+      driver.dashc = false;
+      driver.assemble = false;
+      driver.compileOnly = true;
     } else {
       driver.F18_FCArgs.push_back(arg);
       if (arg == "-v") {