diff --git a/mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp b/mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp --- a/mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp +++ b/mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp @@ -138,7 +138,7 @@ target.addIllegalDialect(); target.addIllegalOp(); + LLVM::Log2Op, LLVM::SinOp>(); target.addIllegalOp(); target.addLegalDialect(); // TODO: Remove once we support replacing non-root ops. @@ -183,6 +183,8 @@ "__nv_log10"); patterns.insert>(converter, "__nv_log2f", "__nv_log2"); + patterns.insert>(converter, "__nv_sinf", + "__nv_sin"); patterns.insert>(converter, "__nv_tanhf", "__nv_tanh"); } diff --git a/mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir b/mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir --- a/mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir +++ b/mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir @@ -261,6 +261,21 @@ // ----- +gpu.module @test_module { + // CHECK: llvm.func @__nv_sinf(!llvm.float) -> !llvm.float + // CHECK: llvm.func @__nv_sin(!llvm.double) -> !llvm.double + // CHECK-LABEL: func @gpu_sin + func @gpu_sin(%arg_f32 : f32, %arg_f64 : f64) -> (f32, f64) { + %result32 = std.sin %arg_f32 : f32 + // CHECK: llvm.call @__nv_sinf(%{{.*}}) : (!llvm.float) -> !llvm.float + %result64 = std.sin %arg_f64 : f64 + // CHECK: llvm.call @__nv_sin(%{{.*}}) : (!llvm.double) -> !llvm.double + std.return %result32, %result64 : f32, f64 + } +} + +// ----- + gpu.module @test_module { // CHECK: llvm.func @__nv_tanhf(!llvm.float) -> !llvm.float // CHECK: llvm.func @__nv_tanh(!llvm.double) -> !llvm.double