diff --git a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp --- a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp +++ b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp @@ -168,6 +168,16 @@ )"), cl::init(""), cl::cat(ClangTidyCategory)); +static cl::opt ConfigFile("config-file", cl::desc(R"( +Specify the path of .clang-tidy or custom config file: + e.g. --config-file=/some/path/myTidyConfigFile +This option internally works exactly the same way as + --config option after reading specified config file. +Use either --config-file or --config, not both. +)"), + cl::init(""), + cl::cat(ClangTidyCategory)); + static cl::opt DumpConfig("dump-config", cl::desc(R"( Dumps configuration in the YAML format to stdout. This option can be used along with a @@ -302,19 +312,41 @@ if (UseColor.getNumOccurrences() > 0) OverrideOptions.UseColor = UseColor; - if (!Config.empty()) { - if (llvm::ErrorOr ParsedConfig = - parseConfiguration(Config)) { + auto LoadConfig = [&](StringRef Configuration) + -> std::unique_ptr { + llvm::ErrorOr ParsedConfig = + parseConfiguration(Configuration); + if (ParsedConfig) return std::make_unique( GlobalOptions, ClangTidyOptions::getDefaults().mergeWith(DefaultOptions, 0), *ParsedConfig, OverrideOptions, std::move(FS)); - } else { - llvm::errs() << "Error: invalid configuration specified.\n" - << ParsedConfig.getError().message() << "\n"; + llvm::errs() << "Error: invalid configuration specified.\n" + << ParsedConfig.getError().message() << "\n"; + return nullptr; + }; + + if (ConfigFile.getNumOccurrences() > 0) { + if (Config.getNumOccurrences() > 0) { + llvm::errs() << "Error: --config-file and --config are " + "mutually exclusive. Specify only one.\n"; return nullptr; } + + llvm::ErrorOr> Text = + llvm::MemoryBuffer::getFile(ConfigFile.c_str()); + if (std::error_code EC = Text.getError()) { + llvm::errs() << "Error: can't read config-file '" << ConfigFile + << "': " << EC.message() << "\n"; + return nullptr; + } + + return LoadConfig((*Text)->getBuffer()); } + + if (Config.getNumOccurrences() > 0) + return LoadConfig(Config); + return std::make_unique(GlobalOptions, DefaultOptions, OverrideOptions, std::move(FS)); } diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-file/config-file b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-file/config-file new file mode 100644 --- /dev/null +++ b/clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-file/config-file @@ -0,0 +1 @@ +Checks: "-*,hicpp-uppercase-literal-suffix" diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp new file mode 100644 --- /dev/null +++ b/clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp @@ -0,0 +1,2 @@ +// RUN: clang-tidy -config-file=%S/Inputs/config-file/config-file -dump-config -- | FileCheck %s -check-prefix=CHECK-BASE +// CHECK-BASE: Checks: {{.*}}hicpp-uppercase-literal-suffix