[CMake] Don't add -lstdc++ to LDFLAGS

[arichardson]

Summary

If the target includes a C++ source file, CMake will automatically link
the C++ standard library. This is useful when building on platforms where
libstdc++.so does not exist (e.g. CheriBSD since we only use libc++.so).

[smeenai]

Both CMake and the driver (assuming it's invoked as clang++/g++) should take care of adding the C++ standard library, so this LGTM.

[arichardson]

Seems like the test-suite repository doesn't auto-close revisions.

Committed as https://github.com/llvm/llvm-test-suite/commit/eef6375030183ff0a3d3defd3b408d246931a140.

External/Nurbs/CMakeLists.txt

 # Nurbs uses SSE and only works on x86.
 if(ARCH STREQUAL "x86")
   include(External)
   llvm_externals_find(TEST_SUITE_NURBS_ROOT "nurbs" "Nurbs")
 
   if(TEST_SUITE_NURBS_ROOT)
-    list(APPEND LDFLAGS -lstdc++)
     if(CMAKE_SIZEOF_VOID_P EQUAL 8)
       list(APPEND CPPFLAGS -DDWORD_IS_ULL)
     endif()
 
     llvm_test_run(/k all timed /t 500 /vsteps 192 /usteps 192 /vcp 20 /ucp 20)
     llvm_test_verify(WORKDIR ${CMAKE_CURRENT_BINARY_DIR}
       ${FPCMP} %o nurbs.reference_output
     )
 
     file(GLOB SOURCES ${TEST_SUITE_NURBS_ROOT}/*.cpp)
     llvm_test_executable(nurbs ${SOURCES})
     llvm_test_data(nurbs nurbs.reference_output)
 
     file(COPY lit.local.cfg DESTINATION "${CMAKE_CURRENT_BINARY_DIR}")
   endif()
 endif()

MultiSource/Applications/ALAC/decode/CMakeLists.txt

 if(ENDIAN STREQUAL "little")
   list(APPEND CFLAGS -DTARGET_RT_LITTLE_ENDIAN=1)
   list(APPEND CXXFLAGS -DTARGET_RT_LITTLE_ENDIAN=1)
 else()
   list(APPEND CFLAGS -DTARGET_RT_BIG_ENDIAN=1)
   list(APPEND CXXFLAGS -DTARGET_RT_BIG_ENDIAN=1)
 endif()
-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS - - < tune.caf)
 llvm_multisource(alacconvert-decode
   EndianPortable.c
   ALACBitUtilities.c
   ALACDecoder.cpp
   ALACEncoder.cpp
   ag_dec.c
   ag_enc.c
   dp_dec.c
   dp_enc.c
   matrix_dec.c
   matrix_enc.c
   main.cpp
   CAFFileALAC.cpp
 )
 llvm_test_data(alacconvert-decode tune.caf)

MultiSource/Applications/ALAC/encode/CMakeLists.txt

 if(ENDIAN STREQUAL "little")
   list(APPEND CFLAGS -DTARGET_RT_LITTLE_ENDIAN=1)
   list(APPEND CXXFLAGS -DTARGET_RT_LITTLE_ENDIAN=1)
 else()
   list(APPEND CFLAGS -DTARGET_RT_BIG_ENDIAN=1)
   list(APPEND CXXFLAGS -DTARGET_RT_BIG_ENDIAN=1)
 endif()
-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS - - < tune.wav)
 llvm_multisource(alacconvert-encode
   EndianPortable.c
   ALACBitUtilities.c
   ALACDecoder.cpp
   ALACEncoder.cpp
   ag_dec.c
   ag_enc.c
   dp_dec.c
   dp_enc.c
   matrix_dec.c
   matrix_enc.c
   main.cpp
   CAFFileALAC.cpp
 )
 llvm_test_data(alacconvert-encode tune.wav)

MultiSource/Applications/Burg/CMakeLists.txt

 list(APPEND CPPFLAGS -DDEBUG)
 list(APPEND CFLAGS -std=gnu89)
-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS < sample.gr)
 
 include_directories(${CMAKE_CURRENT_BINARY_DIR})
 llvm_multisource(burg)
 llvm_test_data(burg sample.gr)

MultiSource/Applications/hbd/CMakeLists.txt

 list(APPEND CPPFLAGS -DHAVE_CONFIG_H)
-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS Sort.class)
 llvm_multisource(hbd)
 llvm_test_data(hbd Sort.class)

MultiSource/Applications/hexxagon/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS < input)
 llvm_multisource(hexxagon)
 target_include_directories(hexxagon PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
 llvm_test_data(hexxagon input)

MultiSource/Applications/kimwitu++/CMakeLists.txt

 list(APPEND CPPFLAGS -I${CMAKE_CURRENT_SOURCE_DIR} -DYYDEBUG=1)
-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS -f test  -o -v -s kcc inputs/f3.k inputs/f2.k inputs/f1.k)
 set(HASH_PROGRAM_OUTPUT 1)
 llvm_multisource(kc)
 llvm_test_data(kc inputs/f3.k inputs/f2.k inputs/f1.k)

MultiSource/Applications/lambda-0.1.3/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS < input)
 llvm_multisource(lambda)
 target_include_directories(lambda PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
 llvm_test_data(lambda input)

MultiSource/Applications/minisat/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++ -lm)
+list(APPEND LDFLAGS -lm)
 if(SMALL_PROBLEM_SIZE)
   set(INPUT small.cnf)
 else()
   if(LARGE_PROBLEM_SIZE)
     set(INPUT long.cnf)
   else()
     set(INPUT short.cnf)
   endif()
 endif()
 set(RUN_OPTIONS -verbosity=0 ${INPUT})
 set(FP_TOLERANCE 0.1)
 llvm_multisource(minisat)
 llvm_test_data(minisat ${INPUT})

MultiSource/Benchmarks/7zip/CMakeLists.txt

 set(RUN_OPTIONS b)
 list(APPEND CFLAGS -DBREAK_HANDLER -DUNICODE -D_UNICODE -I${CMAKE_CURRENT_SOURCE_DIR}/C -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/myWindows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/include_windows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP -I. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNDEBUG -D_REENTRANT -DENV_UNIX -D_7ZIP_LARGE_PAGES -pthread)
 list(APPEND CXXFLAGS -Wno-error=c++11-narrowing -DBREAK_HANDLER -DUNICODE -D_UNICODE -I${CMAKE_CURRENT_SOURCE_DIR}/C -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/myWindows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/include_windows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP -I. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNDEBUG -D_REENTRANT -DENV_UNIX -D_7ZIP_LARGE_PAGES -pthread)
-list(APPEND LDFLAGS -lstdc++ -pthread)
+list(APPEND LDFLAGS -pthread)
 set(NO_REFERENCE_OUTPUT 1)
 llvm_multisource(7zip-benchmark
   CPP/myWindows/myGetTickCount.cpp
   CPP/myWindows/wine_date_and_time.cpp
   CPP/myWindows/myAddExeFlag.cpp
   CPP/myWindows/mySplitCommandLine.cpp
   CPP/7zip/UI/Console/BenchCon.cpp
   CPP/7zip/UI/Console/ConsoleClose.cpp

MultiSource/Benchmarks/Bullet/CMakeLists.txt

 list(APPEND CPPFLAGS -I${CMAKE_CURRENT_SOURCE_DIR}/include -std=gnu++98 -DNO_TIME)
-list(APPEND LDFLAGS -lstdc++ -lm)
+list(APPEND LDFLAGS -lm)
 llvm_multisource(bullet)

MultiSource/Benchmarks/PAQ8p/CMakeLists.txt

 list(APPEND CPPFLAGS -DNOASM -DLLVM)
-list(APPEND LDFLAGS -lstdc++ -lm)
+list(APPEND LDFLAGS -lm)
 if(SMALL_PROBLEM_SIZE)
   set(INPUTS small.in)
   set(RUN_OPTIONS -1 ${INPUTS})
 else()
   set(INPUTS file1.in)
   set(RUN_OPTIONS -4 ${INPUTS})
 endif()
 llvm_multisource(paq8p)
 llvm_test_data(paq8p ${INPUTS})

MultiSource/Benchmarks/Prolangs-C++/NP/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(np)

MultiSource/Benchmarks/Prolangs-C++/city/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(city)
 target_include_directories(city PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})

MultiSource/Benchmarks/Prolangs-C++/deriv1/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(deriv1)

MultiSource/Benchmarks/Prolangs-C++/deriv2/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(deriv2)

MultiSource/Benchmarks/Prolangs-C++/employ/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 set(RUN_OPTIONS 400 < input.txt)
 set(HASH_PROGRAM_OUTPUT 1)
 llvm_multisource(employ)
 llvm_test_data(employ input.txt)

MultiSource/Benchmarks/Prolangs-C++/family/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(family)

MultiSource/Benchmarks/Prolangs-C++/fsm/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(fsm)

MultiSource/Benchmarks/Prolangs-C++/garage/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(garage)

MultiSource/Benchmarks/Prolangs-C++/life/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(life)

MultiSource/Benchmarks/Prolangs-C++/objects/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(objects)

MultiSource/Benchmarks/Prolangs-C++/ocean/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(ocean)

MultiSource/Benchmarks/Prolangs-C++/office/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(office)

MultiSource/Benchmarks/Prolangs-C++/primes/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(primes)

MultiSource/Benchmarks/Prolangs-C++/shapes/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(shapes)

MultiSource/Benchmarks/Prolangs-C++/simul/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(simul)

MultiSource/Benchmarks/Prolangs-C++/trees/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(trees)

MultiSource/Benchmarks/Prolangs-C++/vcirc/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_multisource(vcirc)

MultiSource/Benchmarks/tramp3d-v4/CMakeLists.txt

 list(APPEND CXXFLAGS -fno-exceptions)
-list(APPEND LDFLAGS -lstdc++)
 if(SMALL_PROBLEM_SIZE)
   set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32)
 else()
   set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32)
 endif()
 if(MIPS_IS_MIPS64_ENABLED)
   list(APPEND CXXFLAGS -mxgot)
 endif()
 set(FP_ABSTOLERANCE 0.0000001)
 llvm_multisource(tramp3d-v4)

SingleSource/Benchmarks/Adobe-C++/CMakeLists.txt

-list(APPEND LDFLAGS -lm -lstdc++)
+list(APPEND LDFLAGS -lm)
 set(FP_ABSTOLERANCE 0.01)
 llvm_singlesource()

SingleSource/Benchmarks/CoyoteBench/CMakeLists.txt

-list(APPEND LDFLAGS -lm -lstdc++)
+list(APPEND LDFLAGS -lm)
 llvm_singlesource()

SingleSource/Benchmarks/Misc-C++-EH/CMakeLists.txt

 list(APPEND CXXFLAGS -pthread)
-list(APPEND LDFLAGS -lm -lstdc++ -pthread)
+list(APPEND LDFLAGS -lm -pthread)
 llvm_singlesource()

SingleSource/Benchmarks/Misc-C++/CMakeLists.txt

 add_subdirectory(Large)
 
-list(APPEND LDFLAGS -lm -lstdc++)
+list(APPEND LDFLAGS -lm)
 set(FP_ABSTOLERANCE 0.01)
 llvm_singlesource()

SingleSource/Benchmarks/Misc-C++/Large/CMakeLists.txt

-list(APPEND LDFLAGS -lm -lstdc++)
+list(APPEND LDFLAGS -lm)
 set(FP_ABSTOLERANCE 0.01)
 set(HASH_PROGRAM_OUTPUT 1)
 llvm_singlesource()

SingleSource/Benchmarks/Shootout-C++/CMakeLists.txt

list(APPEND Source
     hello.cpp
     reversefile.cpp
     spellcheck.cpp
     sumcol.cpp
     wc.cpp
     wordfreq.cpp
   )
 endif()
-list(APPEND LDFLAGS -lstdc++ -lm)
+list(APPEND LDFLAGS -lm)
 if(TARGET_OS STREQUAL "Darwin")
   # Necessary for ackermann on iOS
   list(APPEND LDFLAGS -Xlinker -stack_size -Xlinker 0x800000)
 endif()
 llvm_singlesource(PREFIX Shootout-C++-)

SingleSource/Benchmarks/Shootout-C++/EH/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource(PREFIX "Shootout-C++-")

SingleSource/Benchmarks/SmallPT/CMakeLists.txt

 list(APPEND CXXFLAGS -std=gnu++98)
-list(APPEND LDFLAGS -lm -lstdc++)
+list(APPEND LDFLAGS -lm)
 set(FP_TOLERANCE 0.001)
 llvm_singlesource()

SingleSource/Regression/C++/CMakeLists.txt

 add_subdirectory(EH)
 
-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource(PREFIX "Regression-C++-")

SingleSource/Regression/C++/EH/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource(PREFIX "Regression-C++-")

SingleSource/UnitTests/C++11/CMakeLists.txt

 list(APPEND CXXFLAGS -std=c++11 -pthread)
-list(APPEND LDFLAGS -lstdc++ -pthread)
+list(APPEND LDFLAGS -pthread)
 
 file(GLOB Source RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.c *.cpp)
 if(${CMAKE_EXE_LINKER_FLAGS} MATCHES "-static")
   list(APPEND LDFLAGS -Wl,--whole-archive -lpthread -Wl,--no-whole-archive)
 endif()
 
 llvm_singlesource()

SingleSource/UnitTests/CMakeLists.txt

if(ARCH STREQUAL "Mips")
   if(NOT MIPS_IS_MIPS64_ENABLED)
     list(REMOVE_ITEM Source AtomicOps.c)
   endif()
 endif()
 if(ARCH STREQUAL "XCore")
   list(REMOVE_ITEM Source AtomicOps.c)
   list(REMOVE_ITEM Source initp1.cpp)
 endif()
-list(APPEND LDFLAGS -lstdc++)
 if(NOT ARCH STREQUAL "x86")
   list(REMOVE_ITEM Source
     ms_struct-bitfield.c
     ms_struct-bitfield-1.c
     ms_struct-bitfield-init.c
     ms_struct-bitfield-init-1.c
     ms_struct_pack_layout.c
     ms_struct_pack_layout-1.c

SingleSource/UnitTests/EH/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource()

SingleSource/UnitTests/Integer/CMakeLists.txt

 set(RUN_OPTIONS 31415926)
-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource()

SingleSource/UnitTests/ObjC++/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++ -lobjc -framework Foundation)
+list(APPEND LDFLAGS -lobjc -framework Foundation)
 file(GLOB Source *.mm)
 llvm_singlesource()

SingleSource/UnitTests/SetjmpLongjmp/C++/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource()

SingleSource/UnitTests/SignlessTypes/CMakeLists.txt

 add_subdirectory(Large)
 
 set(RUN_OPTIONS 31415926)
-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource()

SingleSource/UnitTests/SignlessTypes/Large/CMakeLists.txt

 set(RUN_OPTIONS 31415926)
-list(APPEND LDFLAGS -lstdc++)
 set(HASH_PROGRAM_OUTPUT 1)
 llvm_singlesource()

SingleSource/UnitTests/Vectorizer/CMakeLists.txt

-list(APPEND LDFLAGS -lstdc++)
 llvm_singlesource()